Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-08-02 Thread Ivan Ren
On Fri, Aug 2, 2019 at 1:59 PM Wei Yang wrote: > > On Fri, Aug 02, 2019 at 01:46:41PM +0800, Ivan Ren wrote: > > s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); > >+/* > >+ * Update s->iteration_initial_bytes to match > >>>s->iteration_start_time. >

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-08-02 Thread Wei Yang
On Fri, Aug 02, 2019 at 01:46:41PM +0800, Ivan Ren wrote: > s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); >+/* >+ * Update s->iteration_initial_bytes to match >>>s->iteration_start_time. >+ */ >+s->iteration_initial_bytes =

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-08-01 Thread Ivan Ren
s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); +/* + * Update s->iteration_initial_bytes to match >>s->iteration_start_time. + */ +s->iteration_initial_bytes = migration_total_bytes(s); >>> >>>Is this one necessary? We have sent out

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-08-01 Thread Wei Yang
On Thu, Aug 01, 2019 at 04:10:34PM +0800, Ivan Ren wrote: >>> s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); >>>+/* >>>+ * Update s->iteration_initial_bytes to match >s->iteration_start_time. >>>+ */ >>>+s->iteration_initial_bytes = migration_total_bytes(s);

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-08-01 Thread Ivan Ren
>> s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); >>+/* >>+ * Update s->iteration_initial_bytes to match s->iteration_start_time. >>+ */ >>+s->iteration_initial_bytes = migration_total_bytes(s); > >Is this one necessary? We have sent out nothing yet. Yes,

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-07-31 Thread Wei Yang
On Tue, Jul 30, 2019 at 01:36:32PM +0800, Ivan Ren wrote: >From: Ivan Ren > >This patch fix a multifd migration bug in migration speed calculation, this >problem can be reproduced as follows: >1. start a vm and give a heavy memory write stress to prevent the vm be > successfully migrated to

Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration

2019-07-30 Thread Juan Quintela
Ivan Ren wrote: > From: Ivan Ren > > This patch fix a multifd migration bug in migration speed calculation, this > problem can be reproduced as follows: > 1. start a vm and give a heavy memory write stress to prevent the vm be >successfully migrated to destination > 2. begin a migration with