Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 22, 2017 at 01:37:39PM +0200, Cédric Le Goater wrote: > >> well, it would be good to be able to define chips with different > >> numbers of cpus. That is something will we want to do for sure. > > > > You mean multiple chips in a single system with non-uniform numbers of > > cores?

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

>> well, it would be good to be able to define chips with different >> numbers of cpus. That is something will we want to do for sure. > > You mean multiple chips in a single system with non-uniform numbers of > cores? Are there really such systems in the wild? > When CPU fail for some reason,

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 22, 2017 at 12:56:40PM +0200, Cédric Le Goater wrote: > On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > > > > As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the > > default value of 1 in vl.c.

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 22, 2017 at 12:46:58PM +0200, Cédric Le Goater wrote: > On 09/22/2017 12:12 PM, David Gibson wrote: > > On Fri, Sep 22, 2017 at 08:07:06AM +0200, Cédric Le Goater wrote: > >> On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > >>> David Gibson writes: > >>>

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

Cédric Le Goater writes: > On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> >> As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the >> default value of 1 in vl.c. In powernv, we were setting

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > David Gibson writes: > > > As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the > default value of 1 in vl.c. In powernv, we were setting nr-cores like > this: > >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/22/2017 12:08 PM, David Gibson wrote: > On Thu, Sep 21, 2017 at 08:04:55AM +0200, Cédric Le Goater wrote: >> On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote:

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/22/2017 12:12 PM, David Gibson wrote: > On Fri, Sep 22, 2017 at 08:07:06AM +0200, Cédric Le Goater wrote: >> On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> >>> >>> As smp_thread defaults to 1 in vl.c, similarly smp_cores

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 22, 2017 at 08:07:06AM +0200, Cédric Le Goater wrote: > On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > > > > As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the > > default value of 1 in vl.c.

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Thu, Sep 21, 2017 at 08:04:55AM +0200, Cédric Le Goater wrote: > On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > >> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > >>> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Thu, Sep 21, 2017 at 09:42:26AM +0200, Igor Mammedov wrote: > On Thu, 21 Sep 2017 08:04:55 +0200 > Cédric Le Goater wrote: > > > On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > > > David Gibson writes: > > > > > >> On Wed, Sep 20, 2017 at

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > David Gibson writes: > > > As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the > default value of 1 in vl.c. In powernv, we were setting nr-cores like > this: > >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: >> >> >> >> As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the >> >> default value of 1 in vl.c. In powernv, we were setting nr-cores like >> >> this: >> >> >> >> object_property_set_int(chip, smp_cores, "nr-cores",

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Thu, 21 Sep 2017 08:04:55 +0200 Cédric Le Goater wrote: > On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > >> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > >>> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Thu, Sep 21, 2017 at 09:24:46AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 12:10:48PM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > David Gibson writes: > >> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 10:43:19AM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/20/2017 09:18 AM, Nikunj A Dadhania wrote: > David Gibson writes: > >> On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >>> David Gibson writes: >>> On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 09:50:24AM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

Nikunj A Dadhania writes: >> >> >>> >> I think the current approach is the simplest and less intrusive, as we >>> >> are handling a case where user has not bothered to provide a detailed >>> >> topology, the best we can do is create single threaded cores equal to >>>

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Fri, Sep 15, 2017 at 02:39:16PM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Fri, Sep 15, 2017 at 01:53:15PM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: >> >> David Gibson

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> >> > >> >> I thought, I am doing the

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> >> >> >> I thought, I am doing the same here for PowerNV, number of online cores >> >> is equal to initial online

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > >> > >> I thought, I am doing the same here for PowerNV, number of online cores > >> is equal to initial online vcpus / threads per core > >> > >>int boot_cores_nr =

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: >> >> I thought, I am doing the same here for PowerNV, number of online cores >> is equal to initial online vcpus / threads per core >> >>int boot_cores_nr = smp_cpus / smp_threads; >> >> Only difference that I see in PowerNV is that we

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Thu, Sep 14, 2017 at 10:42:52AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Mon, Sep 11, 2017 at 10:40:10AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 06, 2017 at 01:57:48PM

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Mon, Sep 11, 2017 at 10:40:10AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote: >> >> When the user does not provide the cpu

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Mon, Sep 11, 2017 at 10:40:10AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote: > >> When the user does not provide the cpu topology, e.g. "-smp 4", machine > >> fails to > >>

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

David Gibson writes: > On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote: >> When the user does not provide the cpu topology, e.g. "-smp 4", machine >> fails to >> initialize 4 cpus. Compute the chip per cores depending on the number of >> chips >>

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On Wed, Sep 06, 2017 at 01:57:48PM +0530, Nikunj A Dadhania wrote: > When the user does not provide the cpu topology, e.g. "-smp 4", machine fails > to > initialize 4 cpus. Compute the chip per cores depending on the number of chips > and smt threads. > > Signed-off-by: Nikunj A Dadhania

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

On 09/06/2017 10:27 AM, Nikunj A Dadhania wrote: > When the user does not provide the cpu topology, e.g. "-smp 4", machine fails > to > initialize 4 cpus. Compute the chip per cores depending on the number of chips > and smt threads. I think we could also use the '-numa' options to define the