Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 11:07, Peter Maydell wrote: > On 23 November 2017 at 22:08, Paolo Bonzini wrote: >> On 22/11/2017 13:14, Peter Maydell wrote: We do this all of the time for more regular tests that are obviously compile-time. I am a really big fan of this, because it

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-24 Thread Peter Maydell
On 23 November 2017 at 22:08, Paolo Bonzini wrote: > On 22/11/2017 13:14, Peter Maydell wrote: >>> We do this all of the time for more regular tests that are obviously >>> compile-time. I am a really big fan of this, because it makes sure that the >>> (usually 32-bit) else

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-23 Thread Paolo Bonzini
On 22/11/2017 13:14, Peter Maydell wrote: >> We do this all of the time for more regular tests that are obviously >> compile-time. I am a really big fan of this, because it makes sure that the >> (usually 32-bit) else branch continues to compile. > I'm happy with code that is "we assume the

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-23 Thread Peter Maydell
On 22 November 2017 at 08:41, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Emilio G. Cota
On Wed, Nov 22, 2017 at 09:32:04 -0300, Philippe Mathieu-Daudé wrote: > On 11/22/2017 05:41 AM, Juan Quintela wrote: > > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > > code. Add the function as stubs. > > > > commit 27266271977c5a30f2f7d493e042be1897827bdd > > Author:

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Philippe Mathieu-Daudé
On 11/22/2017 05:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + >

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Dr. David Alan Gilbert
* Richard Henderson (richard.hender...@linaro.org) wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: > > On 22 November 2017 at 12:01, Richard Henderson > > wrote: > >> On 11/22/2017 09:41 AM, Juan Quintela wrote: > >>> This commit started use tb_unlock() and

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 12:08, Richard Henderson wrote: > On 11/22/2017 01:03 PM, Peter Maydell wrote: >> Wow, I totally do not expect "assert(tcg_enabled())" to mean >> "we rely on the compiler to be able to determine that this >> code is dead" (and in general I'm

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Richard Henderson
On 11/22/2017 01:03 PM, Peter Maydell wrote: > On 22 November 2017 at 12:01, Richard Henderson > wrote: >> On 11/22/2017 09:41 AM, Juan Quintela wrote: >>> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >>> code. Add the function as stubs. >>>

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Juan Quintela
Peter Maydell wrote: > On 22 November 2017 at 08:41, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >> Author:

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 12:01, Richard Henderson wrote: > On 11/22/2017 09:41 AM, Juan Quintela wrote: >> This commit started use tb_unlock() and tlb_set_dirty() on non TCG >> code. Add the function as stubs. >> >> commit 27266271977c5a30f2f7d493e042be1897827bdd >>

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Peter Maydell
On 22 November 2017 at 08:41, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-22 Thread Richard Henderson
On 11/22/2017 09:41 AM, Juan Quintela wrote: > This commit started use tb_unlock() and tlb_set_dirty() on non TCG > code. Add the function as stubs. > > commit 27266271977c5a30f2f7d493e042be1897827bdd > Author: Peter Maydell > Date: Mon Nov 20 18:08:27 2017 + >