Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-10 Thread li guang
在 2013-04-09二的 17:20 +0800,陳韋任 (Wei-Ren Chen)写道: Hi liguang, On Tue, Apr 09, 2013 at 04:21:10PM +0800, li guang wrote: 在 2013-04-09二的 10:11 +0200,Paolo Bonzini写道: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Wei-Ren Chen
Hi liguang, Just to be curious, how much performance improvement this patch can get? Regards, chenwj On Tue, Apr 09, 2013 at 11:45:39AM +0800, liguang wrote: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-arm/translate.c | 17 - target-i386/translate.c |

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Paolo Bonzini
Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can get? I think zero. It is indeed making the code a tiny bit more readable in the 2nd/3rd/5th/6th hunks. But the 1st and 4th hunks, which do -num_insns =

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Wei-Ren Chen
On Tue, Apr 09, 2013 at 10:11:37AM +0200, Paolo Bonzini wrote: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can get? I think zero. It is indeed making the code a tiny bit more readable in the

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread li guang
在 2013-04-09二的 10:11 +0200,Paolo Bonzini写道: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can get? I think zero. It is indeed making the code a tiny bit more readable in the 2nd/3rd/5th/6th hunks. I

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Peter Maydell
On 9 April 2013 09:21, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-04-09二的 10:11 +0200,Paolo Bonzini写道: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can get? I think zero. It is indeed making the

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Wei-Ren Chen
Hi liguang, On Tue, Apr 09, 2013 at 04:21:10PM +0800, li guang wrote: 在 2013-04-09二的 10:11 +0200,Paolo Bonzini写道: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can get? I think zero. It is

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread li guang
在 2013-04-09二的 10:08 +0100,Peter Maydell写道: On 9 April 2013 09:21, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-04-09二的 10:11 +0200,Paolo Bonzini写道: Il 09/04/2013 10:05, 陳韋任 (Wei-Ren Chen) ha scritto: Hi liguang, Just to be curious, how much performance improvement this patch can

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Wei-Ren Chen
Hi liguang, OK, thanks! but, please make no mistake, I'm not saying this patch promote performance of TCG, this just optimize code writing of this function, of course code writing is not deemed to promote its performance. or, we shouldn't do any code change if they benefit little in

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread li guang
在 2013-04-10三的 10:31 +0800,陳韋任 (Wei-Ren Chen)写道: Hi liguang, OK, thanks! but, please make no mistake, I'm not saying this patch promote performance of TCG, this just optimize code writing of this function, of course code writing is not deemed to promote its performance. or, we

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread Wei-Ren Chen
you're right, seems the word 'optimize' is not good here. but what should I use? you know, even compiler like gcc will use -O for code optimization. translate: code cleanup in gen_intermediate_code_internal would be better, I think. :) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer

Re: [Qemu-devel] [PATCH] translate: optimize gen_intermediate_code_internal

2013-04-09 Thread li guang
在 2013-04-10三的 10:58 +0800,陳韋任 (Wei-Ren Chen)写道: you're right, seems the word 'optimize' is not good here. but what should I use? you know, even compiler like gcc will use -O for code optimization. translate: code cleanup in gen_intermediate_code_internal would be better, I think. :)