Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Raphael Norwitz
On Thu, Aug 22, 2019 at 10:58:02AM +0200, Philippe Mathieu-Daudé wrote: > Hi Raphael, Stefan, > > On 6/14/19 11:18 AM, Stefan Hajnoczi wrote: > > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > >> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > >> and event without a

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Stefan Hajnoczi
On Wed, Aug 21, 2019 at 09:07:25PM -0700, Raphael Norwitz wrote: > On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote: > > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > > > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > > > and event without a physical

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Philippe Mathieu-Daudé
Hi Raphael, Stefan, On 6/14/19 11:18 AM, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: >> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl >> and event without a physical address. This can cause >> vhost_verify_ring_part_mapping to return

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-22 Thread Paolo Bonzini
On 22/08/19 06:07, Raphael Norwitz wrote: > On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote: >> On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: >>> Of the 3 virtqueues, seabios only sets cmd, leaving ctrl >>> and event without a physical address. This can cause >>>

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-08-21 Thread Raphael Norwitz
On Fri, Jun 14, 2019 at 10:18:41AM +0100, Stefan Hajnoczi wrote: > On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > > and event without a physical address. This can cause > > vhost_verify_ring_part_mapping to return

Re: [Qemu-devel] [PATCH] vhost-user-scsi: prevent using uninitialized vqs

2019-06-14 Thread Stefan Hajnoczi
On Tue, Jun 11, 2019 at 05:35:17PM -0700, Raphael Norwitz wrote: > Of the 3 virtqueues, seabios only sets cmd, leaving ctrl > and event without a physical address. This can cause > vhost_verify_ring_part_mapping to return ENOMEM, causing > the following logs: > > qemu-system-x86_64: Unable to map