Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-11-14 Thread Eduardo Habkost
On Thu, Oct 18, 2018 at 12:25:12PM +0200, Andrea Bolognani wrote: > On Wed, 2018-10-17 at 12:01 -0300, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > > > The proposal doesn't directly address the interaction between virtio > > > protocol version and

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-18 Thread Daniel P . Berrangé
On Thu, Oct 18, 2018 at 12:25:12PM +0200, Andrea Bolognani wrote: > On Wed, 2018-10-17 at 12:01 -0300, Eduardo Habkost wrote: > > On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > > > The proposal doesn't directly address the interaction between virtio > > > protocol version and

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-18 Thread Andrea Bolognani
On Wed, 2018-10-17 at 12:01 -0300, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > > The proposal doesn't directly address the interaction between virtio > > protocol version and slot type. [...] > > It does. See the interface names added to each

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 11:06:31AM -0400, Michael S. Tsirkin wrote: > On Wed, Oct 17, 2018 at 12:01:37PM -0300, Eduardo Habkost wrote: [...] > > I'm considering doing this in v2: > > > > * Remove the -0.9 device type, because nobody seems to need it > > * Add two device types: > > *

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2018 at 12:10:04PM -0300, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 10:22:37AM +0100, Stefan Hajnoczi wrote: > > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > > This patch adds separate device types for each of those virtio > > > device flavors: > > >

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 10:22:37AM +0100, Stefan Hajnoczi wrote: > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > This patch adds separate device types for each of those virtio > > device flavors: > > > > - virtio-*-pci: the existing multi-purpose device types > > -

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Michael S. Tsirkin
On Wed, Oct 17, 2018 at 12:01:37PM -0300, Eduardo Habkost wrote: > On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > > On Tue, 2018-10-16 at 15:12 -0400, Laine Stump wrote: > > > On 10/16/2018 01:02 PM, Daniel P. Berrangé wrote: > > > > On Mon, Oct 15, 2018 at 03:14:04PM -0300,

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Eduardo Habkost
On Wed, Oct 17, 2018 at 12:43:02PM +0200, Andrea Bolognani wrote: > On Tue, 2018-10-16 at 15:12 -0400, Laine Stump wrote: > > On 10/16/2018 01:02 PM, Daniel P. Berrangé wrote: > > > On Mon, Oct 15, 2018 at 03:14:04PM -0300, Eduardo Habkost wrote: > > > How about using only the major digit in the

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Andrea Bolognani
On Tue, 2018-10-16 at 15:12 -0400, Laine Stump wrote: > On 10/16/2018 01:02 PM, Daniel P. Berrangé wrote: > > On Mon, Oct 15, 2018 at 03:14:04PM -0300, Eduardo Habkost wrote: > > How about using only the major digit in the device names eg > > > > 'virtio-blk-0.x' > > 'virtio-blk-1.x' > > > >

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-17 Thread Stefan Hajnoczi
On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > This patch adds separate device types for each of those virtio > device flavors: > > - virtio-*-pci: the existing multi-purpose device types > - Configurable using `disable-legacy` and `disable-modern` > properties > -

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Laine Stump
On 10/16/2018 01:02 PM, Daniel P. Berrangé wrote: > On Mon, Oct 15, 2018 at 03:14:04PM -0300, Eduardo Habkost wrote: >> On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote: >>> On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: The current virtio-*-pci device

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Gerd Hoffmann
Hi, > > See above. We can't drop disable-modern. > > Good point. But this doesn't require it to be a supported device > option for users/management. Maybe we should rename it to > "x-disable-modern" (but that's a separate discussion). I think it would be more useful to allow properties

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Daniel P . Berrangé
On Mon, Oct 15, 2018 at 03:14:04PM -0300, Eduardo Habkost wrote: > On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote: > > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > > The current virtio-*-pci device types actually represent 3 > > > different types of

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Cornelia Huck
On Tue, 16 Oct 2018 10:32:20 -0300 Eduardo Habkost wrote: > On Tue, Oct 16, 2018 at 10:39:30AM +0200, Cornelia Huck wrote: > > So, what I'd propose is: > > - virtio-*-pci-standard: compliant with the virtio standard 1.0 or > > later; no legacy fallback > > - virtio-*-pci-transitional:

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Eduardo Habkost
On Tue, Oct 16, 2018 at 08:48:16AM +0200, Gerd Hoffmann wrote: > Hi, > > > I don't know. The `disable-modern` option already exists but I > > don't know who would want to use it. > > Compat property for old (2.6 & older) machine types. > > > > Right - maybe a flag to disable modern interface

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Eduardo Habkost
On Tue, Oct 16, 2018 at 10:39:30AM +0200, Cornelia Huck wrote: > On Mon, 15 Oct 2018 15:14:04 -0300 > Eduardo Habkost wrote: > > > On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote: > > > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > > > The current

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Cornelia Huck
On Mon, 15 Oct 2018 15:14:04 -0300 Eduardo Habkost wrote: > On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote: > > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > > The current virtio-*-pci device types actually represent 3 > > > different types of

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-16 Thread Gerd Hoffmann
Hi, > I don't know. The `disable-modern` option already exists but I > don't know who would want to use it. Compat property for old (2.6 & older) machine types. > > Right - maybe a flag to disable modern interface is enough. > > We thus get two types: > > - transitional (legacy) > > -

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Eduardo Habkost
On Mon, Oct 15, 2018 at 11:45:56AM +0200, Cornelia Huck wrote: > On Fri, 12 Oct 2018 23:54:35 -0300 > Eduardo Habkost wrote: > > > The current virtio-*-pci device types actually represent 3 > > different types of devices: > > * virtio 1.0 non-transitional devices > > * virtio 1.0 transitional

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Eduardo Habkost
On Mon, Oct 15, 2018 at 06:27:21AM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 15, 2018 at 10:16:41AM +0200, Gerd Hoffmann wrote: > > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > > The current virtio-*-pci device types actually represent 3 > > > different types of

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Eduardo Habkost
On Sun, Oct 14, 2018 at 05:35:12PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > The current virtio-*-pci device types actually represent 3 > > different types of devices: > > * virtio 1.0 non-transitional devices > > * virtio 1.0

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Michael S. Tsirkin
On Mon, Oct 15, 2018 at 10:16:41AM +0200, Gerd Hoffmann wrote: > On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > > The current virtio-*-pci device types actually represent 3 > > different types of devices: > > * virtio 1.0 non-transitional devices > > * virtio 1.0 transitional

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Cornelia Huck
On Fri, 12 Oct 2018 23:54:35 -0300 Eduardo Habkost wrote: > The current virtio-*-pci device types actually represent 3 > different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology) > > That

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-15 Thread Gerd Hoffmann
On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > The current virtio-*-pci device types actually represent 3 > different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices Ok. > * virtio 0.9 ("legacy device" in virtio 1.0 terminology)

Re: [Qemu-devel] [PATCH] virtio: Provide version-specific variants of virtio PCI devices

2018-10-14 Thread Michael S. Tsirkin
On Fri, Oct 12, 2018 at 11:54:35PM -0300, Eduardo Habkost wrote: > The current virtio-*-pci device types actually represent 3 > different types of devices: > * virtio 1.0 non-transitional devices > * virtio 1.0 transitional devices > * virtio 0.9 ("legacy device" in virtio 1.0 terminology) > >