Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-06-24 Thread Stefano Stabellini
On Fri, 24 Jun 2011, Peter Maydell wrote: On 24 June 2011 15:50, stefano.stabell...@eu.citrix.com wrote:     /* read xenstore entries */     if (blkdev-params == NULL) {         blkdev-params = xenstore_read_be_str(blkdev-xendev, params); +        if (blkdev-params != NULL) +          

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-02-11 Thread Kevin Wolf
Am 11.02.2011 13:38, schrieb Stefano Stabellini: When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/hw/xen_disk.c

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-02-11 Thread Stefano Stabellini
On Fri, 11 Feb 2011, Kevin Wolf wrote: Am 11.02.2011 13:38, schrieb Stefano Stabellini: When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH] xen_disk: cope with missing xenstore params node

2011-02-11 Thread Kevin Wolf
Am 11.02.2011 13:59, schrieb Stefano Stabellini: On Fri, 11 Feb 2011, Kevin Wolf wrote: Am 11.02.2011 13:38, schrieb Stefano Stabellini: When disk is a cdrom and the drive is empty the params node in xenstore might be missing completely: cope with it instead of segfaulting. Signed-off-by: