Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-21 Thread Cornelia Huck
On Thu, 20 Oct 2016 18:53:31 +0200 Paolo Bonzini wrote: > No, it's because virtio-mmio can be created without a device > underneath. virtio_bus_start_ioeventfd in that case is wrong, but > virtio_bus_stop_ioeventfd should be a no-op. The fix is trivial: I tend to forget

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-20 Thread Paolo Bonzini
On 20/10/2016 11:03, Cornelia Huck wrote: > On Wed, 19 Oct 2016 22:44:18 +0200 > Paolo Bonzini wrote: > >> On 19/10/2016 17:38, Cornelia Huck wrote: >>> - failures are in qom-test for aarch64: >>> TEST: tests/qom-test... (pid=23997) >>> /aarch64/qom/integratorcp:

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-20 Thread Cornelia Huck
On Wed, 19 Oct 2016 22:44:18 +0200 Paolo Bonzini wrote: > On 19/10/2016 17:38, Cornelia Huck wrote: > > - failures are in qom-test for aarch64: > > TEST: tests/qom-test... (pid=23997) > > /aarch64/qom/integratorcp: OK > >

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-19 Thread Paolo Bonzini
On 19/10/2016 17:38, Cornelia Huck wrote: > - failures are in qom-test for aarch64: > TEST: tests/qom-test... (pid=23997) > /aarch64/qom/integratorcp: OK > /aarch64/qom/nuri: OK >

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-19 Thread Cornelia Huck
On Wed, 19 Oct 2016 14:17:59 +0200 Cornelia Huck wrote: > On Mon, 10 Oct 2016 13:53:28 +0200 > Paolo Bonzini wrote: > > > This series started as an attempt to always use the dataplane path > > for virtio-blk and virtio-scsi when ioeventfd is

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-19 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:28 +0200 Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-18 Thread Paolo Bonzini
- Original Message - > From: "Cornelia Huck" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, stefa...@redhat.com, borntrae...@de.ibm.com, > f...@redhat.com, m...@redhat.com > Sent: Tuesday, October 18, 2016 7:24:45 PM > Subject: Re:

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-18 Thread Cornelia Huck
On Mon, 10 Oct 2016 13:53:28 +0200 Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-10 Thread Paolo Bonzini
On 10/10/2016 00:01, Michael S. Tsirkin wrote: > On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: >> This series started as an attempt to always use the dataplane path >> for virtio-blk and virtio-scsi when ioeventfd is active. The aim >> was three-fold: >> >> 1) to add more

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-10-09 Thread Michael S. Tsirkin
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-30 Thread Stefan Hajnoczi
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: > Opinions, reviews and bug reports? Looks good in general but I've skipped the tricky parts. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-28 Thread Christian Borntraeger
On 09/27/2016 06:44 PM, Paolo Bonzini wrote: > > > On 27/09/2016 16:45, Christian Borntraeger wrote: >> On 09/21/2016 06:43 PM, Paolo Bonzini wrote: >>> >>> >>> On 21/09/2016 16:01, Christian Borntraeger wrote: On 09/21/2016 03:18 PM, Paolo Bonzini wrote: > This series started as an

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-27 Thread Paolo Bonzini
On 27/09/2016 16:45, Christian Borntraeger wrote: > On 09/21/2016 06:43 PM, Paolo Bonzini wrote: >> >> >> On 21/09/2016 16:01, Christian Borntraeger wrote: >>> On 09/21/2016 03:18 PM, Paolo Bonzini wrote: This series started as an attempt to always use the dataplane path for virtio-blk

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-27 Thread Christian Borntraeger
On 09/21/2016 06:43 PM, Paolo Bonzini wrote: > > > On 21/09/2016 16:01, Christian Borntraeger wrote: >> On 09/21/2016 03:18 PM, Paolo Bonzini wrote: >>> This series started as an attempt to always use the dataplane path >>> for virtio-blk and virtio-scsi when ioeventfd is active. The aim >>>

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-21 Thread Michael S. Tsirkin
On Wed, Sep 21, 2016 at 03:18:47PM +0200, Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-21 Thread Paolo Bonzini
On 21/09/2016 16:01, Christian Borntraeger wrote: > On 09/21/2016 03:18 PM, Paolo Bonzini wrote: >> This series started as an attempt to always use the dataplane path >> for virtio-blk and virtio-scsi when ioeventfd is active. The aim >> was three-fold: >> >> 1) to add more coverage for

Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop

2016-09-21 Thread Christian Borntraeger
On 09/21/2016 03:18 PM, Paolo Bonzini wrote: > This series started as an attempt to always use the dataplane path > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > was three-fold: > > 1) to add more coverage for dataplane > > 2) to remove virtio_add_queue_aio > > 3) to