Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-15 Thread Eric Blake
On 12/14/2017 03:06 AM, Kevin Wolf wrote: > Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result s/transfered/transferred/ >> in a 684 bytes payload. >> Since this command

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-15 Thread Paolo Bonzini
On 14/12/2017 14:25, Philippe Mathieu-Daudé wrote: > Yes, a SDHCI qtest is added in a later series (in C) using MMIO access: > http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg02391.html > > But to be sure the SDHCI is correct I needed a SD slave to behave > correctly ;) Hence this "bus

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Philippe Mathieu-Daudé
Hi Paolo, On 12/14/2017 06:34 AM, Paolo Bonzini wrote: > On 14/12/2017 10:06, Kevin Wolf wrote: [...] >> Doing this kind of thing over QMP doesn't look right to me. qtests >> should access hardware the same way as real guests access the hardware >> (i.e. MMIO and I/O ports). [...] > > Yeah, what

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Philippe Mathieu-Daudé
Hi Kevin, On 12/14/2017 06:06 AM, Kevin Wolf wrote: > Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result >> in a 684 bytes payload. >> Since this command is intented for

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Paolo Bonzini
On 14/12/2017 10:06, Kevin Wolf wrote: > Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: >> Use Base64 to serialize the binary blobs in JSON. >> So far at most 512 bytes will be transfered, which result >> in a 684 bytes payload. >> Since this command is intented for qtesting, this

Re: [Qemu-devel] [PATCH 01/26] sdbus: add a QMP command to access a SDBus

2017-12-14 Thread Kevin Wolf
Am 14.12.2017 um 00:20 hat Philippe Mathieu-Daudé geschrieben: > Use Base64 to serialize the binary blobs in JSON. > So far at most 512 bytes will be transfered, which result > in a 684 bytes payload. > Since this command is intented for qtesting, this is acceptable. > > Signed-off-by: Philippe