On Mon, 15 Jul 2019, at 12:06, Rashmica Gupta wrote:
> Sorry for the late reply! I agree with most of your feedback and will
> send out
> a v2 shortly with those changes. I have a few replies below
>
> [snip]
>
> > > +static const struct AspeedGPIO gpios[0x1f0] = {
> > > +/* Set ABCD */
>
Sorry for the late reply! I agree with most of your feedback and will
send out
a v2 shortly with those changes. I have a few replies below
[snip]
> > +static const struct AspeedGPIO gpios[0x1f0] = {
> > +/* Set ABCD */
> > +[GPIO_ABCD_DATA_VALUE] = {0, read_data_value,
> >
On Tue, 18 Jun 2019, at 18:52, Rashmica Gupta wrote:
> Add in details for GPIO controller for AST 2400 and 2500
>
> Signed-off-by: Rashmica Gupta
> ---
> hw/gpio/Makefile.objs | 1 +
> hw/gpio/aspeed_gpio.c | 869 ++
>
On 18/06/2019 10:51, Rashmica Gupta wrote:
> Add in details for GPIO controller for AST 2400 and 2500
I agree.
C.
>
> Signed-off-by: Rashmica Gupta
> ---
> hw/gpio/Makefile.objs | 1 +
> hw/gpio/aspeed_gpio.c | 869 ++
>
