Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Andreas Färber
Am 05.01.2011 um 11:21 schrieb Aurelien Jarno: On Wed, Jan 05, 2011 at 09:15:43AM +0100, Andreas Färber wrote: Am 05.01.2011 um 00:56 schrieb Aurelien Jarno: HPPA code has still to be ported to TCG. Yes it still uses dyngen. Oh. I was pretty sure I saw TCG host support patches... Yes,

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote: On Wed, Jan 05, 2011 at 11:21:06AM +0100, Aurelien Jarno wrote: But that's not the subject we are talking about HPPA guest support. target-hppa fork still (partially) uses dyngen code, which we don't support in upstream for

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 02:10:36PM +0100, Andreas Färber wrote: Am 05.01.2011 um 11:21 schrieb Aurelien Jarno: I'll commit it in 6 months if nothing has changed with regards to HPPA. Just pointing out that there were 5 months without activity from yourself last year. It happens, Real Life

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 14:35, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote:    Is there any plan to deal with use of float*_is_quiet_nan(), where    float*_is_any_nan() was intended?  These should really either be    fixed (and tested), or

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: On 5 January 2011 23:13, Stuart Brady s...@zubnet.me.uk wrote: I do have a few concerns regarding SoftFloat, though:   FIXMEs should be left in the code (or a document maintained on the   Wiki) to keep track of which

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: On 6 January 2011 14:35, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 05, 2011 at 11:13:06PM +, Stuart Brady wrote:    Is there any plan to deal with use of float*_is_quiet_nan(), where    float*_is_any_nan() was

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:13, Stuart Brady s...@zubnet.me.uk wrote: On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: On 5 January 2011 23:13, Stuart Brady s...@zubnet.me.uk wrote: I do have a few concerns regarding SoftFloat, though:   FIXMEs should be left in the code (or a

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Stuart Brady
On Thu, Jan 06, 2011 at 06:43:28PM +, Peter Maydell wrote: On 6 January 2011 18:13, Stuart Brady s...@zubnet.me.uk wrote: On Thu, Jan 06, 2011 at 08:58:17AM +, Peter Maydell wrote: On 5 January 2011 23:13, Stuart Brady s...@zubnet.me.uk wrote: I do have a few concerns regarding

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Nathan Froyd
On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: Similarly I'm dubious about uses in helper_fsel, helper_fcmpu and helper_fcmpo, efsctsi, efsctui, efsctsiz, efsctuiz, efsctsf, efsctuf and all the helper_efd* functions. I haven't actually checked them all, but for instance efdctsi

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Peter Maydell
On 6 January 2011 18:48, Aurelien Jarno aurel...@aurel32.net wrote: On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: In helper_fnmadd() and helper_fnmsub():         if (likely(!float64_is_quiet_nan(farg1.d)))             farg1.d = float64_chs(farg1.d); is I think OK but

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-06 Thread Aurelien Jarno
On Thu, Jan 06, 2011 at 09:19:13PM +, Peter Maydell wrote: On 6 January 2011 18:48, Aurelien Jarno aurel...@aurel32.net wrote: On Thu, Jan 06, 2011 at 03:34:38PM +, Peter Maydell wrote: In helper_fnmadd() and helper_fnmsub():         if (likely(!float64_is_quiet_nan(farg1.d)))    

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-05 Thread Andreas Färber
Am 05.01.2011 um 00:56 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 11:53:01PM +0100, Andreas Färber wrote: Am 04.01.2011 um 21:07 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 08:54:04PM +0100, Andreas Färber wrote: Am 03.01.2011 um 15:34 schrieb Aurelien Jarno: We don't have any

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-05 Thread Aurelien Jarno
On Wed, Jan 05, 2011 at 09:15:43AM +0100, Andreas Färber wrote: Am 05.01.2011 um 00:56 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 11:53:01PM +0100, Andreas Färber wrote: Am 04.01.2011 um 21:07 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 08:54:04PM +0100, Andreas Färber wrote: Am

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-05 Thread Stuart Brady
On Wed, Jan 05, 2011 at 11:21:06AM +0100, Aurelien Jarno wrote: But that's not the subject we are talking about HPPA guest support. target-hppa fork still (partially) uses dyngen code, which we don't support in upstream for more than *2 years*. I'd agree -- the fork is currently dead.

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-04 Thread Andreas Färber
Am 03.01.2011 um 15:34 schrieb Aurelien Jarno: We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target. Signed-off-by: Aurelien Jarno aurel...@aurel32.net There actually is such a project on SourceForge [1, 2]. Does it really

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-04 Thread Aurelien Jarno
On Tue, Jan 04, 2011 at 08:54:04PM +0100, Andreas Färber wrote: Am 03.01.2011 um 15:34 schrieb Aurelien Jarno: We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target. Signed-off-by: Aurelien Jarno aurel...@aurel32.net There

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-04 Thread Andreas Färber
Am 04.01.2011 um 21:07 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 08:54:04PM +0100, Andreas Färber wrote: Am 03.01.2011 um 15:34 schrieb Aurelien Jarno: We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target.

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-04 Thread Aurelien Jarno
On Tue, Jan 04, 2011 at 11:53:01PM +0100, Andreas Färber wrote: Am 04.01.2011 um 21:07 schrieb Aurelien Jarno: On Tue, Jan 04, 2011 at 08:54:04PM +0100, Andreas Färber wrote: Am 03.01.2011 um 15:34 schrieb Aurelien Jarno: We don't have any HPPA target, so let's remove HPPA specific code.

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-03 Thread Peter Maydell
On 3 January 2011 14:34, Aurelien Jarno aurel...@aurel32.net wrote: We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org

Re: [Qemu-devel] [PATCH 1/6] softfloat: remove HPPA specific code

2011-01-03 Thread Aurelien Jarno
Peter Maydell a écrit : On 3 January 2011 14:34, Aurelien Jarno aurel...@aurel32.net wrote: We don't have any HPPA target, so let's remove HPPA specific code. It can be re-added when someone adds an HPPA target. Signed-off-by: Aurelien Jarno aurel...@aurel32.net Reviewed-by: Peter Maydell