Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Am 14.06.2018 um 13:52 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > >> >> When you mix scalar and non-scalar keys, whether

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Daniel P. Berrangé writes: > On Thu, Jun 14, 2018 at 10:40:58AM +0200, Kevin Wolf wrote: >> Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: >> > Kevin Wolf writes: >> > >> > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> > >> When you mix scalar and non-scalar keys,

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Kevin Wolf writes: > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> >> When you mix scalar and non-scalar keys, whether you get an "already >> >> set as scalar" or an "already set as dict"

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

On Thu, Jun 14, 2018 at 10:40:58AM +0200, Kevin Wolf wrote: > Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > > Kevin Wolf writes: > > > > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > > >> When you mix scalar and non-scalar keys, whether you get an "already > > >>

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Am 13.06.2018 um 17:23 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > >> When you mix scalar and non-scalar keys, whether you get an "already > >> set as scalar" or an "already set as dict" error depends on qdict > >>

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Kevin Wolf writes: > Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: >> When you mix scalar and non-scalar keys, whether you get an "already >> set as scalar" or an "already set as dict" error depends on qdict >> iteration order. Neither message makes much sense. Replace by >>

Re: [Qemu-devel] [PATCH 12/18] block-qdict: Clean up qdict_crumple() a bit

Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > When you mix scalar and non-scalar keys, whether you get an "already > set as scalar" or an "already set as dict" error depends on qdict > iteration order. Neither message makes much sense. Replace by > ""Cannot mix scalar and