Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-17 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/10/2018 10:48 AM, Eric Blake wrote: >>> On 08/08/2018 07:03 AM, Markus Armbruster wrote: This is consistent with qobject_to_json(). See commit e2ec3f97680. >>> >>> Side note: that commit mentions that on output, ASCII DEL (0x7f) is

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-14 Thread Markus Armbruster
Eric Blake writes: > On 08/13/2018 02:00 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/10/2018 10:48 AM, Eric Blake wrote: On 08/08/2018 07:03 AM, Markus Armbruster wrote: > This is consistent with qobject_to_json(). See commit e2ec3f97680. Side note: that

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-13 Thread Eric Blake
On 08/13/2018 02:00 AM, Markus Armbruster wrote: Eric Blake writes: On 08/10/2018 10:48 AM, Eric Blake wrote: On 08/08/2018 07:03 AM, Markus Armbruster wrote: This is consistent with qobject_to_json(). See commit e2ec3f97680. Side note: that commit mentions that on output, ASCII DEL

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2018 10:48 AM, Eric Blake wrote: >> On 08/08/2018 07:03 AM, Markus Armbruster wrote: >>> This is consistent with qobject_to_json(). See commit e2ec3f97680. >> >> Side note: that commit mentions that on output, ASCII DEL (0x7f) is >> always escaped. RFC 7159 does

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-10 Thread Eric Blake
On 08/10/2018 10:48 AM, Eric Blake wrote:    * Note: - * - Input must be encoded in UTF-8. + * - Input must be encoded in modified UTF-8. Worth documenting this in the QMP doc as an explicit extension? In general, our QMP interfaces that take binary input do so via base64 encoding, rather

Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-10 Thread Eric Blake
On 08/08/2018 07:03 AM, Markus Armbruster wrote: This is consistent with qobject_to_json(). See commit e2ec3f97680. Side note: that commit mentions that on output, ASCII DEL (0x7f) is always escaped. RFC 7159 does not require it to be escaped on input, but I wonder if any of your earlier