Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Philippe Mathieu-Daudé
On 07/11/2018 12:30 PM, Paolo Bonzini wrote: > On 11/07/2018 16:59, Stefan Hajnoczi wrote: >>> +machine->obj.get_device = raspi2_get_device; >>> +machine->obj.destructor = raspi2_destroy; >>> +qos_create_sdhci_mm(>sdhci, 0x3f30, &(QSDHCIProperties) { >>> +.version = 3, >>>

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Paolo Bonzini
On 11/07/2018 16:59, Stefan Hajnoczi wrote: >> +machine->obj.get_device = raspi2_get_device; >> +machine->obj.destructor = raspi2_destroy; >> +qos_create_sdhci_mm(>sdhci, 0x3f30, &(QSDHCIProperties) { >> +.version = 3, >> +.baseclock = 52, >> +.capab.sdma =

Re: [Qemu-devel] [PATCH 4/7] tests/qgraph: arm/raspi2 machine node

2018-07-11 Thread Stefan Hajnoczi
On Mon, Jul 09, 2018 at 11:11:33AM +0200, Emanuele Giuseppe Esposito wrote: > Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so > its constructor must take care of setting it properly when called. > > Signed-off-by: Emanuele Giuseppe Esposito > --- >