Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-10 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/10/2016 02:51 PM, Nikunj A Dadhania wrote: >> I can fix the BE case using following but not sure if that will be >> correct ! >> >> tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_Q); >> gen_helper_bswap32x2(xth, xth); >>

Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-10 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/10/2016 02:51 PM, Nikunj A Dadhania wrote: >> I can fix the BE case using following but not sure if that will be >> correct ! >> >> tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_Q); >> gen_helper_bswap32x2(xth, xth); >>

Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-10 Thread Richard Henderson
On 08/10/2016 02:51 PM, Nikunj A Dadhania wrote: I can fix the BE case using following but not sure if that will be correct ! tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_Q); gen_helper_bswap32x2(xth, xth); tcg_gen_addi_tl(EA, EA, 8); tcg_gen_qemu_ld_i64(xtl,

Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-10 Thread Nikunj A Dadhania
Richard Henderson writes: > On 08/08/2016 10:57 AM, Richard Henderson wrote: >> On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote: >>> +#define LXV(name, access, swap, type, elems) \ >>> +uint64_t helper_##name(CPUPPCState *env, \ >>> +

Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-08 Thread Richard Henderson
On 08/08/2016 10:57 AM, Richard Henderson wrote: On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote: +#define LXV(name, access, swap, type, elems) \ +uint64_t helper_##name(CPUPPCState *env, \ + target_ulong addr)

Re: [Qemu-devel] [PATCH 5/6] target-ppc: add lxvb16x and lxvh8x

2016-08-07 Thread Richard Henderson
On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote: +#define LXV(name, access, swap, type, elems) \ +uint64_t helper_##name(CPUPPCState *env, \ + target_ulong addr)\ +{