Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-17 Thread Eduardo Habkost
On Thu, May 17, 2018 at 08:57:04PM +0300, Michael S. Tsirkin wrote: > On Thu, May 17, 2018 at 02:34:28PM -0300, Eduardo Habkost wrote: > > On Wed, May 16, 2018 at 05:26:40PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > > > > On Sat, May 1

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-17 Thread Michael S. Tsirkin
On Thu, May 17, 2018 at 02:34:28PM -0300, Eduardo Habkost wrote: > On Wed, May 16, 2018 at 05:26:40PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > > > On Sat, May 12, 2018 at 01:12:59AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Apr 1

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-17 Thread Eduardo Habkost
On Wed, May 16, 2018 at 05:26:40PM +0300, Michael S. Tsirkin wrote: > On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > > On Sat, May 12, 2018 at 01:12:59AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Apr 19, 2018 at 06:53:20PM -0300, Eduardo Habkost wrote: > > > > On Thu, Apr 1

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Eduardo Habkost
On Wed, May 16, 2018 at 07:21:04PM +0300, Michael S. Tsirkin wrote: > On Wed, May 16, 2018 at 12:33:50PM -0300, Eduardo Habkost wrote: > > On Wed, May 16, 2018 at 06:13:17PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 16, 2018 at 05:04:41PM +0200, Paolo Bonzini wrote: > > > > On 16/05/2018 1

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 12:33:50PM -0300, Eduardo Habkost wrote: > On Wed, May 16, 2018 at 06:13:17PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 16, 2018 at 05:04:41PM +0200, Paolo Bonzini wrote: > > > On 16/05/2018 16:22, Michael S. Tsirkin wrote: > > > >> kvm-hint-dedicated=on only sets the

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Eduardo Habkost
On Wed, May 16, 2018 at 06:13:17PM +0300, Michael S. Tsirkin wrote: > On Wed, May 16, 2018 at 05:04:41PM +0200, Paolo Bonzini wrote: > > On 16/05/2018 16:22, Michael S. Tsirkin wrote: > > >> kvm-hint-dedicated=on only sets the CPUID bit, which Linux for example > > >> uses that to disable pv spinlo

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 05:04:41PM +0200, Paolo Bonzini wrote: > On 16/05/2018 16:22, Michael S. Tsirkin wrote: > >> kvm-hint-dedicated=on only sets the CPUID bit, which Linux for example > >> uses that to disable pv spinlocks. "-realtime dedicated-cpus=on" only > >> disables the vmexits. You can

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Paolo Bonzini
On 16/05/2018 16:22, Michael S. Tsirkin wrote: >> kvm-hint-dedicated=on only sets the CPUID bit, which Linux for example >> uses that to disable pv spinlocks. "-realtime dedicated-cpus=on" only >> disables the vmexits. You can use the two independently. > > But when would you want to use the two

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 09:34:52AM -0300, Eduardo Habkost wrote: > On Sat, May 12, 2018 at 01:12:59AM +0300, Michael S. Tsirkin wrote: > > On Thu, Apr 19, 2018 at 06:53:20PM -0300, Eduardo Habkost wrote: > > > On Thu, Apr 19, 2018 at 11:32:16PM +0200, Paolo Bonzini wrote: > > > > On 19/04/2018 21:5

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2018 at 02:44:24PM +0200, Paolo Bonzini wrote: > On 12/05/2018 00:12, Michael S. Tsirkin wrote: > >> Maybe it's a better idea than overloading an option that is only > >> expected to control a CPUID bit. > > Well -realtime would be a bit confusing in that it enables mlock by > > def

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Paolo Bonzini
On 12/05/2018 00:12, Michael S. Tsirkin wrote: >> Maybe it's a better idea than overloading an option that is only >> expected to control a CPUID bit. > Well -realtime would be a bit confusing in that it enables mlock by > default. Currently, the only suboption of "-realtime" is mlock, which means

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-16 Thread Eduardo Habkost
On Sat, May 12, 2018 at 01:12:59AM +0300, Michael S. Tsirkin wrote: > On Thu, Apr 19, 2018 at 06:53:20PM -0300, Eduardo Habkost wrote: > > On Thu, Apr 19, 2018 at 11:32:16PM +0200, Paolo Bonzini wrote: > > > On 19/04/2018 21:56, Eduardo Habkost wrote: > > > > On Thu, Apr 19, 2018 at 05:48:57PM +020

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-11 Thread Wanpeng Li
2018-05-12 5:57 GMT+08:00 Michael S. Tsirkin : > On Wed, Apr 18, 2018 at 09:09:19AM +0800, Wanpeng Li wrote: >> 2018-04-18 2:08 GMT+08:00 Michael S. Tsirkin : >> > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: >> >> From: Wanpeng Li >> >> >> >> This patch adds support for KVM_CAP_X86

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-11 Thread Michael S. Tsirkin
On Thu, Apr 19, 2018 at 06:53:20PM -0300, Eduardo Habkost wrote: > On Thu, Apr 19, 2018 at 11:32:16PM +0200, Paolo Bonzini wrote: > > On 19/04/2018 21:56, Eduardo Habkost wrote: > > > On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: > > >> On 17/04/2018 22:59, Eduardo Habkost wrote: >

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-05-11 Thread Michael S. Tsirkin
On Wed, Apr 18, 2018 at 09:09:19AM +0800, Wanpeng Li wrote: > 2018-04-18 2:08 GMT+08:00 Michael S. Tsirkin : > > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: > >> From: Wanpeng Li > >> > >> This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace > >> with > >> per

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Eduardo Habkost
On Thu, Apr 19, 2018 at 11:32:16PM +0200, Paolo Bonzini wrote: > On 19/04/2018 21:56, Eduardo Habkost wrote: > > On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: > >> On 17/04/2018 22:59, Eduardo Habkost wrote: > +if (disable_exits) { > +disable_exits &=

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Paolo Bonzini
On 19/04/2018 21:56, Eduardo Habkost wrote: > On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: >> On 17/04/2018 22:59, Eduardo Habkost wrote: +if (disable_exits) { +disable_exits &= (KVM_X86_DISABLE_EXITS_MWAIT | + KVM_X8

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Eduardo Habkost
On Thu, Apr 19, 2018 at 05:48:57PM +0200, Paolo Bonzini wrote: > On 17/04/2018 22:59, Eduardo Habkost wrote: > >> +if (disable_exits) { > >> +disable_exits &= (KVM_X86_DISABLE_EXITS_MWAIT | > >> + KVM_X86_DISABLE_EXITS_HLT | > >> +

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-19 Thread Paolo Bonzini
On 17/04/2018 22:59, Eduardo Habkost wrote: >> +if (disable_exits) { >> +disable_exits &= (KVM_X86_DISABLE_EXITS_MWAIT | >> + KVM_X86_DISABLE_EXITS_HLT | >> + KVM_X86_DISABLE_EXITS_PAUSE); >> +if (env->user_fe

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Wanpeng Li
2018-04-18 4:59 GMT+08:00 Eduardo Habkost : > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: [.../...] >> >> +if (env->features[FEAT_KVM_HINTS] & KVM_HINTS_DEDICATED) { >> +int disable_exits = kvm_check_extension(cs->kvm_state, >> KVM_CAP_X86_DISABLE_EXITS); >> + >> +

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Wanpeng Li
2018-04-18 2:08 GMT+08:00 Michael S. Tsirkin : > On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace >> with >> per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Eduardo Habkost
On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace > with > per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE > in order that to improve latency in some workloa

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread Michael S. Tsirkin
On Tue, Apr 17, 2018 at 01:24:15AM -0700, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds support for KVM_CAP_X86_DISABLE_EXITS. Provides userspace > with > per-VM capability(KVM_CAP_X86_DISABLE_EXITS) to not intercept MWAIT/HLT/PAUSE > in order that to improve latency in some workloa

Re: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS

2018-04-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1523953455-28053-1-git-send-email-wanpen...@tencent.com Subject: [Qemu-devel] [PATCH RESEND v2] i386/kvm: add support for KVM_CAP_X86_DISABLE_EXITS === TEST SCRIPT BEGIN ===