Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/07/17 22:02, Phil Dennis-Jordan wrote: > On 7 February 2017 at 20:54, Laszlo Ersek wrote: >> I filed . > > That looks nice and thorough. > >>> Your EDK2 patch >> >> For the record: >> [1]

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 7 February 2017 at 20:54, Laszlo Ersek wrote: > On 02/06/17 17:30, Phil Dennis-Jordan wrote: >> Thanks for the in-depth reply - apologies for abandoning the thread >> for a few days. Looks like a bunch of things have already been hashed >> out, but I have a few more

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/06/17 17:30, Phil Dennis-Jordan wrote: > Thanks for the in-depth reply - apologies for abandoning the thread > for a few days. Looks like a bunch of things have already been hashed > out, but I have a few more comments: Vice versa... Sorry about responding a bit late. Yesterday I severely

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/06/17 17:44, Phil Dennis-Jordan wrote: > On 31 January 2017 at 20:08, Laszlo Ersek wrote: >> On 01/31/17 19:17, Michael S. Tsirkin wrote: >>> On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: The ACPI 6.1 spec says, - DSDT: [...] If the X_DSDT

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 31 January 2017 at 20:08, Laszlo Ersek wrote: > On 01/31/17 19:17, Michael S. Tsirkin wrote: >> On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: >>> The ACPI 6.1 spec says, >>> >>> - DSDT: [...] If the X_DSDT field contains a non-zero value then this >>> field

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

Thanks for the in-depth reply - apologies for abandoning the thread for a few days. Looks like a bunch of things have already been hashed out, but I have a few more comments: On 31 January 2017 at 17:28, Laszlo Ersek wrote: > On 01/31/17 15:58, Michael S. Tsirkin wrote: >> On

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, Jan 31, 2017 at 04:04:58PM +, Phil Dennis-Jordan wrote: > > On Tue, 31 Jan 2017 at 16:41, Igor Mammedov wrote: > > On Tue, 31 Jan 2017 16:58:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 31, 2017 at 03:31:46PM +0100,

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/01/17 17:17, Michael S. Tsirkin wrote: > On Wed, Feb 01, 2017 at 05:03:38PM +0100, Laszlo Ersek wrote: >> On 02/01/17 16:16, Igor Mammedov wrote: >>> On Wed, 1 Feb 2017 14:03:52 +0100 >>> Laszlo Ersek wrote: >>> On 02/01/17 13:52, Laszlo Ersek wrote: > On

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Wed, Feb 01, 2017 at 05:03:38PM +0100, Laszlo Ersek wrote: > On 02/01/17 16:16, Igor Mammedov wrote: > > On Wed, 1 Feb 2017 14:03:52 +0100 > > Laszlo Ersek wrote: > > > >> On 02/01/17 13:52, Laszlo Ersek wrote: > >>> On 02/01/17 12:37, Igor Mammedov wrote: > On Tue,

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/01/17 16:16, Igor Mammedov wrote: > On Wed, 1 Feb 2017 14:03:52 +0100 > Laszlo Ersek wrote: > >> On 02/01/17 13:52, Laszlo Ersek wrote: >>> On 02/01/17 12:37, Igor Mammedov wrote: On Tue, 31 Jan 2017 20:17:02 +0200 "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Wed, 1 Feb 2017 14:03:52 +0100 Laszlo Ersek wrote: > On 02/01/17 13:52, Laszlo Ersek wrote: > > On 02/01/17 12:37, Igor Mammedov wrote: > >> On Tue, 31 Jan 2017 20:17:02 +0200 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Tue, Jan 31, 2017 at

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Wed, Feb 01, 2017 at 12:37:39PM +0100, Igor Mammedov wrote: > On Tue, 31 Jan 2017 20:17:02 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: > > > The ACPI 6.1 spec says, > > > > > > - DSDT: [...] If the X_DSDT field

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/01/17 13:52, Laszlo Ersek wrote: > On 02/01/17 12:37, Igor Mammedov wrote: >> On Tue, 31 Jan 2017 20:17:02 +0200 >> "Michael S. Tsirkin" wrote: >> >>> On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: The ACPI 6.1 spec says, - DSDT: [...] If the

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 02/01/17 12:37, Igor Mammedov wrote: > On Tue, 31 Jan 2017 20:17:02 +0200 > "Michael S. Tsirkin" wrote: > >> On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: >>> The ACPI 6.1 spec says, >>> >>> - DSDT: [...] If the X_DSDT field contains a non-zero value then this

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, 31 Jan 2017 20:17:02 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: > > The ACPI 6.1 spec says, > > > > - DSDT: [...] If the X_DSDT field contains a non-zero value then this > > field must be zero. > > - X_DSDT: [...]

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 01/31/17 19:17, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: >> The ACPI 6.1 spec says, >> >> - DSDT: [...] If the X_DSDT field contains a non-zero value then this >> field must be zero. >> - X_DSDT: [...] If the DSDT field contains a non-zero

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, Jan 31, 2017 at 05:28:57PM +0100, Laszlo Ersek wrote: > The ACPI 6.1 spec says, > > - DSDT: [...] If the X_DSDT field contains a non-zero value then this > field must be zero. > - X_DSDT: [...] If the DSDT field contains a non-zero value then this > field must be zero. But that's

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 01/31/17 15:58, Michael S. Tsirkin wrote: > On Tue, Jan 31, 2017 at 03:31:46PM +0100, Phil Dennis-Jordan wrote: >> On 18 January 2017 at 18:19, Igor Mammedov wrote: >>> On Wed, 18 Jan 2017 18:30:59 +0200 >>> "Michael S. Tsirkin" wrote: >>> On Wed,

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, 31 Jan 2017 16:04:58 + Phil Dennis-Jordan wrote: > On Tue, 31 Jan 2017 at 16:41, Igor Mammedov wrote: > > > On Tue, 31 Jan 2017 16:58:22 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Jan 31, 2017 at 03:31:46PM

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, 31 Jan 2017 at 16:41, Igor Mammedov wrote: > On Tue, 31 Jan 2017 16:58:22 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Jan 31, 2017 at 03:31:46PM +0100, Phil Dennis-Jordan wrote: > > > On 18 January 2017 at 18:19, Igor Mammedov

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, 31 Jan 2017 16:58:22 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 31, 2017 at 03:31:46PM +0100, Phil Dennis-Jordan wrote: > > On 18 January 2017 at 18:19, Igor Mammedov wrote: > > > On Wed, 18 Jan 2017 18:30:59 +0200 > > > "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Tue, Jan 31, 2017 at 03:31:46PM +0100, Phil Dennis-Jordan wrote: > On 18 January 2017 at 18:19, Igor Mammedov wrote: > > On Wed, 18 Jan 2017 18:30:59 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Wed, Jan 18, 2017 at 12:45:54PM +0100, Phil

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 18 January 2017 at 18:19, Igor Mammedov wrote: > On Wed, 18 Jan 2017 18:30:59 +0200 > "Michael S. Tsirkin" wrote: > >> On Wed, Jan 18, 2017 at 12:45:54PM +0100, Phil Dennis-Jordan wrote: > [...] > >> > I suspect more might be involved in enabling ACPI

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 27/01/2017 14:57, Igor Mammedov wrote: >> +fadt->reset_register.space_id = 1; >> +fadt->reset_register.bit_width = 8; >> +fadt->reset_register.address= ICH9_RST_CNT_IOPORT; > cpu_to_le64 > > + specify explicitly all fields of GAS structure: reset_register > > + is

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Thu, 26 Jan 2017 14:43:04 +0100 Phil Dennis-Jordan wrote: > On 23 January 2017 at 12:12, Igor Mammedov wrote: > >> For reference, my approach to filling out the Xdsdt/Xfacs fields in > >> build_fadt() is essentially the same as for the 32-bit variants

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 23 January 2017 at 12:12, Igor Mammedov wrote: >> For reference, my approach to filling out the Xdsdt/Xfacs fields in >> build_fadt() is essentially the same as for the 32-bit variants from >> rev1: >> >> unsigned xfacs_offset = (char *)>Xfacs - table_data->data; >>

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Thu, 19 Jan 2017 19:09:47 +0100 Phil Dennis-Jordan wrote: > On 18 January 2017 at 17:30, Michael S. Tsirkin wrote: > > I think what's important is the Fadt format revision. That one was 1 for > > 1.0b and 3 for 2.0. > > > > See page 112, Table 5-5 Fixed

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On 18 January 2017 at 17:30, Michael S. Tsirkin wrote: > I think what's important is the Fadt format revision. That one was 1 for 1.0b > and 3 for 2.0. > > See page 112, Table 5-5 Fixed ACPI Description Table Format in acpi spec > 1.0b. > > Now look at page 110 in spec 2.0, this

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Wed, 18 Jan 2017 18:30:59 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 18, 2017 at 12:45:54PM +0100, Phil Dennis-Jordan wrote: [...] > > I suspect more might be involved in enabling ACPI 2.0, and it should > > probably be an option so as to avoid regressions. I don't

Re: [Qemu-devel] [PATCH RFC] acpi: add reset register to fadt

On Wed, Jan 18, 2017 at 12:45:54PM +0100, Phil Dennis-Jordan wrote: > About 2 years ago, Reza Jelveh submitted essentially this same patch: > https://lists.gnu.org/archive/html/qemu-devel/2015-03/msg05832.html > > It adds the reset register defined in ACPI 2.0 to the x86 FADT, which fixes >