Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-12-10 Thread Gerd Hoffmann
On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. Let's bump required version > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > (this patch combines

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Gerd Hoffmann
> > seems the spice-protocol dep is there due to qemu itself needing it: > > > > commit 358689fe299c306f1d81bea57a5067d0abb56699 > > Author: Michal Privoznik > > Date: Fri Mar 1 08:43:18 2013 +0100 > > > > configure: Require at least spice-protocol-0.12.3 > > > > As of 5a49d3e9

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> > On Thu, Nov 29, 2018 at 03:32:28AM -0500, Frediano Ziglio wrote: > > > On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > > > > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > > > Looking at chardev/spice.c code, I realize compilation was broken for > >

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Gerd Hoffmann
On Thu, Nov 29, 2018 at 03:32:28AM -0500, Frediano Ziglio wrote: > > On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > > Looking at chardev/spice.c code, I realize compilation was broken for > > > > a while

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > > Looking at chardev/spice.c code, I realize compilation was broken for > > > a while with spice-server < 0.12.3. Let's bump required version > > > to 0.12.5,

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Marc-André Lureau
On Thu, Nov 29, 2018 at 12:09 PM Gerd Hoffmann wrote: > > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > Looking at chardev/spice.c code, I realize compilation was broken for > > a while with spice-server < 0.12.3. Let's bump required version > > to 0.12.5, released May 19

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Frediano Ziglio
> > On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > > Looking at chardev/spice.c code, I realize compilation was broken for > > a while with spice-server < 0.12.3. Let's bump required version > > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > Oh, you did

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-29 Thread Gerd Hoffmann
On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. Let's bump required version > to 0.12.5, released May 19 2014, instead of adding more #ifdef. Oh, you did the 0.12.5

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-28 Thread Frediano Ziglio
> > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. Let's bump required version > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > (this patch combines changes from an early version and some of > Frediano "[PATCH 2/2]

Re: [Qemu-devel] [PATCH for-4.0 v3] configure: bump spice-server required version to 0.12.5

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 07:59:32PM +0400, Marc-André Lureau wrote: > Looking at chardev/spice.c code, I realize compilation was broken for > a while with spice-server < 0.12.3. Let's bump required version > to 0.12.5, released May 19 2014, instead of adding more #ifdef. > > (this patch combines