I'd like to recommend a few commas.
Denis Plotnikov writes:
> The patch adds some preparation parts for incompatible compression type
> feature to QCOW2 header that indicates that *all* compressed clusters
> must be (de)compressed using a certain compression type.
>
> It is implied that the
On 03.07.2019 18:46, Kevin Wolf wrote:
> Am 03.07.2019 um 17:01 hat Denis Plotnikov geschrieben:
>> On 03.07.2019 17:14, Eric Blake wrote:
>>> On 7/3/19 6:00 AM, Denis Plotnikov wrote:
diff --git a/block/qcow2.c b/block/qcow2.c
index 3ace3b2209..921eb67b80 100644
---
Am 03.07.2019 um 17:01 hat Denis Plotnikov geschrieben:
> On 03.07.2019 17:14, Eric Blake wrote:
> > On 7/3/19 6:00 AM, Denis Plotnikov wrote:
> >> diff --git a/block/qcow2.c b/block/qcow2.c
> >> index 3ace3b2209..921eb67b80 100644
> >> --- a/block/qcow2.c
> >> +++ b/block/qcow2.c
> >> @@ -1202,6
On 03.07.2019 18:13, Eric Blake wrote:
> On 7/3/19 10:01 AM, Denis Plotnikov wrote:
>
+ * with QCOW2_COMPRESSION_TYPE_ZLIB the corresponding incompatible
+ * feature flag must be absent, with other compression types the
+ * incompatible feature flag must be set
>>> Is
On 7/3/19 10:01 AM, Denis Plotnikov wrote:
>>> + * with QCOW2_COMPRESSION_TYPE_ZLIB the corresponding incompatible
>>> + * feature flag must be absent, with other compression types the
>>> + * incompatible feature flag must be set
>> Is there a strong reason for forbid the
On 03.07.2019 17:14, Eric Blake wrote:
> On 7/3/19 6:00 AM, Denis Plotnikov wrote:
>> The patch adds some preparation parts for incompatible compression type
>> feature to QCOW2 header that indicates that*all* compressed clusters
>> must be (de)compressed using a certain compression type.
>>
>>
On 7/3/19 6:00 AM, Denis Plotnikov wrote:
> The patch adds some preparation parts for incompatible compression type
> feature to QCOW2 header that indicates that *all* compressed clusters
> must be (de)compressed using a certain compression type.
>
> It is implied that the compression type is set
