Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-26 Thread Wang, Wei W
On Wednesday, July 26, 2017 7:55 PM, Michal Hocko wrote: > On Wed 26-07-17 19:44:23, Wei Wang wrote: > [...] > > I thought about it more. Probably we can use the callback function > > with a little change like this: > > > > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2, > > unsigned

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-26 Thread Michal Hocko
On Wed 26-07-17 19:44:23, Wei Wang wrote: [...] > I thought about it more. Probably we can use the callback function with a > little change like this: > > void walk_free_mem(void *opaque1, void (*visit)(void *opaque2, unsigned long > pfn, >unsigned long nr_pages)) > { > ... > f

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-26 Thread Wei Wang
On 07/26/2017 06:24 PM, Michal Hocko wrote: On Wed 26-07-17 10:22:23, Wei Wang wrote: On 07/25/2017 10:53 PM, Michal Hocko wrote: On Tue 25-07-17 14:47:16, Wang, Wei W wrote: On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: On Tue 25-07-17 19:56:24, Wei Wang wrote: On 07/25/2017 07:25 PM,

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-26 Thread Michal Hocko
On Wed 26-07-17 10:22:23, Wei Wang wrote: > On 07/25/2017 10:53 PM, Michal Hocko wrote: > >On Tue 25-07-17 14:47:16, Wang, Wei W wrote: > >>On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > >>>On Tue 25-07-17 19:56:24, Wei Wang wrote: > On 07/25/2017 07:25 PM, Michal Hocko wrote: > >On

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/25/2017 10:53 PM, Michal Hocko wrote: On Tue 25-07-17 14:47:16, Wang, Wei W wrote: On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: On Tue 25-07-17 19:56:24, Wei Wang wrote: On 07/25/2017 07:25 PM, Michal Hocko wrote: On Tue 25-07-17 17:32:00, Wei Wang wrote: On 07/24/2017 05:00 PM,

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 14:47:16, Wang, Wei W wrote: > On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > > On Tue 25-07-17 19:56:24, Wei Wang wrote: > > > On 07/25/2017 07:25 PM, Michal Hocko wrote: > > > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > > > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: > >

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wang, Wei W
On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: > On Tue 25-07-17 19:56:24, Wei Wang wrote: > > On 07/25/2017 07:25 PM, Michal Hocko wrote: > > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: > > >>>On Wed 19-07-17 20:01:18, Wei Wang wrote: > > O

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 19:56:24, Wei Wang wrote: > On 07/25/2017 07:25 PM, Michal Hocko wrote: > >On Tue 25-07-17 17:32:00, Wei Wang wrote: > >>On 07/24/2017 05:00 PM, Michal Hocko wrote: > >>>On Wed 19-07-17 20:01:18, Wei Wang wrote: > On 07/19/2017 04:13 PM, Michal Hocko wrote: > >>>[... > >All

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/25/2017 07:25 PM, Michal Hocko wrote: On Tue 25-07-17 17:32:00, Wei Wang wrote: On 07/24/2017 05:00 PM, Michal Hocko wrote: On Wed 19-07-17 20:01:18, Wei Wang wrote: On 07/19/2017 04:13 PM, Michal Hocko wrote: [... All you should need is the check for the page reference count, no? I a

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Michal Hocko
On Tue 25-07-17 17:32:00, Wei Wang wrote: > On 07/24/2017 05:00 PM, Michal Hocko wrote: > >On Wed 19-07-17 20:01:18, Wei Wang wrote: > >>On 07/19/2017 04:13 PM, Michal Hocko wrote: > >[... > >>>All you should need is the check for the page reference count, no? I > >>>assume you do some sort of pfn

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/24/2017 05:00 PM, Michal Hocko wrote: On Wed 19-07-17 20:01:18, Wei Wang wrote: On 07/19/2017 04:13 PM, Michal Hocko wrote: [... All you should need is the check for the page reference count, no? I assume you do some sort of pfn walk and so you should be able to get an access to the str

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-24 Thread Michal Hocko
On Wed 19-07-17 20:01:18, Wei Wang wrote: > On 07/19/2017 04:13 PM, Michal Hocko wrote: [... > >All you should need is the check for the page reference count, no? I > >assume you do some sort of pfn walk and so you should be able to get an > >access to the struct page. > > Not necessarily - the g

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-19 Thread Wei Wang
On 07/19/2017 04:13 PM, Michal Hocko wrote: On Tue 18-07-17 10:12:14, Wei Wang wrote: [...] Probably I should have included the introduction of the usages in the log. Hope it is not too later to explain here: Yes this should have been described in the cover. OK, I will do it in the next vers

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-19 Thread Michal Hocko
On Tue 18-07-17 10:12:14, Wei Wang wrote: [...] > Probably I should have included the introduction of the usages in > the log. Hope it is not too later to explain here: Yes this should have been described in the cover. > Live migration needs to transfer the VM's memory from the source > machine

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-17 Thread Wei Wang
On 07/17/2017 11:24 PM, Michal Hocko wrote: On Fri 14-07-17 22:17:13, Michael S. Tsirkin wrote: On Fri, Jul 14, 2017 at 02:30:23PM +0200, Michal Hocko wrote: On Wed 12-07-17 20:40:19, Wei Wang wrote: This patch adds support for reporting blocks of pages on the free list specified by the caller

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-17 Thread Michal Hocko
On Fri 14-07-17 22:17:13, Michael S. Tsirkin wrote: > On Fri, Jul 14, 2017 at 02:30:23PM +0200, Michal Hocko wrote: > > On Wed 12-07-17 20:40:19, Wei Wang wrote: > > > This patch adds support for reporting blocks of pages on the free list > > > specified by the caller. > > > > > > As pages can lea

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 02:30:23PM +0200, Michal Hocko wrote: > On Wed 12-07-17 20:40:19, Wei Wang wrote: > > This patch adds support for reporting blocks of pages on the free list > > specified by the caller. > > > > As pages can leave the free list during this call or immediately > > afterwards,

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-14 Thread Michael S. Tsirkin
On Fri, Jul 14, 2017 at 02:54:30PM +0200, Michal Hocko wrote: > On Fri 14-07-17 14:30:23, Michal Hocko wrote: > > On Wed 12-07-17 20:40:19, Wei Wang wrote: > > > This patch adds support for reporting blocks of pages on the free list > > > specified by the caller. > > > > > > As pages can leave the

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 14:30:23, Michal Hocko wrote: > On Wed 12-07-17 20:40:19, Wei Wang wrote: > > This patch adds support for reporting blocks of pages on the free list > > specified by the caller. > > > > As pages can leave the free list during this call or immediately > > afterwards, they are not gu

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-14 Thread Michal Hocko
On Wed 12-07-17 20:40:19, Wei Wang wrote: > This patch adds support for reporting blocks of pages on the free list > specified by the caller. > > As pages can leave the free list during this call or immediately > afterwards, they are not guaranteed to be free after the function > returns. The only

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-13 Thread Wei Wang
On 07/13/2017 08:33 AM, Michael S. Tsirkin wrote: On Wed, Jul 12, 2017 at 08:40:19PM +0800, Wei Wang wrote: This patch adds support for reporting blocks of pages on the free list specified by the caller. As pages can leave the free list during this call or immediately afterwards, they are not g

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-12 Thread Michael S. Tsirkin
On Wed, Jul 12, 2017 at 08:40:19PM +0800, Wei Wang wrote: > This patch adds support for reporting blocks of pages on the free list > specified by the caller. > > As pages can leave the free list during this call or immediately > afterwards, they are not guaranteed to be free after the function > r