Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-05-02 Thread David Gibson
On Fri, Apr 20, 2018 at 07:57:34PM +0100, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > > So. AFAICT the estimate of page dirty rate is based on the assumption > > that page dirties are independent of each other - one page is as > > likely to be

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-05-02 Thread David Gibson
On Sun, Apr 22, 2018 at 12:42:49AM +0530, Balamuruhan S wrote: > On Thu, Apr 19, 2018 at 09:48:17PM +1000, David Gibson wrote: > > On Thu, Apr 19, 2018 at 10:14:52AM +0530, Balamuruhan S wrote: > > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > > * Balamuruhan S

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-21 Thread Balamuruhan S
On Fri, Apr 20, 2018 at 11:28:04AM +0100, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Thu, Apr 19, 2018 at 12:24:04PM +0100, Dr. David Alan Gilbert wrote: > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > > On Wed, Apr 18, 2018 at

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-21 Thread Balamuruhan S
On Thu, Apr 19, 2018 at 09:48:17PM +1000, David Gibson wrote: > On Thu, Apr 19, 2018 at 10:14:52AM +0530, Balamuruhan S wrote: > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > > On Wed, Apr 18, 2018 at

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > So. AFAICT the estimate of page dirty rate is based on the assumption > that page dirties are independent of each other - one page is as > likely to be dirtied as any other. If we don't make that assumption, > I don't see how we can really

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-20 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Thu, Apr 19, 2018 at 12:24:04PM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > > * Balamuruhan S

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 12:24:04PM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > > On Wed, Apr 18, 2018 at

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-19 Thread David Gibson
On Thu, Apr 19, 2018 at 10:14:52AM +0530, Balamuruhan S wrote: > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > > > On Wed, Apr 18, 2018 at

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-19 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > > > On Wed, Apr 18, 2018 at 10:55:50AM +1000,

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 09:36:33AM +0100, Dr. David Alan Gilbert wrote: > * Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > > > On Tue, Apr 17, 2018 at

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Dr. David Alan Gilbert
* Balamuruhan S (bal...@linux.vnet.ibm.com) wrote: > On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > > > expected_downtime value is not accurate

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > using ram_bytes_remaining would yeild it correct. > > This commit message hasn't been

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-18 Thread Balamuruhan S
On Wed, Apr 18, 2018 at 10:57:26AM +1000, David Gibson wrote: > On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > > using

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread David Gibson
On Wed, Apr 18, 2018 at 10:55:50AM +1000, David Gibson wrote: > On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > > expected_downtime value is not accurate with dirty_pages_rate * page_size, > > using ram_bytes_remaining would yeild it correct. > > This commit message hasn't been

Re: [Qemu-devel] [PATCH v2 1/1] migration: calculate expected_downtime with ram_bytes_remaining()

2018-04-17 Thread David Gibson
On Tue, Apr 17, 2018 at 06:53:17PM +0530, Balamuruhan S wrote: > expected_downtime value is not accurate with dirty_pages_rate * page_size, > using ram_bytes_remaining would yeild it correct. This commit message hasn't been changed since v1, but the patch is doing something completely different.