Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-27 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. > > Changed zillions of devices to make them return 0; the

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-26 Thread Cornelia Huck
On Mon, 25 Sep 2017 12:29:12 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. > > Changed zillions of

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-25 Thread Peter Xu
On Mon, Sep 25, 2017 at 12:29:12PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. > > Changed zillions of devices to make

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-25 Thread Richard Henderson
On 09/25/2017 06:25 AM, Dr. David Alan Gilbert wrote: >> Why not a bool? > > Consistency with pre_load, post_load, put and get methods > that are already int. Fair enough, thanks. r~

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-25 Thread Dr. David Alan Gilbert
* Richard Henderson (r...@twiddle.net) wrote: > On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote: > > Modify the pre_save method on VMStateDescription to return an int > > rather than void so that it potentially can fail. > > What does the int value signify? 0 is success, anything else

Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int

2017-09-25 Thread Richard Henderson
On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote: > Modify the pre_save method on VMStateDescription to return an int > rather than void so that it potentially can fail. What does the int value signify? Why not a bool? r~