Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 19:15:36 +1000 David Gibson wrote: [...] > > > > > > Hrm. I dislike code for the core object directly reaching into the > > > machine to check the compat flag here (and a bunch of other places > > > below). I can think of a few possible ways of

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread David Gibson
On Mon, May 22, 2017 at 09:20:42AM +0200, Cédric Le Goater wrote: > On 05/22/2017 04:30 AM, David Gibson wrote: > > On Fri, May 19, 2017 at 12:32:27PM +0200, Greg Kurz wrote: > >> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > >> sPAPRCPUCore") moved ICP objects from the

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread Cédric Le Goater
On 05/22/2017 04:30 AM, David Gibson wrote: > On Fri, May 19, 2017 at 12:32:27PM +0200, Greg Kurz wrote: >> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under >> sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This >> is an improvement since we no longer allocate

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-21 Thread David Gibson
On Fri, May 19, 2017 at 12:32:27PM +0200, Greg Kurz wrote: > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This > is an improvement since we no longer allocate ICP objects that will > never be used. But it has