Re: [Qemu-devel] [PATCH v2 6/7] target/riscv: rationalise softfloat includes

2019-08-14 Thread Alex Bennée
Palmer Dabbelt writes: > On Fri, 09 Aug 2019 18:55:42 PDT (-0700), alistai...@gmail.com wrote: >> On Fri, Aug 9, 2019 at 2:22 AM Alex Bennée wrote: >>> >>> We should avoid including the whole of softfloat headers in cpu.h and >>> explicitly include it only where we will be calling softfloat

Re: [Qemu-devel] [PATCH v2 6/7] target/riscv: rationalise softfloat includes

2019-08-13 Thread Palmer Dabbelt
On Fri, 09 Aug 2019 18:55:42 PDT (-0700), alistai...@gmail.com wrote: On Fri, Aug 9, 2019 at 2:22 AM Alex Bennée wrote: We should avoid including the whole of softfloat headers in cpu.h and explicitly include it only where we will be calling softfloat functions. We can use the -types.h and

Re: [Qemu-devel] [PATCH v2 6/7] target/riscv: rationalise softfloat includes

2019-08-09 Thread Alistair Francis
On Fri, Aug 9, 2019 at 2:22 AM Alex Bennée wrote: > > We should avoid including the whole of softfloat headers in cpu.h and > explicitly include it only where we will be calling softfloat > functions. We can use the -types.h and -helpers.h in cpu.h for the few > bits that are global. > >