Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-03-05 Thread Igor Mammedov
On Mon, 4 Mar 2019 12:35:32 -0500 Tony Krowiak wrote: > On 12/17/18 10:57 AM, Tony Krowiak wrote: > > Ping!! I'm wondering who might be responsible for merging this fix? See reply from Eduardo, It's queued and will be in his next pull request > > > The qbus_is_full(BusState *bus) function

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-03-05 Thread Pierre Morel
On 04/03/2019 18:35, Tony Krowiak wrote: On 12/17/18 10:57 AM, Tony Krowiak wrote: Ping!! I'm wondering who might be responsible for merging this fix? To alert the maintainers, you must send the patch with putting them or part of them in CC and put the qemu mailing list in CC too. use

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-03-04 Thread Tony Krowiak
On 12/17/18 10:57 AM, Tony Krowiak wrote: Ping!! I'm wondering who might be responsible for merging this fix? The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the max_index value of the BusState structure with the max_dev value of the BusClass structure to determine whether

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-02-28 Thread Eduardo Habkost
On Mon, Dec 17, 2018 at 10:57:30AM -0500, Tony Krowiak wrote: > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > max_index > value of the BusState structure with the max_dev value of the BusClass > structure > to determine whether the maximum number of children has been

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-02-18 Thread Tony Krowiak
On 2/6/19 3:34 AM, Igor Mammedov wrote: On Mon, 28 Jan 2019 15:35:09 -0500 Tony Krowiak wrote: ping! Who is the maintainer responsible for merging this?

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-02-06 Thread Igor Mammedov
On Mon, 28 Jan 2019 15:35:09 -0500 Tony Krowiak wrote: > On 12/17/18 10:57 AM, Tony Krowiak wrote: > > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > > max_index > > value of the BusState structure with the max_dev value of the BusClass > > structure > > to determine

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-28 Thread Tony Krowiak
On 12/17/18 10:57 AM, Tony Krowiak wrote: The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the max_index value of the BusState structure with the max_dev value of the BusClass structure to determine whether the maximum number of children has been reached for the bus. The

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-11 Thread Halil Pasic
On Thu, 10 Jan 2019 17:57:22 +0100 Cornelia Huck wrote: > > I thought the same. They could also be made unsigned long or > > unsigned long long to increase the number of child devices that can be > > plugged in before having to deal with exceeding the index value. > > Making them unsigned

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-11 Thread Halil Pasic
On Thu, 10 Jan 2019 10:50:30 -0500 Tony Krowiak wrote: > On 1/9/19 12:35 PM, Halil Pasic wrote: > > On Wed, 9 Jan 2019 10:36:11 -0500 > > Tony Krowiak wrote: > > > >> On 1/9/19 5:14 AM, Cornelia Huck wrote: [..] > >> A search reveals that max_index is used in only two places: It is used > >>

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-10 Thread Cornelia Huck
On Thu, 10 Jan 2019 10:50:30 -0500 Tony Krowiak wrote: > On 1/9/19 12:35 PM, Halil Pasic wrote: > > On Wed, 9 Jan 2019 10:36:11 -0500 > > Tony Krowiak wrote: > > > >> On 1/9/19 5:14 AM, Cornelia Huck wrote: > >>> On Tue, 8 Jan 2019 15:34:37 -0500 > >>> Tony Krowiak wrote: > >>> >

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-10 Thread Tony Krowiak
On 1/9/19 12:35 PM, Halil Pasic wrote: On Wed, 9 Jan 2019 10:36:11 -0500 Tony Krowiak wrote: On 1/9/19 5:14 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 15:34:37 -0500 Tony Krowiak wrote: On 1/8/19 12:06 PM, Cornelia Huck wrote: On Tue, 8 Jan 2019 17:50:21 +0100 Halil Pasic wrote:

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-09 Thread Halil Pasic
On Wed, 9 Jan 2019 10:36:11 -0500 Tony Krowiak wrote: > On 1/9/19 5:14 AM, Cornelia Huck wrote: > > On Tue, 8 Jan 2019 15:34:37 -0500 > > Tony Krowiak wrote: > > > >> On 1/8/19 12:06 PM, Cornelia Huck wrote: > >>> On Tue, 8 Jan 2019 17:50:21 +0100 > >>> Halil Pasic wrote: > >>> > On

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-09 Thread Tony Krowiak
On 1/9/19 5:14 AM, Cornelia Huck wrote: On Tue, 8 Jan 2019 15:34:37 -0500 Tony Krowiak wrote: On 1/8/19 12:06 PM, Cornelia Huck wrote: On Tue, 8 Jan 2019 17:50:21 +0100 Halil Pasic wrote: On Tue, 8 Jan 2019 17:31:13 +0100 Cornelia Huck wrote: On Tue, 8 Jan 2019 11:08:56 -0500 Tony

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-09 Thread Cornelia Huck
On Tue, 8 Jan 2019 15:34:37 -0500 Tony Krowiak wrote: > On 1/8/19 12:06 PM, Cornelia Huck wrote: > > On Tue, 8 Jan 2019 17:50:21 +0100 > > Halil Pasic wrote: > > > >> On Tue, 8 Jan 2019 17:31:13 +0100 > >> Cornelia Huck wrote: > >> > >>> On Tue, 8 Jan 2019 11:08:56 -0500 > >>> Tony

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-08 Thread Tony Krowiak
On 1/8/19 12:06 PM, Cornelia Huck wrote: On Tue, 8 Jan 2019 17:50:21 +0100 Halil Pasic wrote: On Tue, 8 Jan 2019 17:31:13 +0100 Cornelia Huck wrote: On Tue, 8 Jan 2019 11:08:56 -0500 Tony Krowiak wrote: On 12/17/18 10:57 AM, Tony Krowiak wrote: The qbus_is_full(BusState *bus)

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-08 Thread Cornelia Huck
On Tue, 8 Jan 2019 17:50:21 +0100 Halil Pasic wrote: > On Tue, 8 Jan 2019 17:31:13 +0100 > Cornelia Huck wrote: > > > On Tue, 8 Jan 2019 11:08:56 -0500 > > Tony Krowiak wrote: > > > > > On 12/17/18 10:57 AM, Tony Krowiak wrote: > > > > The qbus_is_full(BusState *bus) function

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-08 Thread Halil Pasic
On Tue, 8 Jan 2019 17:31:13 +0100 Cornelia Huck wrote: > On Tue, 8 Jan 2019 11:08:56 -0500 > Tony Krowiak wrote: > > > On 12/17/18 10:57 AM, Tony Krowiak wrote: > > > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > > > max_index > > > value of the BusState structure

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-08 Thread Cornelia Huck
On Tue, 8 Jan 2019 11:08:56 -0500 Tony Krowiak wrote: > On 12/17/18 10:57 AM, Tony Krowiak wrote: > > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > > max_index > > value of the BusState structure with the max_dev value of the BusClass > > structure > > to determine

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-08 Thread Tony Krowiak
On 12/17/18 10:57 AM, Tony Krowiak wrote: The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the max_index value of the BusState structure with the max_dev value of the BusClass structure to determine whether the maximum number of children has been reached for the bus. The

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2018-12-18 Thread Igor Mammedov
On Mon, 17 Dec 2018 10:57:30 -0500 Tony Krowiak wrote: > The qbus_is_full(BusState *bus) function (qdev_monitor.c) compares the > max_index > value of the BusState structure with the max_dev value of the BusClass > structure > to determine whether the maximum number of children has been