Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-12 Thread Michael S. Tsirkin
On Tue, Jul 10, 2018 at 09:28:57AM -0500, Venu Busireddy wrote: > On 2018-07-10 05:11:18 +0300, Michael S. Tsirkin wrote: > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > > The current patch set includes all the feedback received for proposals [3] > > > and [4]. For the sake

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-10 Thread Venu Busireddy
On 2018-07-10 05:11:18 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > The current patch set includes all the feedback received for proposals [3] > > and [4]. For the sake of completeness, patch for the virtio specification > > is also

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > The current patch set includes all the feedback received for proposals [3] > and [4]. For the sake of completeness, patch for the virtio specification > is also included here. Following is the updated proposal. > > 1. Extend the

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 04:00:36PM +0300, Roman Kagan wrote: > There are a few things that need to be specific for PT and/or PV > transport, the matching identifier among them, but I guess a lot can > still be in common. Maybe but frankly unless someone actually plans to bother implementing all

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > What do we buy > for using a random address during initial discovery and requiring VF to > complete the handshake? I don't see advantages to using a random address that is then changed either: changing a MAC causes network downtime for

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > The plan is to enable group ID based matching in the first place rather than > match by MAC, the latter of which is fragile and problematic. It isn't all that fragile - hyperv used same for a while, so if someone posts working patches

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread si-wei liu
On 7/9/2018 6:00 AM, Roman Kagan wrote: On Tue, Jul 03, 2018 at 03:27:23PM -0700, si-wei liu wrote: On 7/3/2018 2:58 AM, Roman Kagan wrote: So how is this coordination going to work? One possibility is that the PV device emits a QMP event upon the guest driver confirming the support for

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 04:00:36PM +0300, Roman Kagan wrote: > > The assumption of failover driver is that the primary (PT device) will be > > able to get a datapath once it shows up in the guest . > > I wonder how universal this assumption is Not universal at all. It is however the simplest

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Roman Kagan
On Tue, Jul 03, 2018 at 03:27:23PM -0700, si-wei liu wrote: > On 7/3/2018 2:58 AM, Roman Kagan wrote: > > So how is this coordination going to work? One possibility is that the > > PV device emits a QMP event upon the guest driver confirming the support > > for failover, the management layer

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Michael S. Tsirkin
On Tue, Jul 03, 2018 at 12:58:25PM +0300, Roman Kagan wrote: > > >How is this supposed to work with legacy guests that don't support it? > > Only PV device will be exposed on legacy guest. > > So how is this coordination going to work? Here's a description:

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread si-wei liu
On 7/3/2018 2:58 AM, Roman Kagan wrote: On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Roman Kagan
On Tue, Jul 03, 2018 at 09:28:17AM -0500, Venu Busireddy wrote: > On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: > > My point with these two questions is that since this patchset is > > defining external interfaces -- with guest OS, with management layer -- > > This patch set is not defining

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Venu Busireddy
On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: > > On 7/2/2018 9:14 AM, Roman Kagan wrote: > > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > > > The patch set "Enable virtio_net to act as a standby for a

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Roman Kagan
On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: > On 7/2/2018 9:14 AM, Roman Kagan wrote: > > On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > > > The patch set "Enable virtio_net to act as a standby for a passthru > > > device" [1] deals with live migration of guests

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-02 Thread si-wei liu
On 7/2/2018 9:14 AM, Roman Kagan wrote: On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address

Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-02 Thread Roman Kagan
On Fri, Jun 29, 2018 at 05:19:03PM -0500, Venu Busireddy wrote: > The patch set "Enable virtio_net to act as a standby for a passthru > device" [1] deals with live migration of guests that use passthrough > devices. However, that scheme uses the MAC address for pairing > the virtio device and the