Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-08 Thread Liu, Yi L
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, March 6, 2018 6:27 PM > Subject: Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for > PASID > AddressSpace management > > On 05/03/2018 10:11, Liu, Yi L wrote: > >> Do you really ne

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-06 Thread Paolo Bonzini
On 05/03/2018 10:11, Liu, Yi L wrote: >> Do you really need VTDDeviceNode? I think can you simply put the >> QLIST_ENTRY in VTDAddressSpace (named e.g. next_by_pasid), since >> VTDAddressSpace already includes a (bus, devfn). > Existing VTDAddressSpace is actaully per-device. While for PASID

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-05 Thread Liu, Yi L
On Fri, Mar 02, 2018 at 03:52:44PM +0100, Paolo Bonzini wrote: > On 01/03/2018 11:33, Liu, Yi L wrote: > > Please merge this patch with the next one, since they are basically the > .h and .c sides of the same thing. yes, would do it in next version. Thanks, Yi Liu

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-05 Thread Liu, Yi L
On Fri, Mar 02, 2018 at 04:00:23PM +0100, Paolo Bonzini wrote: > On 01/03/2018 11:33, Liu, Yi L wrote: > > +struct VTDDeviceNode { > > +PCIBus *bus; > > +uint8_t devfn; > > +QLIST_ENTRY(VTDDeviceNode) next; > > +}; > > Do you really need VTDDeviceNode? I think can you simply put the

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-02 Thread Paolo Bonzini
On 01/03/2018 11:33, Liu, Yi L wrote: > +struct VTDDeviceNode { > +PCIBus *bus; > +uint8_t devfn; > +QLIST_ENTRY(VTDDeviceNode) next; > +}; Do you really need VTDDeviceNode? I think can you simply put the QLIST_ENTRY in VTDAddressSpace (named e.g. next_by_pasid), since

Re: [Qemu-devel] [PATCH v3 11/12] intel_iommu: add framework for PASID AddressSpace management

2018-03-02 Thread Paolo Bonzini
On 01/03/2018 11:33, Liu, Yi L wrote: > This patch introduces a framework to manage PASID tagged AddressSpace > in Intel vIOMMU emulator. PASID tagged AddressSpace is an address sapce > which is an abstract of guest process address space in Qemu. The > management framework is as below: > >