Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/11/2018 09:50 AM, Halil Pasic wrote: On 04/11/2018 03:20 PM, Tony Krowiak wrote: I may be all wrong, though... can we at least have a translation of ECA.28 and EECA.28 (the "ap is there" bit and the "ap instructions are interpreted" bit?) I think we have a misunderstanding here. I

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/09/2018 05:32 AM, Cornelia Huck wrote: On Fri, 6 Apr 2018 18:07:56 +0200 Halil Pasic wrote: On 04/05/2018 06:38 PM, Tony Krowiak wrote: On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/11/2018 03:20 PM, Tony Krowiak wrote: I may be all wrong, though... can we at least have a translation of ECA.28 and EECA.28 (the "ap is there" bit and the "ap instructions are interpreted" bit?)    >>> I think we have a misunderstanding here. I will wait for Tony. 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/09/2018 06:51 AM, Cornelia Huck wrote: On Mon, 9 Apr 2018 12:37:42 +0200 Halil Pasic wrote: On 04/09/2018 11:32 AM, Cornelia Huck wrote: We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I think. How about proclaiming a 'has ap

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On Mon, 9 Apr 2018 12:37:42 +0200 Halil Pasic wrote: > On 04/09/2018 11:32 AM, Cornelia Huck wrote: > >> We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I > >> think. How > >> about proclaiming a 'has ap instructions, but nothing to see here' in

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/09/2018 11:32 AM, Cornelia Huck wrote: >> We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I >> think. How >> about proclaiming a 'has ap instructions, but nothing to see here' in the >> SIE interpreted flavor (ECA.28 set) the default way of having ap instructions

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On Fri, 6 Apr 2018 18:07:56 +0200 Halil Pasic wrote: > On 04/05/2018 06:38 PM, Tony Krowiak wrote: > > On 04/03/2018 05:36 AM, Cornelia Huck wrote: > >> On Mon, 2 Apr 2018 12:36:27 -0400 > >> Tony Krowiak  wrote: > >> > >>> On 03/26/2018 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/05/2018 06:38 PM, Tony Krowiak wrote: > On 04/03/2018 05:36 AM, Cornelia Huck wrote: >> On Mon, 2 Apr 2018 12:36:27 -0400 >> Tony Krowiak  wrote: >> >>> On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: > On 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 06/04/2018 16:08, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not being interpreted by the firmware, then

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On Fri, Apr 06, 2018 at 02:32:49PM +0200, Halil Pasic wrote: > > > On 04/06/2018 02:09 PM, Halil Pasic wrote: > > Yes it is conceptually ugly. I'm 100% with you. That's why it should go > > away soon. From the practicality perspective however I would even argue > > that it's > > helpful to the

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/06/2018 02:09 PM, Halil Pasic wrote: > Yes it is conceptually ugly. I'm 100% with you. That's why it should go > away soon. From the practicality perspective however I would even argue that > it's > helpful to the user: tells 'oops you have forgotten something'. IMHO > it's a shortcut of

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/06/2018 11:11 AM, David Hildenbrand wrote: > On 06.04.2018 10:40, Cornelia Huck wrote: >> On Thu, 5 Apr 2018 19:17:47 +0200 >> Halil Pasic wrote: >> >>> On 04/05/2018 06:38 PM, Tony Krowiak wrote: > Hard to really give good advice without access to the 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 06.04.2018 10:40, Cornelia Huck wrote: > On Thu, 5 Apr 2018 19:17:47 +0200 > Halil Pasic wrote: > >> On 04/05/2018 06:38 PM, Tony Krowiak wrote: Hard to really give good advice without access to the documentation, but: - If we tell the guest that the 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On Thu, 5 Apr 2018 19:17:47 +0200 Halil Pasic wrote: > On 04/05/2018 06:38 PM, Tony Krowiak wrote: > >> Hard to really give good advice without access to the documentation, but: > >> - If we tell the guest that the feature is available, but it does not > >>    get any 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/05/2018 06:38 PM, Tony Krowiak wrote: >> Hard to really give good advice without access to the documentation, but: >> - If we tell the guest that the feature is available, but it does not >>    get any cards to use, returning an empty matrix makes the most sense >>    to me. >> - I would 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: +/* + * The Query

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 10:12 PM, Tony Krowiak wrote: > On 04/04/2018 09:43 AM, Pierre Morel wrote: >> On 04/04/2018 15:33, Tony Krowiak wrote: >>> On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: > On 03/26/2018 05:03 AM, Pierre Morel wrote: >> On

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 09:43 AM, Pierre Morel wrote: On 04/04/2018 15:33, Tony Krowiak wrote: On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 15:33, Tony Krowiak wrote: On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: +/* + * The Query

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 14:59, Tony Krowiak wrote: On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e.,

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e.,

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/04/2018 11:36, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: +/* + * The Query

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak wrote: > On 03/26/2018 05:03 AM, Pierre Morel wrote: > > On 26/03/2018 10:32, David Hildenbrand wrote: > >> On 16.03.2018 00:24, Tony Krowiak wrote: > >>> +/* > >>> + * The Query Configuration Information

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 08:01 AM, Halil Pasic wrote: On 03/26/2018 11:03 AM, Pierre Morel wrote: +int ap_device_handle_pqap(S390CPU *cpu) +{ +CPUS390XState *env = >env; +int fc = 4 & (env->regs[0] >> 24); + +/* + * The Query Configuration Information (QCI) function (fc == 4) does not +

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 04:32 AM, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 11:03 AM, Pierre Morel wrote: >>> +int ap_device_handle_pqap(S390CPU *cpu) >>> +{ >>> +CPUS390XState *env = >env; >>> +int fc = 4 & (env->regs[0] >> 24); >>> + >>> +/* >>> + * The Query Configuration Information (QCI) function (fc == 4) does  >>> not >>> + * set 

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 16.03.2018 00:24, Tony Krowiak wrote: > If the CPU model indicates that AP facility is installed on > the guest (i.e., -cpu ,ap=on), then the expectation is that > the AP bus running in the guest will initialize; however, if the > AP instructions are not being interpreted by the firmware,

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/16/2018 04:03 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions are not being interpreted by the firmware, then