Re: [Qemu-devel] [PATCH v3 7/7] iotests: add iotest 236 for testing bitmap merge

2018-12-18 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 2:15, John Snow wrote: > New interface, new smoke test. don't forget to add s-o-b here and in previous patch :) Feel, that I do too much nitpicking. Actually test is good and works for me, so, with at least qemu_img_pipe -> qemu_img or qemu_img_create and added newline at the end of

Re: [Qemu-devel] [PATCH v3 7/7] iotests: add iotest 236 for testing bitmap merge

2018-12-18 Thread Vladimir Sementsov-Ogievskiy
18.12.2018 0:32, John Snow wrote: > > > On 12/17/18 10:48 AM, Vladimir Sementsov-Ogievskiy wrote: >> 15.12.2018 2:15, John Snow wrote: >>> New interface, new smoke test. >>> --- >>>tests/qemu-iotests/236 | 124 +++ >>>tests/qemu-iotests/236.out | 200

Re: [Qemu-devel] [PATCH v3 7/7] iotests: add iotest 236 for testing bitmap merge

2018-12-17 Thread John Snow
On 12/17/18 10:48 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.12.2018 2:15, John Snow wrote: >> New interface, new smoke test. >> --- >> tests/qemu-iotests/236 | 124 +++ >> tests/qemu-iotests/236.out | 200 + >>

Re: [Qemu-devel] [PATCH v3 7/7] iotests: add iotest 236 for testing bitmap merge

2018-12-17 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 2:15, John Snow wrote: > New interface, new smoke test. > --- > tests/qemu-iotests/236 | 124 +++ > tests/qemu-iotests/236.out | 200 + > tests/qemu-iotests/group | 1 + > 3 files changed, 325 insertions(+) > create