Re: [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-10 Thread Eric Blake
On 10/4/18 8:20 AM, Marc-André Lureau wrote: Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: It was not obvious what exactly the cryptic string copying does to the GUID. This change makes the intent clearer. In the subject line, s/striping/stripping/ (this is about performing a

Re: [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-10 Thread Tomáš Golembiovský
On Thu, 4 Oct 2018 17:20:50 +0400 Marc-André Lureau wrote: > Hi > > On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > > > It was not obvious what exactly the cryptic string copying does to the > > GUID. This change makes the intent clearer. > > > > Signed-off-by: Tomáš Golembiovský

Re: [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-07 Thread Sameeh Jubran
+1, this is much clearer. On Thu, Oct 4, 2018 at 4:34 PM Marc-André Lureau wrote: > > Hi > > On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > > > It was not obvious what exactly the cryptic string copying does to the > > GUID. This change makes the intent clearer. > > > >

Re: [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > It was not obvious what exactly the cryptic string copying does to the > GUID. This change makes the intent clearer. > > Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau > --- > qga/commands-win32.c | 9