Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-08 Thread Stefan Hajnoczi
On Tue, Oct 06, 2015 at 03:53:33PM +0100, Peter Maydell wrote: > On 6 October 2015 at 15:44, Stefan Hajnoczi wrote: > > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > >> @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void *opaque, > >> hwaddr addr, > >>

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-08 Thread Marc Marí
On Thu, 8 Oct 2015 10:07:34 +0100 Stefan Hajnoczi wrote: > On Tue, Oct 06, 2015 at 03:53:33PM +0100, Peter Maydell wrote: > > On 6 October 2015 at 15:44, Stefan Hajnoczi > > wrote: > > > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > > >> @@

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-06 Thread Peter Maydell
On 6 October 2015 at 15:44, Stefan Hajnoczi wrote: > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: >> @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void *opaque, hwaddr >> addr, >> } while (i); >> } >> >> +static void

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-06 Thread Marc Marí
On Tue, 6 Oct 2015 15:44:53 +0100 Stefan Hajnoczi wrote: > On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > > @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void > > *opaque, hwaddr addr, } while (i); > > } > > > > +static void

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-06 Thread Stefan Hajnoczi
On Thu, Oct 01, 2015 at 02:16:55PM +0200, Marc Marí wrote: > @@ -292,6 +307,119 @@ static void fw_cfg_data_mem_write(void *opaque, hwaddr > addr, > } while (i); > } > > +static void fw_cfg_dma_transfer(FWCfgState *s) > +{ > +dma_addr_t len; > +FWCfgDmaAccess dma; > +int arch;

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Marc Marí
On Thu, 1 Oct 2015 16:36:07 +0200 Laszlo Ersek wrote: > This looks good to me. Thanks for addressing my v3 request. > > I have some new remarks here. I feel *really* bad for not finding them > earlier. (If you get tired of working on this series, I could pick it > up and try

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Laszlo Ersek
This looks good to me. Thanks for addressing my v3 request. I have some new remarks here. I feel *really* bad for not finding them earlier. (If you get tired of working on this series, I could pick it up and try to shepherd it further.) On 10/01/15 14:16, Marc Marí wrote: > Based on the

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Peter Maydell
On 1 October 2015 at 15:36, Laszlo Ersek wrote: > I think I finally understand this difference now. It is all rooted in > the difference between the internal APIs sysbus_add_io() and > sysbus_init_mmio(). Both of these are called from the device realize > functions, but the

Re: [Qemu-devel] [PATCH v4 3/7] Implement fw_cfg DMA interface

2015-10-01 Thread Laszlo Ersek
On 10/01/15 19:18, Peter Maydell wrote: > On 1 October 2015 at 15:36, Laszlo Ersek wrote: >> I think I finally understand this difference now. It is all rooted in >> the difference between the internal APIs sysbus_add_io() and >> sysbus_init_mmio(). Both of these are called