Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 01.03.2018 um 10:57 hat Vladimir Sementsov-Ogievskiy geschrieben: > 01.03.2018 12:48, Kevin Wolf wrote: > > Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 26.02.2018 17:05, Kevin Wolf wrote: > > > > Essentially, assuming a simple backing chain 'base <- overlay', we

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

01.03.2018 12:48, Kevin Wolf wrote: Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: 26.02.2018 17:05, Kevin Wolf wrote: Essentially, assuming a simple backing chain 'base <- overlay', we got these combinations to represent in NBD (with my suggestion of the flags to use):

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 01.03.2018 um 08:25 hat Vladimir Sementsov-Ogievskiy geschrieben: > 26.02.2018 17:05, Kevin Wolf wrote: > > Essentially, assuming a simple backing chain 'base <- overlay', we got > > these combinations to represent in NBD (with my suggestion of the flags > > to use): > > > > 1. Cluster

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

26.02.2018 17:05, Kevin Wolf wrote: Am 24.02.2018 um 00:38 hat Eric Blake geschrieben: On 02/23/2018 11:05 AM, Kevin Wolf wrote: Am 23.02.2018 um 17:43 hat Eric Blake geschrieben: OFFSET_VALID | DATA might be excusable because I can see that it's convenient that a protocol driver refers to

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 24.02.2018 um 00:38 hat Eric Blake geschrieben: > On 02/23/2018 11:05 AM, Kevin Wolf wrote: > > Am 23.02.2018 um 17:43 hat Eric Blake geschrieben: > > > > OFFSET_VALID | DATA might be excusable because I can see that it's > > > > convenient that a protocol driver refers to itself as *file

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

On 02/23/2018 11:05 AM, Kevin Wolf wrote: Am 23.02.2018 um 17:43 hat Eric Blake geschrieben: OFFSET_VALID | DATA might be excusable because I can see that it's convenient that a protocol driver refers to itself as *file instead of returning NULL there and then the offset is valid (though it

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 23.02.2018 um 17:43 hat Eric Blake geschrieben: > > OFFSET_VALID | DATA might be excusable because I can see that it's > > convenient that a protocol driver refers to itself as *file instead of > > returning NULL there and then the offset is valid (though it would be > > pointless to actually

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

On 02/14/2018 06:05 AM, Kevin Wolf wrote: +static int coroutine_fn null_co_block_status(BlockDriverState *bs, if (s->read_zeroes) { -return BDRV_BLOCK_OFFSET_VALID | start | BDRV_BLOCK_ZERO; -} else { -return BDRV_BLOCK_OFFSET_VALID | start; +ret |=

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 14.02.2018 um 15:44 hat Eric Blake geschrieben: > On 02/14/2018 06:05 AM, Kevin Wolf wrote: > > Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > > > We are gradually moving away from sector-based interfaces, towards > > > byte-based. Update the null driver accordingly. > > > > > >

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

On 02/14/2018 06:05 AM, Kevin Wolf wrote: Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: We are gradually moving away from sector-based interfaces, towards byte-based. Update the null driver accordingly. Signed-off-by: Eric Blake Reviewed-by: Vladimir

Re: [Qemu-devel] [PATCH v8 09/21] null: Switch to .bdrv_co_block_status()

Am 13.02.2018 um 21:26 hat Eric Blake geschrieben: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the null driver accordingly. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy >