On 25/09/2016 02:49, Michael S. Tsirkin wrote:
> > Not quite, there's no reason for the ops to be inside AMDVIState rather
> > than a (static) global.
>
> I guess but it's a logic refactoring, not merely a style one.
> I feel we can do it on top, tool shouldn't require this.
We can do it on
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote:
>
>
> On 24/09/2016 00:05, Michael S. Tsirkin wrote:
> >> e events...
> >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
> >> > ERROR: struct MemoryRegionIOMMUOps should normally be const
> >> > #1527: FILE:
On 24/09/2016 00:05, Michael S. Tsirkin wrote:
>> e events...
>> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
>> > ERROR: struct MemoryRegionIOMMUOps should normally be const
>> > #1527: FILE: hw/i386/amd_iommu.h:280:
>> > +MemoryRegionIOMMUOps iommu_ops;
>
> False positive.
Not
On Fri, Sep 23, 2016 at 01:35:11PM -0700,
no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce
> it
> locally.
>
> Type:
On Fri, Sep 23, 2016 at 01:35:32PM -0700,
no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
> Subject:
Hi,
Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
Subject: [Qemu-devel] [PULL 00/19] virtio, pc:
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1474658051-18617-1-git-send-email-...@redhat.com
Subject: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
