Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Thomas Huth
On 20.06.2016 10:56, Peter Maydell wrote: > On 20 June 2016 at 09:21, Thomas Huth wrote: >> Would it maybe make sense to add some tests for this stuff to the >> tests/tcg/ folder to make sure that such regressions do not sneak back >> in in the future? > > Wouldn't help very

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Peter Maydell
On 20 June 2016 at 09:21, Thomas Huth wrote: > Would it maybe make sense to add some tests for this stuff to the > tests/tcg/ folder to make sure that such regressions do not sneak back > in in the future? Wouldn't help very much, because tests/tcg doesn't get run. (The

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-20 Thread Thomas Huth
On 18.06.2016 06:02, Anton Blanchard wrote: > Hi, > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, do you have a better idea how to fix it? >>> >>> Please try the following. >> >> Thanks! This passes my tests. Feel free to add: >> >> Tested-by: Anton Blanchard

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-17 Thread Richard Henderson
On 06/17/2016 09:02 PM, Anton Blanchard wrote: lis r4,0x7fff@h ori r4,r4,0x7fff@l rlwinm r3,r4,0,25,1 Ah, with zero rotate. I see. New patch coming up. r~

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-17 Thread Anton Blanchard
Hi, > > > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, > > > do you have a better idea how to fix it? > > > > Please try the following. > > Thanks! This passes my tests. Feel free to add: > > Tested-by: Anton Blanchard Actually I think I've found

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-17 Thread Anton Blanchard
Hi rth, > > Bother. I've tentatively put a revert into ppc-for-2.7. Richard, > > do you have a better idea how to fix it? > > Please try the following. Thanks! This passes my tests. Feel free to add: Tested-by: Anton Blanchard Anton

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-16 Thread Richard Henderson
On 06/15/2016 10:19 PM, David Gibson wrote: > On Wed, Jun 15, 2016 at 10:17:19PM +1000, Anton Blanchard wrote: >> Hi, >> >>> From: Richard Henderson >>> >>> A 32-bit rotate insn is more common on hosts than a deposit insn, >>> and if the host has neither the result is truely

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-15 Thread David Gibson
On Wed, Jun 15, 2016 at 10:17:19PM +1000, Anton Blanchard wrote: > Hi, > > > From: Richard Henderson > > > > A 32-bit rotate insn is more common on hosts than a deposit insn, > > and if the host has neither the result is truely horrific. > > > > At the same time, tidy up the

Re: [Qemu-devel] [PULL 03/13] target-ppc: Use 32-bit rotate instead of deposit + 64-bit rotate

2016-06-15 Thread Anton Blanchard
Hi, > From: Richard Henderson > > A 32-bit rotate insn is more common on hosts than a deposit insn, > and if the host has neither the result is truely horrific. > > At the same time, tidy up the temporaries within these functions, > drop the over-use of "likely", drop some