Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-25 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 24 Sept 2021 at 15:43, Daniel P. Berrangé wrote: >> >> On Fri, Sep 24, 2021 at 03:35:52PM +0200, Markus Armbruster wrote: >> > Peter Maydell writes: >> > > Side side note: the JSON event doesn't seem to contemplate >> > > the possibility that a machine might

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Peter Maydell
On Fri, 24 Sept 2021 at 15:43, Daniel P. Berrangé wrote: > > On Fri, Sep 24, 2021 at 03:35:52PM +0200, Markus Armbruster wrote: > > Peter Maydell writes: > > > Side side note: the JSON event doesn't seem to contemplate > > > the possibility that a machine might have more than one RTC... > > > >

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Daniel P . Berrangé
On Fri, Sep 24, 2021 at 03:35:52PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On Fri, 24 Sept 2021 at 13:21, Markus Armbruster wrote: > >> ... this isn't really *target*-specific, it's *device*-specific: some > >> devices implement the event, some don't. > >> > >> Ideally,

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 24 Sept 2021 at 13:21, Markus Armbruster wrote: >> ... this isn't really *target*-specific, it's *device*-specific: some >> devices implement the event, some don't. >> >> Ideally, we'd just fix that. > > Would you want to tell the far end "this machine simply

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Peter Maydell
On Fri, 24 Sept 2021 at 13:29, Marc-André Lureau wrote: > On Fri, Sep 24, 2021 at 4:21 PM Markus Armbruster wrote: >> >> Peter Maydell writes: >> > Could we reconsider this change? It seems to me to be adding >> > complexity and build time and I don't really see the advantage >> > that

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Peter Maydell
On Fri, 24 Sept 2021 at 13:21, Markus Armbruster wrote: > ... this isn't really *target*-specific, it's *device*-specific: some > devices implement the event, some don't. > > Ideally, we'd just fix that. Would you want to tell the far end "this machine simply does not have an RTC device at all

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Marc-André Lureau
Hi On Fri, Sep 24, 2021 at 4:21 PM Markus Armbruster wrote: > Peter Maydell writes: > > > On Mon, 18 Feb 2019 at 14:19, Markus Armbruster > wrote: > >> > >> From: Marc-André Lureau > >> > >> A few targets don't emit RTC_CHANGE, we could restrict the event to > >> the tagets that do emit it.

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-24 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 18 Feb 2019 at 14:19, Markus Armbruster wrote: >> >> From: Marc-André Lureau >> >> A few targets don't emit RTC_CHANGE, we could restrict the event to >> the tagets that do emit it. >> >> Note: There is a lot more of events & commands that we could restrict >>

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-23 Thread Paolo Bonzini
On 23/09/21 15:14, Peter Maydell wrote: It also means that now rtc devices that emit this event need to change in meson.build from softmmu_ss to specific_ss, because the qapi_event_send_rtc_change() prototype is in the generated qapi/qapi-events-misc-target.h header, and that header uses

Re: [Qemu-devel] [PULL 18/18] qapi: move RTC_CHANGE to the target schema

2021-09-23 Thread Peter Maydell
On Mon, 18 Feb 2019 at 14:19, Markus Armbruster wrote: > > From: Marc-André Lureau > > A few targets don't emit RTC_CHANGE, we could restrict the event to > the tagets that do emit it. > > Note: There is a lot more of events & commands that we could restrict > to capable targets, with the cost