Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On 08/06/2017 13:05, Felipe Franciosi wrote: >> Weird. Doesn't QEMU wait for response to GET_VRING_BASE? I think >> it does since we migrate the returned value. > > It does and that's what I said on my first message. On > GET_VRING_BASE, a vhost-user-scsi backend application will stop > picking

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> On 8 Jun 2017, at 01:31, Michael S. Tsirkin wrote: > > On Wed, Jun 07, 2017 at 02:56:57PM -0400, Paolo Bonzini wrote: >> This could be documented, >>> >>> It is documented AFAIK. Pls take a look at the spec documentation. >> >> Found it now. It's not under

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On Wed, Jun 07, 2017 at 02:56:57PM -0400, Paolo Bonzini wrote: > > > > This could be documented, > > > > It is documented AFAIK. Pls take a look at the spec documentation. > > Found it now. It's not under GET_VRING_BASE, it's under "starting > and stopping rings"---fair enough. > > In the

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> > This could be documented, > > It is documented AFAIK. Pls take a look at the spec documentation. Found it now. It's not under GET_VRING_BASE, it's under "starting and stopping rings"---fair enough. In the case of vhost-user-scsi, however, QEMU also must not proceed until vhost-user-scsi

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On Wed, Jun 07, 2017 at 02:22:24PM -0400, Paolo Bonzini wrote: > > > How, since there is no synchronization point between the vhost-user > > > server on the source and the destination? > > > > The idea is that the backend should both stop picking up new requests and > > also quiesce outstanding

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> On 7 Jun 2017, at 16:47, Peter Maydell wrote: > > On 7 June 2017 at 16:39, Felipe Franciosi wrote: >> >>> On 7 Jun 2017, at 16:37, Peter Maydell wrote: >>> >>> On 7 June 2017 at 16:28, Paolo Bonzini

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> > How, since there is no synchronization point between the vhost-user > > server on the source and the destination? > > The idea is that the backend should both stop picking up new requests and > also quiesce outstanding requests upon a GET_VRING_BASE vhost message. This could be documented,

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> On 7 Jun 2017, at 17:21, Paolo Bonzini wrote: > > > > On 07/06/2017 17:39, Felipe Franciosi wrote: >> >>> On 7 Jun 2017, at 16:37, Peter Maydell wrote: >>> >>> On 7 June 2017 at 16:28, Paolo Bonzini wrote: From:

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On 07/06/2017 17:39, Felipe Franciosi wrote: > >> On 7 Jun 2017, at 16:37, Peter Maydell wrote: >> >> On 7 June 2017 at 16:28, Paolo Bonzini wrote: >>> From: Felipe Franciosi >>> >>> This commit introduces a vhost-user device

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On 7 June 2017 at 16:39, Felipe Franciosi wrote: > >> On 7 Jun 2017, at 16:37, Peter Maydell wrote: >> >> On 7 June 2017 at 16:28, Paolo Bonzini wrote: >>> From: Felipe Franciosi >>> >>> This commit

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

> On 7 Jun 2017, at 16:37, Peter Maydell wrote: > > On 7 June 2017 at 16:28, Paolo Bonzini wrote: >> From: Felipe Franciosi >> >> This commit introduces a vhost-user device for SCSI. This is based >> on the existing

Re: [Qemu-devel] [PULL 18/33] vhost-user-scsi: Introduce vhost-user-scsi host device

On 7 June 2017 at 16:28, Paolo Bonzini wrote: > From: Felipe Franciosi > > This commit introduces a vhost-user device for SCSI. This is based > on the existing vhost-scsi implementation, but done over vhost-user > instead. It also uses a chardev to