Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

2016-07-19 Thread Stefan Hajnoczi
On Tue, Jul 19, 2016 at 07:42:00AM +0200, Reda Sallahi wrote: > +struct DdIo { > +size_t bsz;/* Block size */ > +off_t offset; Oops, I did notice this. No POSIX APIs with off_t are used. Please use the QEMU block layer's int64_t type instead. Stefan signature.asc Description: PGP

Re: [Qemu-devel] [Qemu-block] [PATCH v3] qemu-img: add the 'dd' subcommand

2016-07-19 Thread Stefan Hajnoczi
On Tue, Jul 19, 2016 at 07:42:00AM +0200, Reda Sallahi wrote: > This patch adds a basic dd subcommand analogous to dd(1) to qemu-img. > > For the start, this implements the bs, if, of and count options and requires > both if and of to be specified (no stdin/stdout if not specified) and doesn't > s