Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread David Gibson
On Wed, Jan 10, 2018 at 11:19:33AM +1100, Suraj Jitindar Singh wrote: > On Tue, 2018-01-09 at 13:07 +0100, Andrea Bolognani wrote: > > On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: > > [...] > > > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, > > > Error

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 09:13 -0200, Murilo Opsfelder Araújo wrote: > On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > > Currently spapr_caps are tied to boolean values (on or off). This > > patch > > reworks the caps so that they can have any value between 0 and 127, > > inclusive. This allows

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Suraj Jitindar Singh
On Tue, 2018-01-09 at 13:07 +0100, Andrea Bolognani wrote: > On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: > [...] > > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, > > Error **errp) > > +{ > > +if (!val) { > > +/* TODO: We don't support disabling

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Andrea Bolognani
On Tue, 2018-01-09 at 20:21 +1100, Suraj Jitindar Singh wrote: [...] > +static void cap_htm_allow(sPAPRMachineState *spapr, uint8_t val, Error > **errp) > +{ > +if (!val) { > +/* TODO: We don't support disabling htm yet */ > +return; > +} > if (tcg_enabled()) { >

Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [RFC 1/3] hw/ppc/spapr_caps: Rework spapr_caps to use uint8 internal representation

2018-01-09 Thread Murilo Opsfelder Araújo
On 01/09/2018 07:21 AM, Suraj Jitindar Singh wrote: > Currently spapr_caps are tied to boolean values (on or off). This patch > reworks the caps so that they can have any value between 0 and 127, > inclusive. This allows more capabilities with various values to be > represented in the same way