Re: [Qemu-devel] [RCF PATCH 5/8] arm/nwfps: remove use of cpsr_write() and set flags directly

2014-06-04 Thread Alex Bennée
Peter Maydell writes: On 2 June 2014 17:21, Alex Bennée alex.ben...@linaro.org wrote: This is a pre-cursor to removing the cpsr_write function. diff --git a/linux-user/arm/nwfpe/fpa11.h b/linux-user/arm/nwfpe/fpa11.h index bb9ac65..0dbdf75 100644 --- a/linux-user/arm/nwfpe/fpa11.h +++

Re: [Qemu-devel] [RCF PATCH 5/8] arm/nwfps: remove use of cpsr_write() and set flags directly

2014-06-04 Thread Peter Maydell
On 4 June 2014 12:11, Alex Bennée alex.ben...@linaro.org wrote: Peter Maydell writes: This seems like it's clearly making things worse. We definitely don't want to have to have code in linux-user be aware of the interesting definitions of our ZF/NF/CF/VF fields. snip You are right. I could

Re: [Qemu-devel] [RCF PATCH 5/8] arm/nwfps: remove use of cpsr_write() and set flags directly

2014-06-03 Thread Peter Maydell
On 2 June 2014 17:21, Alex Bennée alex.ben...@linaro.org wrote: This is a pre-cursor to removing the cpsr_write function. diff --git a/linux-user/arm/nwfpe/fpa11.h b/linux-user/arm/nwfpe/fpa11.h index bb9ac65..0dbdf75 100644 --- a/linux-user/arm/nwfpe/fpa11.h +++