Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Jan Kiszka
On 2011-10-17 15:48, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 03:41:44PM +0200, Avi Kivity wrote: On 10/17/2011 03:41 PM, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 01:15:56PM +0200, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: diff --git a/hw/msi.c b/hw/msi.c index 3c7ebc3..9055155 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -40,6 +40,14 @@ /*

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Jan Kiszka
On 2011-10-18 14:05, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: diff --git a/hw/msi.c b/hw/msi.c index 3c7ebc3..9055155 100644 --- a/hw/msi.c

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 02:23:29PM +0200, Jan Kiszka wrote: On 2011-10-18 14:05, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: diff --git

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Jan Kiszka
On 2011-10-18 14:38, Michael S. Tsirkin wrote: On Tue, Oct 18, 2011 at 02:23:29PM +0200, Jan Kiszka wrote: On 2011-10-18 14:05, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread malc
On Tue, 18 Oct 2011, Michael S. Tsirkin wrote: On Tue, Oct 18, 2011 at 02:23:29PM +0200, Jan Kiszka wrote: On 2011-10-18 14:05, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-18 Thread Michael S. Tsirkin
On Tue, Oct 18, 2011 at 04:44:47PM +0400, malc wrote: On Tue, 18 Oct 2011, Michael S. Tsirkin wrote: On Tue, Oct 18, 2011 at 02:23:29PM +0200, Jan Kiszka wrote: On 2011-10-18 14:05, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 09:15:47PM +0200, Jan Kiszka wrote: On 2011-10-17

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Avi Kivity
On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what happens on hardware, but imposes some limitations on the emulation when introducing KVM in-kernel irqchip models. For those we will need to track the message

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what happens on hardware, but imposes some limitations on the emulation when introducing KVM in-kernel irqchip models. For

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Avi Kivity
On 10/17/2011 01:15 PM, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what happens on hardware, but imposes some limitations on the emulation when

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 13:22, Avi Kivity wrote: On 10/17/2011 01:15 PM, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what happens on hardware, but imposes some

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Avi Kivity
On 10/17/2011 01:29 PM, Jan Kiszka wrote: APIC is x86-specific, MSI is not. I think Xen will also want to make use of this hook. I originally though of using it for the KVM in-kernel models as well, but I will now establish a callback at APIC-level (upstream will look differently from

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 01:15:56PM +0200, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what happens on hardware, but imposes some limitations on

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Avi Kivity
On 10/17/2011 03:41 PM, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 01:15:56PM +0200, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by writing them into the target MMIO area. This reflects what

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: diff --git a/hw/msi.c b/hw/msi.c index 3c7ebc3..9055155 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -40,6 +40,14 @@ /* Flag for interrupt controller to declare MSI/MSI-X support */ bool msi_supported; +static void

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Michael S. Tsirkin
On Mon, Oct 17, 2011 at 03:41:44PM +0200, Avi Kivity wrote: On 10/17/2011 03:41 PM, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 01:15:56PM +0200, Jan Kiszka wrote: On 2011-10-17 12:56, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: So far we deliver MSI messages by

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 15:43, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 11:27:45AM +0200, Jan Kiszka wrote: diff --git a/hw/msi.c b/hw/msi.c index 3c7ebc3..9055155 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -40,6 +40,14 @@ /* Flag for interrupt controller to declare MSI/MSI-X support */ bool

Re: [Qemu-devel] [RFC][PATCH 11/45] msi: Factor out delivery hook

2011-10-17 Thread Jan Kiszka
On 2011-10-17 14:14, Avi Kivity wrote: Can you post a git tree? It will be easier for me to understand the whole thing this way. Pushed current state to git://git.kiszka.org/qemu-kvm.git queues/msi Jan signature.asc Description: OpenPGP digital signature