Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-15 Thread Paolo Bonzini
On 15/09/2016 16:13, Brijesh Singh wrote: > 1) something like this > > diff --git a/target-i386/helper.c b/target-i386/helper.c > index a9d8aef..6322265 100644 > --- a/target-i386/helper.c > +++ b/target-i386/helper.c > @@ -1379,13 +1379,22 @@ void x86_cpu_exec_exit(CPUState *cs) > } > >

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-15 Thread Brijesh Singh
Hi Paolo, typedef struct { @@ -3568,6 +3578,7 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, int l; hwaddr phys_addr; target_ulong page; +int mode = is_write ? WRITE_DATA : READ_DATA; while (len > 0) { int asidx; @@ -3583,14 +3594,9 @@ int

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Brijesh Singh
So looking at code, i have impression that write will go through the cpu_physical_memory_write_rom but the read will still go through address_space_rw which will eventually invoke address_space_read. Yes, you'd have to modify it a bit. Something like Sure this will works, thanks for the

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Paolo Bonzini
On 15/09/2016 00:06, Brijesh Singh wrote: > > here is what I see: > > int cpu_memory_rw_debug(CPUState *cpu, target_ulong addr, > uint8_t *buf, int len, int is_write) > { > > >if (is_write) >cpu_physical_memory_write_rom_internal() > else

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Brijesh Singh
On 09/14/2016 04:52 PM, Paolo Bonzini wrote: On 14/09/2016 23:47, Brijesh Singh wrote: On 09/14/2016 04:00 PM, Paolo Bonzini wrote: On 14/09/2016 22:59, Brijesh Singh wrote: I will look into hooking up the callback into ROM read/write ops. I was thinking about adding a new argument in

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 23:47, Brijesh Singh wrote: > > > On 09/14/2016 04:00 PM, Paolo Bonzini wrote: >> >> >> On 14/09/2016 22:59, Brijesh Singh wrote: >>> I will look into hooking up the callback into ROM read/write ops. I was >>> thinking about adding a new argument in >>>

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Brijesh Singh
On 09/14/2016 04:00 PM, Paolo Bonzini wrote: On 14/09/2016 22:59, Brijesh Singh wrote: I will look into hooking up the callback into ROM read/write ops. I was thinking about adding a new argument in cpu_physical_memory_write_rom_internal() void cpu_physical_memory_write_rom(AddressSpace

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Paolo Bonzini
On 14/09/2016 22:59, Brijesh Singh wrote: > I will look into hooking up the callback into ROM read/write ops. I was > thinking about adding a new argument in > cpu_physical_memory_write_rom_internal() > > void cpu_physical_memory_write_rom(AddressSpace *as, hwaddr addr, >

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-14 Thread Brijesh Singh
Hi Paolo, On 09/13/2016 06:05 PM, Paolo Bonzini wrote: On 13/09/2016 16:49, Brijesh Singh wrote: +/* Register SEV read/write ops for the guest RAM */ +if (kvm_sev_enabled()) +memory_region_set_ram_ops(ram, kvm_sev_get_ram_ops()); If you don't actually need this one except

Re: [Qemu-devel] [RFC PATCH v1 15/22] i386: sev: register RAM read/write ops for BIOS and PC.RAM region

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 16:49, Brijesh Singh wrote: > > +/* Register SEV read/write ops for the guest RAM */ > +if (kvm_sev_enabled()) > +memory_region_set_ram_ops(ram, kvm_sev_get_ram_ops()); If you don't actually need this one except for -kernel it would be very nice, because then the