Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-22 Thread Paolo Bonzini
On 20/10/2018 01:46, Emilio G. Cota wrote: >> So it is possible that it was my implementation, and not the approach, >> what was at fault :-) > I've just observed a similar hang after adding the "BQL > pushdown" patches on top of this series. So it's likely that the > hangs come from those

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Emilio G. Cota
On Fri, Oct 19, 2018 at 15:29:32 -0400, Emilio G. Cota wrote: > On Fri, Oct 19, 2018 at 18:01:18 +0200, Paolo Bonzini wrote: > > > Given that we need a per-CPU lock anyway to remove the BQL from the > > > CPU loop, extending this lock to protect cpu->interrupt_request is > > > a simple solution

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Emilio G. Cota
On Fri, Oct 19, 2018 at 18:01:18 +0200, Paolo Bonzini wrote: > On 19/10/2018 16:50, Emilio G. Cota wrote: > > On Fri, Oct 19, 2018 at 08:59:24 +0200, Paolo Bonzini wrote: > >> On 19/10/2018 03:05, Emilio G. Cota wrote: > >>> I'm calling this series a v3 because it supersedes the two series > >>> I

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 16:50, Emilio G. Cota wrote: > On Fri, Oct 19, 2018 at 08:59:24 +0200, Paolo Bonzini wrote: >> On 19/10/2018 03:05, Emilio G. Cota wrote: >>> I'm calling this series a v3 because it supersedes the two series >>> I previously sent about using atomics for interrupt_request: >>>

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Emilio G. Cota
On Fri, Oct 19, 2018 at 08:59:24 +0200, Paolo Bonzini wrote: > On 19/10/2018 03:05, Emilio G. Cota wrote: > > I'm calling this series a v3 because it supersedes the two series > > I previously sent about using atomics for interrupt_request: > >

Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks

2018-10-19 Thread Paolo Bonzini
On 19/10/2018 03:05, Emilio G. Cota wrote: > I'm calling this series a v3 because it supersedes the two series > I previously sent about using atomics for interrupt_request: > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg02013.html > The approach in that series cannot work reliably;