Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-14 Thread Peter Maydell
On Sun, 10 Feb 2019 at 16:57, Mark wrote: > > Signed-off-by: Mark Hi; thanks for submitting this patch! I have some review comments below. As Andrew suggests, it's probably also a good idea to look at Gregory Estrade's implementation of the timer, to see which is the best basis for a patchset

Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-12 Thread Mark
Hi Andrew, Thanks for reviewing the patch I've submitted. I've already messed up two and this is my first time contributing to any open-source software. ☺ I've checked the implementation you suggested and I think it would be a great example for me to implement free-running counters, too. Best

Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-10 Thread Andrew Baumann via Qemu-devel
Hi Mark, > From: Mark > Sent: Sunday, 10 February 2019 08:58 > Subject: [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike > timer Thanks for the patch. The integration with bcm2835_peripherals looks good, but hopefully one of the QEMU maintainers can give you a review of the timer