Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what we do today, a password should be set with block_passwd before issuing the change

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Luiz Capitulino
On Mon, 31 May 2010 13:05:37 +0200 Markus Armbruster arm...@redhat.com wrote: Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Kevin Wolf
Am 31.05.2010 15:48, schrieb Luiz Capitulino: On Mon, 31 May 2010 13:05:37 +0200 Markus Armbruster arm...@redhat.com wrote: Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-30 Thread Avi Kivity
On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what we do today, a password should be set with block_passwd before issuing the change command. Otherwise an error is throw.

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-28 Thread Anthony Liguori
On 05/28/2010 02:13 PM, Kevin Wolf wrote: Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me explain briefly why we need new commands. We want a clean separation between host

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-28 Thread Luiz Capitulino
On Fri, 28 May 2010 14:17:07 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/28/2010 02:13 PM, Kevin Wolf wrote: Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me