Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-16 Thread David Gibson
On Thu, 16 Jul 2020 07:37:17 +0200 Markus Armbruster wrote: > David Gibson writes: > > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > > > > ... as you say, 256 shouldn't really be a problem. I was concerned > > about LMB DRCs rather than PCI

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-15 Thread Markus Armbruster
David Gibson writes: > On Mon, 13 Jul 2020 18:13:42 +0200 > Markus Armbruster wrote: > >> David Gibson writes: >> >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> [...] >> >> >> >> The surprising part is that n turns out to be l

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-15 Thread David Gibson
On Mon, 13 Jul 2020 18:13:42 +0200 Markus Armbruster wrote: > David Gibson writes: > > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > [...] > >> > >> The surprising part is that n turns out to be large enough for n^2 to > >> matter *that*

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-13 Thread Markus Armbruster
David Gibson writes: > On Tue, 07 Jul 2020 14:00:06 +0200 > Markus Armbruster wrote: > >> Paolo Bonzini writes: >> >> > On 07/07/20 07:33, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >> >> >>> On 7/7/20 6:45 AM, Thomas Huth wrote: >> On 27/05/2020 10.47, Marku

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-12 Thread David Gibson
On Tue, 07 Jul 2020 14:00:06 +0200 Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 07/07/20 07:33, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> On 7/7/20 6:45 AM, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: >> On 27/05/2020 10.47, Markus Armbruster wrote: >> > "info qom-tree" prints children in unstable order. This is a pain >> > when diffing output for different versions to find change. Print it >> > sorted.

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 02:00:06PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 07/07/20 07:33, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> On 7/7/20 6:45 AM, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info qo

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 07/07/20 07:33, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 7/7/20 6:45 AM, Thomas Huth wrote: On 27/05/2020 10.47, Markus Armbruster wrote: > "info qom-tree" prints children in unstable order. This is a pain > when diffing outpu

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 11:40, Daniel P. Berrangé wrote: > > The info qom-tree calls could be pushed outside the loop > >info qom-tree >for each device type > device_addr type,help >info qom-tree > > Taking /x86_64/device/introspect/concrete/defaults/pc-q35-5.1 as a > example, this change

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info qom-tree" prints children in unstable order. This is a pain > > when diffing output for different versions to find change. Print it > > sorted. > > > > Signed-off-by: Markus Arm

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 10:46, Daniel P. Berrangé wrote: > On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: >> Sure, we can work around that problem in the CI (Alex has already a >> patch queued), but still, is there something you could do about this >> massive slowdown? > > I think the answer is

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 06:45:57AM +0200, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: > > "info qom-tree" prints children in unstable order. This is a pain > > when diffing output for different versions to find change. Print it > > sorted. > > > > Signed-off-by: Markus Arm

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-07 Thread Paolo Bonzini
On 07/07/20 07:33, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 7/7/20 6:45 AM, Thomas Huth wrote: >>> On 27/05/2020 10.47, Markus Armbruster wrote: "info qom-tree" prints children in unstable order. This is a pain when diffing output for different versions to find

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/7/20 6:45 AM, Thomas Huth wrote: >> On 27/05/2020 10.47, Markus Armbruster wrote: >>> "info qom-tree" prints children in unstable order. This is a pain >>> when diffing output for different versions to find change. Print it >>> sorted. >>> >>> Signed-off-by

Re: Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/7/20 6:45 AM, Thomas Huth wrote: > On 27/05/2020 10.47, Markus Armbruster wrote: >> "info qom-tree" prints children in unstable order. This is a pain >> when diffing output for different versions to find change. Print it >> sorted. >> >> Signed-off-by: Markus Armbruster >> --- >> qom/qom-h

Slow down with: 'Make "info qom-tree" show children sorted'

2020-07-06 Thread Thomas Huth
On 27/05/2020 10.47, Markus Armbruster wrote: > "info qom-tree" prints children in unstable order. This is a pain > when diffing output for different versions to find change. Print it > sorted. > > Signed-off-by: Markus Armbruster > --- > qom/qom-hmp-cmds.c | 24 > 1 f