Re: backup transaction with io-thread core dumps

2020-03-26 Thread Dietmar Maurer
> > > As mentioned earlier, even a totally simple/normal backup job fails when > > > using io-threads and the VM is under load. It results in a total > > > VM freeze! > > > > > > > This is definitely a different issue. I'll take a look at it today. > > Thanks. Stefan found a way to avoid that

Re: backup transaction with io-thread core dumps

2020-03-26 Thread Dietmar Maurer
> > > > So the solution is to disable backups when using io-threads? > > > > > > > > > > I meant forbidding transactions with completion-mode == grouped. It > > > would be still possible running transactions (and thus, backups) with > > > completion-mode == individual, which is the default. > >

Re: backup transaction with io-thread core dumps

2020-03-26 Thread Sergio Lopez
On Wed, Mar 25, 2020 at 04:40:48PM +0100, Dietmar Maurer wrote: > > On March 25, 2020 1:39 PM Sergio Lopez wrote: > > > > > > On Wed, Mar 25, 2020 at 01:29:48PM +0100, Dietmar Maurer wrote: > > > > As expected, if both BDS are running on the same IOThread (and thus, > > > > the same

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Dietmar Maurer
> On March 25, 2020 1:39 PM Sergio Lopez wrote: > > > On Wed, Mar 25, 2020 at 01:29:48PM +0100, Dietmar Maurer wrote: > > > As expected, if both BDS are running on the same IOThread (and thus, > > > the same AioContext), the problem is not reproducible. > > > > > > In a general sense, we could

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Wed, Mar 25, 2020 at 01:29:48PM +0100, Dietmar Maurer wrote: > > As expected, if both BDS are running on the same IOThread (and thus, > > the same AioContext), the problem is not reproducible. > > > > In a general sense, we could say that completion modes other than > > "individual" are not

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Dietmar Maurer
> As expected, if both BDS are running on the same IOThread (and thus, > the same AioContext), the problem is not reproducible. > > In a general sense, we could say that completion modes other than > "individual" are not supported for a transaction that may access > different AioContexts. I don't

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Vladimir Sementsov-Ogievskiy
25.03.2020 14:40, Stefan Reiter wrote: On 24/03/2020 17:49, Dietmar Maurer wrote: A more serious issue is that I also get a hang inside the poll loop when the VM is under load. For example, running "stress -d 5" inside the VM (Debian Buster). Then running a simply drive-backup like: {

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Wed, Mar 25, 2020 at 09:13:12AM +0100, Sergio Lopez wrote: > On Tue, Mar 24, 2020 at 02:47:43PM +0100, Max Reitz wrote: > > Hi Dietmar, > > > > I assume this is with master and has popped up only recently? > > > > Maybe it has something to do with the recent mutex patches by Stefan, so > > I’m

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Stefan Reiter
On 24/03/2020 17:49, Dietmar Maurer wrote: A more serious issue is that I also get a hang inside the poll loop when the VM is under load. For example, running "stress -d 5" inside the VM (Debian Buster). Then running a simply drive-backup like: { "execute": "drive-backup", "arguments": {

Re: backup transaction with io-thread core dumps

2020-03-25 Thread Sergio Lopez
On Tue, Mar 24, 2020 at 02:47:43PM +0100, Max Reitz wrote: > Hi Dietmar, > > I assume this is with master and has popped up only recently? > > Maybe it has something to do with the recent mutex patches by Stefan, so > I’m Cc-ing him. > Hi, I was able to reproduce the issue with a build after the

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
A more serious issue is that I also get a hang inside the poll loop when the VM is under load. For example, running "stress -d 5" inside the VM (Debian Buster). Then running a simply drive-backup like: { "execute": "drive-backup", "arguments": { "device": "drive-scsi0", "sync": "full",

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
> I assume this is with master and has popped up only recently? sure > Maybe it has something to do with the recent mutex patches by Stefan, so > I’m Cc-ing him. Thanks.

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
> What version of QEMU are you running? Sergio contributed a lot of AIO > context (and iothread) fixes this release; this looks (at a glance) to > be similar and related. I test with latest code from git commit 09a98dd988c715157c0b80af16fa5baa80101eed Merge: f1e748d279 1583794b9b Author:

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Max Reitz
Hi Dietmar, I assume this is with master and has popped up only recently? Maybe it has something to do with the recent mutex patches by Stefan, so I’m Cc-ing him. Max On 24.03.20 14:33, Dietmar Maurer wrote: > spoke too soon - the error is still there, sigh > >> This is fixed with this

Re: backup transaction with io-thread core dumps

2020-03-24 Thread John Snow
Well, that was a rollercoaster of emotions as I read your mails. On 3/24/20 9:33 AM, Dietmar Maurer wrote: > spoke too soon - the error is still there, sigh > >> This is fixed with this patch: >> >> https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07249.html >> >> thanks! >> >>> On

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
spoke too soon - the error is still there, sigh > This is fixed with this patch: > > https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07249.html > > thanks! > > > On March 24, 2020 12:13 PM Dietmar Maurer wrote: > > > > > > I get a core dump with backup transactions when using

Re: backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
This is fixed with this patch: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg07249.html thanks! > On March 24, 2020 12:13 PM Dietmar Maurer wrote: > > > I get a core dump with backup transactions when using io-threads. > > To reproduce, create and start a VM with: > > #

backup transaction with io-thread core dumps

2020-03-24 Thread Dietmar Maurer
I get a core dump with backup transactions when using io-threads. To reproduce, create and start a VM with: # qemu-img create disk1.raw 100M # qemu-img create disk2.raw 100M #./x86_64-softmmu/qemu-system-x86_64 -chardev 'socket,id=qmp,path=/var/run/qemu-test.qmp,server,nowait' -mon