Re: logfile issue

2019-11-06 Thread Robert Foley
On Mon, 4 Nov 2019 at 07:13, Alex Bennée wrote: > I wonder if using RCU to swap out the new and old FD would make things a > bit smoother here? You would have to tweak the qemu_log_lock/unlock > functions to preserve the current FD around the lock and call_rcu a > freeing function when a new

Re: logfile issue

2019-11-04 Thread Alex Bennée
Robert Foley writes: > We hit an issue when trying to change the log file from the monitor > console. The root of the issue here is that the qemu_logfile handle > is not thread safe. So when we try to close the file, we end up with > a seg fault. The full analysis is below along with some

logfile issue

2019-10-31 Thread Robert Foley
We hit an issue when trying to change the log file from the monitor console. The root of the issue here is that the qemu_logfile handle is not thread safe. So when we try to close the file, we end up with a seg fault. The full analysis is below along with some possible solutions. Will plan to