[Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 09:40 AM, Vadim Rozenfeld wrote: The following patch allows us to improve Windows virtio block driver performance on small size requests. Additionally, it leads to reducing of cpu usage on write IOs Note, this is not an improvement for Windows specifically. diff --git

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Amit Shah
On (Fri) Jan 08 2010 [13:35:03], Jamie Lokier wrote: Since VNC is clearly designed to work over TCP, and is written by people who know this, I'm wondering why you think it needs to be different for virtio-serial. For vnc putting stuff from a guest clipboard into vnc client clipboard using

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Amit Shah
On (Fri) Jan 08 2010 [10:26:59], Anthony Liguori wrote: On 01/08/2010 07:35 AM, Jamie Lokier wrote: Sometimes it looks like TCP is maintaining write boundaries, but it is just an artifact of its behaviour on many systems, and is not reliable even on those systems where it seems to happen most

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Dor Laor
On 01/11/2010 11:03 AM, Dor Laor wrote: On 01/11/2010 10:30 AM, Avi Kivity wrote: On 01/11/2010 09:40 AM, Vadim Rozenfeld wrote: The following patch allows us to improve Windows virtio block driver performance on small size requests. Additionally, it leads to reducing of cpu usage on write IOs

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Jamie Lokier
Amit Shah wrote: On (Fri) Jan 08 2010 [13:35:03], Jamie Lokier wrote: Since VNC is clearly designed to work over TCP, and is written by people who know this, I'm wondering why you think it needs to be different for virtio-serial. For vnc putting stuff from a guest clipboard into vnc

Re: [Qemu-devel] [PATCH 5/8] virtio-serial-bus: Add support for buffering guest output, throttling guests

2010-01-11 Thread Amit Shah
On (Mon) Jan 11 2010 [10:45:53], Jamie Lokier wrote: Amit Shah wrote: On (Fri) Jan 08 2010 [13:35:03], Jamie Lokier wrote: Since VNC is clearly designed to work over TCP, and is written by people who know this, I'm wondering why you think it needs to be different for virtio-serial.

[Qemu-devel] Hang up: qemu-system-ppc creates a ppc VM on a x86_64 host with OS Fedora12.

2010-01-11 Thread Zhiyong Wu
HI, guys, when qemu-system-ppc creates a f12 ppc VM on a f12 x86_64 host, qemu hangs on the command line of openbios such as: Welcome to OpenBIOS v1.0 built on Dec 7 2009 17:11 0 While qemu creates a RH5.4 ppc VM, the output is such as: cd:0,\ppc\chrp\yaboot.conf: Unknown or corrupt

[Qemu-devel] Re: Hang up: qemu-system-ppc creates a ppc VM on a x86_64 host with OS Fedora12.

2010-01-11 Thread Alexander Graf
Am 11.01.2010 um 12:22 schrieb Zhiyong Wu zwu.ker...@gmail.com: HI, guys, when qemu-system-ppc creates a f12 ppc VM on a f12 x86_64 host, qemu hangs on the command line of openbios such as: Welcome to OpenBIOS v1.0 built on Dec 7 2009 17:11 0 How do you start qemu? To boot from CD you

[Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Christoph Hellwig
Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour of all other image formats which just return an error and let the block core deal with it. Signed-off-by: Christoph Hellwig h...@lst.de Index:

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 11:19:21AM +0200, Dor Laor wrote: Attached results with rhel5.4 (qemu0.11) for win2k8 32bit guest. Note the drastic reduction in cpu consumption. Attachment did not survive the email server, so you'll have to trust me saying that cpu consumption was done from 65% -

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 03:11 PM, Christoph Hellwig wrote: FYI below is the manually applied patch without all the wrapping: static void virtio_blk_req_complete(VirtIOBlockReq *req, int status) { VirtIOBlock *s = req-dev; @@ -95,6 +98,12 @@ static void virtio_blk_req_complete(Virt

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 03:13:53PM +0200, Avi Kivity wrote: As Dor points out, the call to virtio_blk_handle_output() wants to be before the test for pending, so we scan the ring as early as possible I just reposted the patch in a way that it applies to share the work I did when starting to

Re: [Qemu-devel] cpuid problem in upstream qemu with kvm

2010-01-11 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 01/07/2010 02:33 PM, Anthony Liguori wrote: There's another option. Make cpuid information part of live migration protocol, and then support something like -cpu Xeon-3550. We would remember the exact cpuid mask we present to the guest and then we

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 10:30:53AM +0200, Avi Kivity wrote: The patch has potential to reduce performance on volumes with multiple spindles. Consider two processes issuing sequential reads into a RAID array. With this patch, the reads will be executed sequentially rather than in parallel,

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Kevin Wolf
Am 11.01.2010 14:06, schrieb Christoph Hellwig: Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour of all other image formats which just return an error and let the block core deal with it.

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 02:43:59PM +0100, Kevin Wolf wrote: Am 11.01.2010 14:06, schrieb Christoph Hellwig: Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour of all other image formats which just

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 03:13:53PM +0200, Avi Kivity wrote: As Dor points out, the call to virtio_blk_handle_output() wants to be before the test for pending, so we scan the ring as early as possible It could cause a race window where we add an entry to the ring after we run

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 07:42 AM, Christoph Hellwig wrote: On Mon, Jan 11, 2010 at 10:30:53AM +0200, Avi Kivity wrote: The patch has potential to reduce performance on volumes with multiple spindles. Consider two processes issuing sequential reads into a RAID array. With this patch, the reads will

[Qemu-devel] Re: [ kvm-Bugs-2907597 ] qemu vnc server clips at 2560x1600

2010-01-11 Thread Anthony Liguori
On 01/10/2010 10:30 AM, Avi Kivity wrote: On 01/10/2010 06:26 PM, SourceForge.net wrote: Initial Comment: So I am running using the VESA driver to run an Ubuntu 9.10 guest at 2560x1600 (I had to modify the xserver-video-vesa package to remove an internal screen limit of 2048x2048 in the xorg

[Qemu-devel] Re: [RFC 0/7]: Add VNC connect/disconnect events

2010-01-11 Thread Daniel P. Berrange
On Fri, Jan 08, 2010 at 07:47:09PM -0200, Luiz Capitulino wrote: Hi there, This series contains two related changes. First a small cleanup is done in the current 'query-vnc' command, then two new QMP asynchronous events are introduced: VNC connect and disconnect. That's, everytime a

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Kevin Wolf
Am 11.01.2010 14:46, schrieb Christoph Hellwig: On Mon, Jan 11, 2010 at 02:43:59PM +0100, Kevin Wolf wrote: Am 11.01.2010 14:06, schrieb Christoph Hellwig: Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 02:56:16PM +0100, Kevin Wolf wrote: Are you going to propose a cleaner patch? I have currently some other bugs to do first, but I was certainly planning to do so. However, I'll happily leave it to you if you have the time right now. I'm looking into doing it in the

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 07:47 AM, Christoph Hellwig wrote: On Mon, Jan 11, 2010 at 03:13:53PM +0200, Avi Kivity wrote: As Dor points out, the call to virtio_blk_handle_output() wants to be before the test for pending, so we scan the ring as early as possible It could cause a race window where

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Kevin Wolf
Am 11.01.2010 15:00, schrieb Christoph Hellwig: On Mon, Jan 11, 2010 at 02:56:16PM +0100, Kevin Wolf wrote: Are you going to propose a cleaner patch? I have currently some other bugs to do first, but I was certainly planning to do so. However, I'll happily leave it to you if you have the time

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 03:42 PM, Christoph Hellwig wrote: On Mon, Jan 11, 2010 at 10:30:53AM +0200, Avi Kivity wrote: The patch has potential to reduce performance on volumes with multiple spindles. Consider two processes issuing sequential reads into a RAID array. With this patch, the reads will

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 03:49 PM, Anthony Liguori wrote: So instead of disabling notify while requests are active we might want to only disable it while we are inside virtio_blk_handle_output. Something like the following minimally tested patch: I'd suggest that we get even more aggressive and install

[Qemu-devel] Re: [ kvm-Bugs-2907597 ] qemu vnc server clips at 2560x1600

2010-01-11 Thread Avi Kivity
On 01/11/2010 03:53 PM, Anthony Liguori wrote: Anthony, can you take a look at this? Seems like a serious issue, could find nothing obvious in vnc.c. VNC_MAX_WIDTH and VNC_MAX_HEIGHT in vnc.h are currently defined to 2048. We do dirty tracking with a bitmap and that bitmap is currently a

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 08:29 AM, Avi Kivity wrote: On 01/11/2010 03:49 PM, Anthony Liguori wrote: So instead of disabling notify while requests are active we might want to only disable it while we are inside virtio_blk_handle_output. Something like the following minimally tested patch: I'd suggest

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 04:37 PM, Anthony Liguori wrote: That has the downside of bouncing a cache line on unrelated exits. The read and write sides of the ring are widely separated in physical memory specifically to avoid cache line bouncing. I meant, exits on random vcpus will cause the cacheline

[Qemu-devel] [PATCH 1/4] ppc-40x: Get TLB attributes from TLBLO.

2010-01-11 Thread Edgar E. Iglesias
The ZSEL was incorrectly beeing decoded from TLBHI. Decode it from TLBLO instead. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- target-ppc/op_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index

[Qemu-devel] [PATCH 4/4] ppc-40x: Correct ESR for zone protection faults.

2010-01-11 Thread Edgar E. Iglesias
Raise the zone protection fault in ESR for TLB faults caused by zone protection bits. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- target-ppc/helper.c | 23 ++- 1 files changed, 18 insertions(+), 5 deletions(-) diff --git a/target-ppc/helper.c

[Qemu-devel] [PATCH 0/4] PPC 40x MMU fixes.

2010-01-11 Thread Edgar E. Iglesias
Hi, I've been trying to boot linux on an emulated PPC 405 (Xilinx virtex 4) board but I ran into trouble with the 40x MMU emulation. Patch 4 is not the nicest but with this set I can now boot into a shell and get a pretty stable system. I'm very noob at ppc so comments are very welcome.

[Qemu-devel] [PATCH 3/4] ppc-40x: Correct decoding of zone protection bits.

2010-01-11 Thread Edgar E. Iglesias
The 40x MMU has 15 zones in the ZPR register. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- target-ppc/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-ppc/helper.c b/target-ppc/helper.c index b233d4f..f9b5589 100644 ---

Re: [Qemu-devel] Re: [ kvm-Bugs-2907597 ] qemu vnc server clips at 2560x1600

2010-01-11 Thread Jernej Simončič
On Monday, January 11, 2010, 14:53:05, Anthony Liguori wrote: 2048 is bigger than any physical screen that I know of so I assume this is a multiple monitor scenario. 30 TFTs have resolution 2560x1600. Speaking of large resolutions, I just tried 2360x1770 (the largest offered by VMWare VGA

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 08:46 AM, Avi Kivity wrote: On 01/11/2010 04:37 PM, Anthony Liguori wrote: That has the downside of bouncing a cache line on unrelated exits. The read and write sides of the ring are widely separated in physical memory specifically to avoid cache line bouncing. I meant,

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:19 AM, Avi Kivity wrote: OTOH, if we aggressively poll the ring when we have an opportunity to, there's very little down side to that and it addresses the serialization problem. But we can't guarantee that we'll get those opportunities, so it doesn't address the problem in a

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 05:13 PM, Anthony Liguori wrote: On 01/11/2010 08:46 AM, Avi Kivity wrote: On 01/11/2010 04:37 PM, Anthony Liguori wrote: That has the downside of bouncing a cache line on unrelated exits. The read and write sides of the ring are widely separated in physical memory

[Qemu-devel] [PATCH 2/4] ppc-40x: Correct check for Endian swapping TLB entries.

2010-01-11 Thread Edgar E. Iglesias
Bailout on 40x TLB entries with endianess swapping only if the entry is valid. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- target-ppc/op_helper.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout durations, etc) and then we can do some deep performance studies to see how things interact with

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout durations, etc) and then we can do some deep performance

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Avi Kivity
On 01/11/2010 05:32 PM, Anthony Liguori wrote: On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size, various tx mitigation schemes, timeout

Re: [Qemu-devel] Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:35 AM, Avi Kivity wrote: On 01/11/2010 05:32 PM, Anthony Liguori wrote: On 01/11/2010 09:31 AM, Avi Kivity wrote: On 01/11/2010 05:22 PM, Anthony Liguori wrote: Based on our experiences with virtio-net, what I'd suggest is to make a lot of tunable options (ring size,

[Qemu-devel] [PATCH] virtio-pci: thinko fix

2010-01-11 Thread Michael S. Tsirkin
Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will sometimes clear all status registers on bus master disable, which loses information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of a patch being misapplied: code uses ! instead of ~ for bit operations as in Yan's

Re: [Qemu-devel] [BUGFIX] MCE: Fix bug of IA32_MCG_STATUS after system reset

2010-01-11 Thread Anthony Liguori
On 01/05/2010 02:32 AM, Huang Ying wrote: Now, if we inject a fatal MCE into guest OS, for example Linux, Linux will go panic and then reboot. But if we inject another MCE now, system will reset directly instead of go panic firstly, because MCG_STATUS.MCIP is set to 1 and not cleared after

Re: [Qemu-devel] [PATCH] finish VPATH - vpath translation

2010-01-11 Thread Anthony Liguori
On 01/04/2010 04:02 AM, Paolo Bonzini wrote: This adds a few more vpath suffixes and points the remaining two paths explicitly to $(SRC_PATH) in order to eliminate the VPATH assignment from config-host.mak. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied. Thanks. Regards,

Re: [Qemu-devel] [PATCH] Fix CPU topology initialization

2010-01-11 Thread Anthony Liguori
On 01/05/2010 10:26 AM, Jiri Denemark wrote: Late initialization of CPU topology in CPUState prevents KVM guests to actually see the topology. Signed-off-by: Jiri Denemarkjdene...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- vl.c |8 1 files changed, 4

Re: [Qemu-devel] [PATCH resend] vmware_vga: Check cursor dimensions passed from guest to avoid buffer overflow

2010-01-11 Thread Anthony Liguori
On 01/05/2010 10:43 PM, Roland Dreier wrote: Check that the cursor dimensions passed from the guest for the DEFINE_CURSOR command don't overflow the available space in the cursor.image[] or cursor.mask[] arrays before copying data from the guest into those arrays. Signed-off-by: Roland

Re: [Qemu-devel] [PATCH] remove pending exception on vcpu reset.

2010-01-11 Thread Anthony Liguori
On 01/06/2010 08:30 AM, Gleb Natapov wrote: Without this qemu can even start on kvm modules with events support since default value of exception_injected in zero and this is #DE exception. Signed-off-by: Gleb Natapovg...@redhat.com Applied. Thanks. Regards, Anthony Liguori diff --git

[Qemu-devel] Re: [ kvm-Bugs-2907597 ] qemu vnc server clips at 2560x1600

2010-01-11 Thread Avi Kivity
On 01/11/2010 04:30 PM, Avi Kivity wrote: VNC_MAX_WIDTH and VNC_MAX_HEIGHT in vnc.h are currently defined to 2048. We do dirty tracking with a bitmap and that bitmap is currently a fixed size. 2048 is bigger than any physical screen that I know of so I assume this is a multiple monitor

Re: [Qemu-devel] mulu2 not implemented for tcg target sparc

2010-01-11 Thread Richard Henderson
On 01/10/2010 01:17 PM, Palle Lyckegaard wrote: On Sun, 10 Jan 2010, Blue Swirl wrote: Is it needed somewhere? I was trying to run qemu-system-mips with a NetBSD malta kernel that generates a MIPS mult operation. Tracing the code through tcg points at a missing mulu2 opreration for sparc.

[Qemu-devel] Re: New kvm-related qemu patch queue

2010-01-11 Thread Anthony Liguori
On 01/10/2010 06:02 AM, Avi Kivity wrote: In order to improve qemu.git kvm integration quality wrt performance, features, and reliability Marcelo and I will begin to maintain a patch queue based on qemu.git containing kvm-related patches. We will review and apply patches to this queue, test

[Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Michael S. Tsirkin
Here's an untested patchset with vhost support for upstream qemu. Note that you should not expect performance gains from vhost unless in-kernel irqchip is enabled (which is not in upstream qemu now). Since adding vhost involves quite a bit of infrastructure, I thought it makes sense to send an

[Qemu-devel] [PATCH-RFC 01/13] virtio: export virtqueue structure

2010-01-11 Thread Michael S. Tsirkin
vhost needs physical addresses for ring so expose that structure. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 18 -- hw/virtio.h | 17 + 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index

[Qemu-devel] [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-11 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- kvm-all.c | 24 kvm.h |3 +++ 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index a312654..aa00119 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1113,3 +1113,27 @@ void

[Qemu-devel] [PATCH-RFC 03/13] virtio: add iofd/irqfd support

2010-01-11 Thread Michael S. Tsirkin
Add binding API to set iofd/irqfd support. Will be used by vhost. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.c | 13 ++--- hw/virtio.h |4 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 8e3c9ad..b9ec863

[Qemu-devel] [PATCH-RFC 04/13] virtio-pci: fill in irqfd/queufd support

2010-01-11 Thread Michael S. Tsirkin
Support irqfd/queuefd. The last one only with kvm, that's okay because vhost relies on kvm anyway. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-pci.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/virtio-pci.c

[Qemu-devel] [PATCH-RFC 05/13] syborg_virtio: add irqfd/eventfd support

2010-01-11 Thread Michael S. Tsirkin
No idea if it's right .. and syborg does not support vectors so we won't get performance gains out of it either - so quite likely it's best to just keep this patch out of qemu. But just to show what's possible. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/syborg_virtio.c | 25

[Qemu-devel] [PATCH-RFC 07/13] virtio: move typedef to qemu-common

2010-01-11 Thread Michael S. Tsirkin
make it possible to use type without header include Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio.h |1 - qemu-common.h |1 + 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.h b/hw/virtio.h index 193b3f9..6a7e3ec 100644 --- a/hw/virtio.h +++

[Qemu-devel] [PATCH-RFC 08/13] net/tap: add interface to get device fd

2010-01-11 Thread Michael S. Tsirkin
Will be used by vhost to attach/detach to backend. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d3492de..7e9ca79 100644 --- a/net/tap.c +++

[Qemu-devel] [PATCH-RFC 09/13] tap: add vhost/vhostfd options

2010-01-11 Thread Michael S. Tsirkin
Looks like order got mixed up: vhost_net header is added by a follow-up patch. Will be fixed in the next revision. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net.c |8 net/tap.c | 29 + qemu-options.hx |4 +++- 3 files

[Qemu-devel] [PATCH-RFC 10/13] tap: add API to retrieve vhost net header

2010-01-11 Thread Michael S. Tsirkin
same comment as patch 09. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- net/tap.c |7 +++ net/tap.h |3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/tap.c b/net/tap.c index d9f2e41..166cf05 100644 --- a/net/tap.c +++ b/net/tap.c @@ -491,3 +491,10 @@

[Qemu-devel] [PATCH-RFC 12/13] virtio: add status change callback

2010-01-11 Thread Michael S. Tsirkin
vhost net backend needs to be notified when frontend status changes. Add a callback. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/s390-virtio-bus.c |3 +++ hw/syborg_virtio.c |2 ++ hw/virtio-pci.c |6 ++ hw/virtio.h |1 + 4 files changed, 12

[Qemu-devel] [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-11 Thread Michael S. Tsirkin
start/stop backend on driver start/stop Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/virtio-net.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index c2a389f..99169e1 100644 ---

[Qemu-devel] [PATCH-RFC 11/13] vhost net support

2010-01-11 Thread Michael S. Tsirkin
This adds vhost net support in qemu. Will be tied to tap device and virtio later. Raw backend is currently missing, will be worked on/submitted separately. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- Makefile.target |1 + hw/vhost.c | 349

[Qemu-devel] [PATCH] vnc_refresh: return if vd-timer is NULL

2010-01-11 Thread Stefano Stabellini
Hi all, calling vnc_update_client in vnc_refresh might have the unlikely side effect of setting vd-timer = NULL, if the last vnc client disconnected. In this case we have to return from vnc_refresh without updating the timer, otherwise we cause a segfault. Signed-off-by: Stefano Stabellini

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Christoph Hellwig
On Mon, Jan 11, 2010 at 03:11:52PM +0100, Kevin Wolf wrote: More or less the same hack, just in cleaner? Or trying to fundamentally change things? I think you haven't answered yet to what I said in the thread of my original hack. I'm quoting it here for convenience: Well, not dealing with the

[Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

2010-01-11 Thread Christoph Hellwig
Check the whitelist as early as possible instead of continuing the setup, and move all the error handling code to the end of the function. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c === --- qemu.orig/block.c

[Qemu-devel] [PATCH 2/2] block: untangle open flag manipulation in bdrv_open2

2010-01-11 Thread Christoph Hellwig
Untangle the open flag manipulation in bdrv_open2 and document why we are clearing the various flags in the different flag combinations. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c === --- qemu.orig/block.c

[Qemu-devel] Re: Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:37:10AM -0600, Anthony Liguori wrote: On 01/11/2010 08:29 AM, Avi Kivity wrote: On 01/11/2010 03:49 PM, Anthony Liguori wrote: So instead of disabling notify while requests are active we might want to only disable it while we are inside virtio_blk_handle_output.

[Qemu-devel] Re: Re: [RFC][PATCH] performance improvement for windows guests, running on top of virtio block device

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:13:23AM -0600, Anthony Liguori wrote: On 01/11/2010 08:46 AM, Avi Kivity wrote: On 01/11/2010 04:37 PM, Anthony Liguori wrote: That has the downside of bouncing a cache line on unrelated exits. The read and write sides of the ring are widely separated in physical

[Qemu-devel] [PATCH] raw-posix: Detect CDROM via ioctl

2010-01-11 Thread Cole Robinson
Current CDROM detection is hardcoded based on source file name. Make this smarter by attempting a CDROM specific ioctl. This makes '-cdrom /dev/sr0' succeed with no media present. Signed-off-by: Cole Robinson crobi...@redhat.com --- block/raw-posix.c | 18 +- 1 files changed,

[Qemu-devel] [PATCH] raw-posix: Detect IDE floppy via ioctl

2010-01-11 Thread Cole Robinson
Current IDE floppy detection is hardcoded based on source file name. Make this smarter by attempting a floppy specific ioctl. Signed-off-by: Cole Robinson crobi...@redhat.com --- block/raw-posix.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Luiz Capitulino
Hi. We (Markus and I) are working on getting QMP forward compatibility support, supported. :) We have a plan for it and I'd like to ask the CC'ed people to review it. Needless to say, but the objective here is to add new commands, arguments, async messages and protocol features w/o

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions (was Re: [PATCH] eepro100: Fix initial value for PCI_STATUS)

2010-01-11 Thread Michael S. Tsirkin
On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: ... --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index

[Qemu-devel] Re: [PATCH] eepro100: Update ROM file support

2010-01-11 Thread Michael S. Tsirkin
On Thu, Jan 07, 2010 at 05:13:30PM +0100, Stefan Weil wrote: Use new way to associate ROM files to devices. Currently, there is only a ROM file for i82559er included in QEMU, so the patch does not add .romfile for the other devices. When flexible mode is fixed in eepro100, adding more

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Anthony Liguori
On 01/11/2010 12:34 PM, Luiz Capitulino wrote: Hi. We (Markus and I) are working on getting QMP forward compatibility support, supported. :) We have a plan for it and I'd like to ask the CC'ed people to review it. Needless to say, but the objective here is to add new commands,

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread malc
On Mon, 11 Jan 2010, Christoph Hellwig wrote: On Mon, Jan 11, 2010 at 02:56:16PM +0100, Kevin Wolf wrote: Are you going to propose a cleaner patch? I have currently some other bugs to do first, but I was certainly planning to do so. However, I'll happily leave it to you if you have the

[Qemu-devel] virtio: Add memory statistics reporting to the balloon driver (V6)

2010-01-11 Thread Adam Litke
After some good discussion, V6 of this patch integrates well with the new QMP support. When the monitor is in QMP mode, the query-balloon command triggers a stats refresh request to the guest. This request is asynchronous. If the guest does not respond then nothing further happens. When stats

Re: [Qemu-devel] [PATCHv2] Add KVM paravirt cpuid leaf

2010-01-11 Thread Anthony Liguori
On 01/07/2010 10:24 AM, Gleb Natapov wrote: diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 4084503..6a841de 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -17,6 +17,7 @@ #includesys/mman.h #includelinux/kvm.h +#includelinux/kvm_para.h This breaks the build on a

[Qemu-devel] Registering key events android (qemu based) emulator

2010-01-11 Thread Anwar Ghani
Hi All guys I am a bit new to this stuff. I want to call a method after user presses a combination of keys lets say alt+s or whatever. How can I do it using which event handler. Best Regards Anwar Ghani +31 647 344 773 --- On Mon, 1/11/10, Anthony Liguori anth...@codemonkey.ws wrote:

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: ... --- hw/eepro100.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c

Re: [Qemu-devel] [PATCH 2/3] use pkg-config for sdl when cross compiling

2010-01-11 Thread Anthony Liguori
On 01/07/2010 08:42 AM, Paolo Bonzini wrote: Together with the previous patch this enables using the prefixed pkg-config, thus picking up the correct flags for SDL. Since pkg-config has an awful lot of dependencies, I still use sdl-config when not cross-compiling since some people may only have

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: ... --- hw/eepro100.c | 4 +--- 1 files

Re: [Qemu-devel] [PATCH] virtio-pci: thinko fix

2010-01-11 Thread Anthony Liguori
On 01/11/2010 09:57 AM, Michael S. Tsirkin wrote: Since patch ed757e140c0ada220f213036e4497315d24ca8bct, virtio will sometimes clear all status registers on bus master disable, which loses information such as VIRTIO_CONFIG_S_FAILED bit. This is a result of a patch being misapplied: code uses !

Re: [Qemu-devel] QMP forward compatibility support

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 12:57:15PM -0600, Anthony Liguori wrote: On 01/11/2010 12:34 PM, Luiz Capitulino wrote: Hi. We (Markus and I) are working on getting QMP forward compatibility support, supported. :) We have a plan for it and I'd like to ask the CC'ed people to review it.

[Qemu-devel] [PATCH 2/5] tcg-sparc: Implement add2, sub2, mulu2.

2010-01-11 Thread Richard Henderson
Add missing 32-bit double-word support opcodes. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/sparc/tcg-target.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 067e26e..6934580

[Qemu-devel] [PATCH 3/5] tcg-sparc: Do not remove %o[012] from 'r' constraint.

2010-01-11 Thread Richard Henderson
Only 'L' constraint needs that. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/sparc/tcg-target.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c index 6934580..8675fce 100644 --- a/tcg/sparc/tcg-target.c +++

[Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.

2010-01-11 Thread Richard Henderson
The {div,divu}2 opcodes are intended for systems for which the division instruction produces both quotient and remainder. Sparc is not such a system. Indeed, the remainder must be computed as quot = a / b rem = a - (quot * b) Split out a tcg_out_div32 function that properly initializes Y

[Qemu-devel] [PATCH 5/5] tcg-sparc: Implement ext32[su]_i64

2010-01-11 Thread Richard Henderson
The 32-bit right-shift instructions is defined to extend the shifted output to 64-bits. A shift count of zero therefore is a simple extension without actually shifting. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/sparc/tcg-target.c | 16 tcg/sparc/tcg-target.h |

Re: [Qemu-devel] [PATCH] [tftp] Handle TFTP ERROR from client

2010-01-11 Thread Anthony Liguori
On 01/07/2010 11:01 AM, Thomas Horsten wrote: If a PXE client only wants to find out the size of a file, it will open the file and then abort the transfer by sending a TFTP ERROR packet. The ERROR packet should cause qemu to terminate the session. If not, the sessions will soon run out and

Re: [Qemu-devel] [PATCH] pc-bios: Update README (SeaBIOS)

2010-01-11 Thread Anthony Liguori
On 01/07/2010 12:27 PM, Stefan Weil wrote: The PC BIOS no longer comes from Bochs. This patch updates the related entry. V2 - Modify SeaBIOS description and URL (Thanks to Gleb Natapov for the hint). Signed-off-by: Stefan Weilw...@mail.berlios.de Applied. Thanks. Regards,

Re: [Qemu-devel] [PATCHv7 1/3] qdev: add bit property type

2010-01-11 Thread Anthony Liguori
On 01/10/2010 05:52 AM, Michael S. Tsirkin wrote: This adds bit property type, which is a boolean stored in a 32 bit integer field, with legal values on and off. Will be used by virtio for feature bits. Signed-off-by: Michael S. Tsirkinm...@redhat.com Acked-by: Gerd Hoffmannkra...@redhat.com

Re: [Qemu-devel] [PATCH] dmg: fix -open failure

2010-01-11 Thread Anthony Liguori
On 01/11/2010 07:06 AM, Christoph Hellwig wrote: Currently the dmg image format driver simply opens the images as raw if any kind of failure happens. This is contrarty to the behaviour of all other image formats which just return an error and let the block core deal with it. Signed-off-by:

Re: [Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 07:16:42PM +0200, Michael S. Tsirkin wrote: Here's an untested patchset with vhost support for upstream qemu. Note that you should not expect performance gains from vhost unless in-kernel irqchip is enabled (which is not in upstream qemu now). Since adding vhost

Re: [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max

2010-01-11 Thread Anthony Liguori
On 01/07/2010 01:31 AM, Amit Shah wrote: VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in hw/virtio.h. Also, bump up the value of the maximum allowed virtqueues to 64. This is in preparation to allow multiple ports per virtio-console device. Signed-off-by: Amit

Re: [Qemu-devel] [PATCH 4/5] tcg-sparc: Implement division properly.

2010-01-11 Thread Richard Henderson
On 01/11/2010 11:09 AM, Richard Henderson wrote: +/* Load Y with the sign/zero extension of RS1 to 64-bits. */ +if (uns) { +tcg_out_sety(s, TCG_REG_G0); +} else { +tcg_out_arith(s, TCG_REG_I5, rs1, 31, SHIFT_SRA); Bah. tcg_out_arithi. Programming by code

Re: [Qemu-devel] [PATCH-RFC 00/13] vhost-net: preview

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 08:09:10PM +, Daniel P. Berrange wrote: On Mon, Jan 11, 2010 at 07:16:42PM +0200, Michael S. Tsirkin wrote: Here's an untested patchset with vhost support for upstream qemu. Note that you should not expect performance gains from vhost unless in-kernel irqchip is

[Qemu-devel] [PATCH] pci: Add missing 'const' in argument to pci_get_xxx

2010-01-11 Thread Stefan Weil
pci_get_byte, pci_get_word, pci_get_long and pci_get_quad all take a const uint8_t pointer, because they only read the configuration data. Their prototypes should reflect this fact. Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/pci.h | 14 +++--- 1 files changed, 7

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Stefan Weil
Michael S. Tsirkin schrieb: On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: ... -

[Qemu-devel] Re: [RFC] API change for pci_set_word and related functions

2010-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2010 at 09:18:51PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Mon, Jan 11, 2010 at 08:38:53PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010 at 04:07:26PM +0100, Stefan Weil wrote: Michael S. Tsirkin schrieb: On Thu, Jan 07, 2010

  1   2   >