[Qemu-devel] [RFC/ PATCH 0/2] qemu: Asynchronous task offloading framework.

2010-05-10 Thread Gautham R Shenoy
Hi, This patch series is strictly RFC only. It implements a generic asynchrnous task offloading threading framework based on the threading model used in the AIO subsystem. Currently within QEMU, AIO subsystem is the only one which creates a bunch of asynchronous threads to execute any blocking

[Qemu-devel] [RFC/ PATCH 1/2] qemu: Create a generic asynchronous threading framework to offload tasks

2010-05-10 Thread Gautham R Shenoy
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure. It's based on the threading framework that was being used by paio. The reason why the generic infrastructure has been extracted out of the posix-aio-compat.c is so

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-10 Thread Avi Kivity
On 05/09/2010 10:35 PM, Gerhard Wiesinger wrote: Please run kvm_stat and report output for both tests to confirm. See below. 2nd column is per second statistic when running the test. efer_reload 0 0 exits 18470836 554582 fpu_reload

[Qemu-devel] [PATCH v2] QMP: Add Downstream extension of QMP to spec

2010-05-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster arm...@redhat.com --- v2: Clarify use of __RFQDN (Thanks, Luiz!) QMP/qmp-spec.txt | 55 ++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt index

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-10 Thread Avi Kivity
On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus emulation as well. Here it triggers _always_ (including old versions of kvm) when running windows NT and hitting test button in its display resolution

[Qemu-devel] [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov g...@redhat.com --- Changelog: v1-v2: - free memory in case of vq initialization error. - change license of virtio ring/pci to LGPLv3 with permission of Laurent Vivier (aka the author).

[Qemu-devel] Re: Another SIGFPE in display code, now in cirrus

2010-05-10 Thread Avi Kivity
On 05/10/2010 10:41 AM, Avi Kivity wrote: On 05/06/2010 11:07 PM, Michael Tokarev wrote: There was a bug recently fixed in vnc code. Apparently there's something similar in the cirrus emulation as well. Here it triggers _always_ (including old versions of kvm) when running windows NT and

[Qemu-devel] Re: [SeaBIOS] [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Stefan Hajnoczi
Looks good. Stefan

Re: [Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Christoph Egger
On Sunday 09 May 2010 21:11:17 Alexander Graf wrote: Sebastian Herbszt wrote: The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
On Mon, May 10, 2010 at 09:25:20AM +0100, Stefan Hajnoczi wrote: diff --git a/src/virtio-blk.c b/src/virtio-blk.c new file mode 100644 index 000..a41c336 --- /dev/null +++ b/src/virtio-blk.c @@ -0,0 +1,155 @@ +// Virtio blovl boot support. Just noticed the blovl typo. +    

Re: [Qemu-devel] AHCI support integration

2010-05-10 Thread Christoph Egger
On Sunday 09 May 2010 18:01:50 Sebastian Herbszt wrote: The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split (or could be split) into

Re: [Qemu-devel] [PATCH 2/5] Add defines for PCI IDs.

2010-05-10 Thread Gerd Hoffmann
On 05/07/10 17:32, Blue Swirl wrote: On 5/7/10, Gerd Hoffmannkra...@redhat.com wrote: This patch allows to set PCI vendor and device IDs using defines (PCI_VID and PCI_DID). Use it for vgabios.bin. Signed-off-by: Gerd Hoffmannkra...@redhat.com --- Makefile |4 ++-- vbe.c

[Qemu-devel] [PATCHv3] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov g...@redhat.com --- Changelog: v1-v2: - free memory in case of vq initialization error. - change license of virtio ring/pci to LGPLv3 with permission of Laurent Vivier (aka the author).

Re: [Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-10 Thread Mark Cave-Ayland
Blue Swirl wrote: Thanks a lot, with this patch my tests passed! I applied the combined patch. Yes, I definitely see an improvement with this patch - at least my Debian lenny SPARC boot cd doesn't randomly kernel panic any more. It looks as if it now just can't find /init which could just

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an intermediate step to convert all users to explicit 'mon' passing. Thus, new APIs should not rely it. I just realized that

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Kevin Wolf
Am 07.05.2010 17:17, schrieb Christoph Hellwig: We don't have an equivalent to mmap in the qemu block API, so read and write the bitmap directly. At least in the dumb implementation added in this patch this is a lot less efficient, but it means cow can also work on windows, and over nbd or

Re: [Qemu-devel] Re: [PATCH] win32: Avoid compiler warning (WIN32_LEAN_AND_MEAN redefined)

2010-05-10 Thread Paolo Bonzini
3. Change the definition of WIN32_LEAN_AND_MEAN in configure/make. Solution 3 is a very simple change. It works for the moment, but would raise warnings when a library header file with a different definition of WIN32_LEAN_AND_MEAN is used. When I scanned the system headers of my mingw32

[Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Joerg Roedel
On Sun, May 09, 2010 at 09:11:17PM +0200, Alexander Graf wrote: Sebastian Herbszt wrote: The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread Kevin Wolf
Am 09.05.2010 12:17, schrieb Stefan Weil: Kevin and you are right, and my interpretation of disk_size was wrong. disk_size is not the size used for the blocks (then it would have to be large enough to keep all blocks). disk_size is the number of bytes which are really used for data (so it

Re: [Qemu-devel] [PATCH 2/3] dmg: use pread

2010-05-10 Thread Kevin Wolf
Am 07.05.2010 16:56, schrieb Christoph Hellwig: Use pread instead of lseek + read in preparation of using the qemu block API. Note that dmg actually uses the implicit file offset a lot in dmg_open, and we had to replace it with an offset variable. Signed-off-by: Christoph Hellwig

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an intermediate step to convert all users to explicit 'mon' passing. Thus, new APIs should not rely it. I just

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Stefan Hajnoczi
diff --git a/src/virtio-blk.c b/src/virtio-blk.c new file mode 100644 index 000..a41c336 --- /dev/null +++ b/src/virtio-blk.c @@ -0,0 +1,155 @@ +// Virtio blovl boot support. Just noticed the blovl typo. +        char *desc = malloc_tmphigh(MAXDESCSIZE); +        struct

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Christoph Hellwig
On Mon, May 10, 2010 at 11:41:15AM +0200, Kevin Wolf wrote: For one, there is a typo in the variable name, and also this is a void function which shouldn't return anything. The caller still seems to use the return value. Should probably stay an int function. Yes, this was missing a quilt

[Qemu-devel] Re: [PATCH v5 2/5] Support adding a file to qemu's ram allocation

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to map a host file into guest RAM. This function mmaps the opened file anywhere and adds the memory to the ram blocks. Usage is qemu_ram_mmap(fd, size, MAP_SHARED, offset);

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: Generic functions to assign irqfds and ioeventfds. Signoff. } #ifdef KVM_IOEVENTFD +int kvm_set_irqfd(int fd, uint16_t vector, uint32_t gsi) +{ +struct kvm_irqfd call = { }; +int r; + +call.fd = fd; +call.gsi = gsi;

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an intermediate step to convert all users to explicit 'mon' passing. Thus, new

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread chen huacai
--- a/hw/mips.h +++ b/hw/mips.h @@ -5,6 +5,9 @@  /* gt64xxx.c */  PCIBus *pci_gt64120_init(qemu_irq *pic); +/* bonito.c */ +PCIBus *bonito_init_2e(qemu_irq pic); +  /* ds1225y.c */  void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);  void ds1225y_set_protection(void

Re: [Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-10 Thread 乔崇
Alexander Graf 写道: Hi Chong, 乔崇 wrote: Alexander Graf 写道: Hi Chong (or Qiao? Which one is your first name?), Thanks your advice,My first name is Chong. Upfront - please don't top post. Top posting is when you write your reply

[Qemu-devel] [PATCH 1/1] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
ahci disk look up from IF_SCSI now. test a sata disk: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk test a sata cd: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 04/21/2010 08:53 PM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository.

[Qemu-devel] [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a little,then the cdrom

[Qemu-devel] [PATCH 1/1] add cdrom support for ahci.

2010-05-10 Thread QiaoChong
ahci disk look up from IF_SCSI now. test a sata disk: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,file=/tmp/disk test a sata cd: ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an intermediate step to convert all users to

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 14:23:05 +0200 Jan Kiszka jan.kis...@web.de wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Markus Armbruster
Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one day...). It's just an

[Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Luiz Capitulino
On Mon, 10 May 2010 12:59:47 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Fri, 07 May 2010 16:21:13 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Fri, 07 May 2010 13:45:03 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Hi

Re: [Qemu-devel] Missing mon in monitor_cur_is_qmp() and qerror_report()

2010-05-10 Thread Jan Kiszka
Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: Luiz, I missed this when the API was first proposed: cur_mon is scheduled for removal (one

Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Avi Kivity
On 05/10/2010 01:59 PM, Jan Kiszka wrote: From a quick glance at the JSON spec, there is no room for a new type. I think we have to overload an existing one and convert that into a QBuffer (typically, we know the actual semantic). Hex string encoding is most compact, so I went this road.

Re: [Qemu-devel] Re: ehci fixes

2010-05-10 Thread Vincent Palatin
On Sun, 09 May 2010 20:36:03 -0600 David S. Ahern daah...@cisco.com wrote: While using the EHCI patchset, I have found 2 minor issues. So, I send in this email thread 2 fix proposals. Changes look good to me. Are you looking at any particular device or EHCI in general? I'm just using

Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Jan Kiszka
Avi Kivity wrote: On 05/10/2010 01:59 PM, Jan Kiszka wrote: From a quick glance at the JSON spec, there is no room for a new type. I think we have to overload an existing one and convert that into a QBuffer (typically, we know the actual semantic). Hex string encoding is most compact, so I

[Qemu-devel] [PATCH 1/2] ehci: Fix error detection when registering a new list base address

2010-05-10 Thread Vincent Palatin
We must check against the current running command not the list address. Signed-off-by: Vincent Palatin vincent.palatin_q...@m4x.org --- hw/usb-ehci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index 8be0780..e724653 100644 ---

[Qemu-devel] ehci fixes

2010-05-10 Thread Vincent Palatin
Dear developers, While using the EHCI patchset, I have found 2 minor issues. So, I send in this email thread 2 fix proposals. Those patches apply on top of the Jan Kiszka's ehci branch. Thanks to Jan and David for gathering and updating this patchset. -- Vincent

[Qemu-devel] [PATCH 2/2] ehci: Fix debug traces

2010-05-10 Thread Vincent Palatin
- fix build error when activating traces - properly display the config flags register Signed-off-by: Vincent Palatin vincent.palatin_q...@m4x.org --- hw/usb-ehci.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index e724653..ab9a23e

[Qemu-devel] qemu-system-arm use for bootloader running

2010-05-10 Thread Belisko Marek
Hi, I'm working on eol bootloader (http://vivien.chappelier.free.fr/typhoon/release/eol/20070609/eol-0.5.tar.gz) This bootloader was written to load kernel image from sd card in SPL mode for htc phones (omap 730, omap 850) to no start WINCE but you can choose what to load. First of all I would

[Qemu-devel] Re: AHCI support integration

2010-05-10 Thread Tejun Heo
Hello, On 05/09/2010 09:11 PM, Alexander Graf wrote: Sebastian Herbszt wrote: The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split (or

Re: [Qemu-devel] Re: Registering buffers with a qdict

2010-05-10 Thread Avi Kivity
On 05/10/2010 04:43 PM, Jan Kiszka wrote: Avi Kivity wrote: On 05/10/2010 01:59 PM, Jan Kiszka wrote: From a quick glance at the JSON spec, there is no room for a new type. I think we have to overload an existing one and convert that into a QBuffer (typically, we know the actual

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-10 Thread Shin-ichiro KAWASAKI
Hello, Rob, This mail might be too late, but I want to report you that I encountered similar trouble. Using the linux kernel after the following commit, the qemu-sh serial console shows no output. cd5f107628ab89c5dec5ad923f1c27f4cba41972 This trouble was discussed in sh-linux ML.

[Qemu-devel] KVM call agenda for May 11

2010-05-10 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 4:43 AM, Avi Kivity a...@redhat.com wrote: On 04/21/2010 08:53 PM, Cam Macdonell wrote: Generic functions to assign irqfds and ioeventfds. Signoff.  }  #ifdef KVM_IOEVENTFD +int kvm_set_irqfd(int fd, uint16_t vector, uint32_t gsi) +{ +    struct kvm_irqfd call

[Qemu-devel] Re: [PATCH v5 3/5] Add functions for assigning ioeventfd and irqfds.

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:13 PM, Cam Macdonell wrote: +int kvm_set_ioeventfd_mmio_long(int fd, uint32_t addr, uint32_t val, bool assign) +{ + +int ret; +struct kvm_ioeventfd iofd; + +iofd.datamatch = val; +iofd.addr = addr; +iofd.len = 4; +iofd.flags =

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 5:59 AM, Avi Kivity a...@redhat.com wrote: On 04/21/2010 08:53 PM, Cam Macdonell wrote: Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest.  This patch also supports interrupts between guest by communicating over a

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's shared memory region fd */ +if (incoming_posn == -1) { + +s-num_eventfds = 0; + +if (check_shm_size(s, incoming_fd) == -1) { +exit(-1); +} + +/* creating a

[Qemu-devel] Re: [PATCH v5 2/5] Support adding a file to qemu's ram allocation

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 4:39 AM, Avi Kivity a...@redhat.com wrote: On 04/21/2010 08:53 PM, Cam Macdonell wrote: This avoids the need of using qemu_ram_alloc and mmap with MAP_FIXED to map a host file into guest RAM.  This function mmaps the opened file anywhere and adds the memory to the

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 10:28 AM, Avi Kivity wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's shared memory region fd */ +if (incoming_posn == -1) { + +s-num_eventfds = 0; + +if (check_shm_size(s, incoming_fd) == -1) { +

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 9:28 AM, Avi Kivity a...@redhat.com wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +    /* if the position is -1, then it's shared memory region fd */ +    if (incoming_posn == -1) { + +        s-num_eventfds = 0; + +        if (check_shm_size(s,

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Anthony Liguori
On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapovg...@redhat.com A related problem that I think we need to think about how we solve is indicating to Seabios which device we want to boot from

Re: [Qemu-devel] qemu-system-sh4 broken again.

2010-05-10 Thread Aurelien Jarno
Shin-ichiro KAWASAKI a écrit : Hello, Rob, This mail might be too late, but I want to report you that I encountered similar trouble. Using the linux kernel after the following commit, the qemu-sh serial console shows no output. cd5f107628ab89c5dec5ad923f1c27f4cba41972 This

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Gleb Natapov
On Mon, May 10, 2010 at 10:48:42AM -0500, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapovg...@redhat.com A related problem that I think we need to think about how we

[Qemu-devel] Re: [PATCHv2] Support for booting from virtio disks

2010-05-10 Thread Anthony Liguori
On 05/10/2010 10:54 AM, Gleb Natapov wrote: On Mon, May 10, 2010 at 10:48:42AM -0500, Anthony Liguori wrote: On 05/10/2010 03:11 AM, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapovg...@redhat.com A

[Qemu-devel] Re: [PATCH] virtio: invoke set_features on load

2010-05-10 Thread David Stevens
Michael S. Tsirkin m...@redhat.com wrote on 05/09/2010 09:42:09 AM: After migration, vhost was not getting features acked because set_features callback was never invoked. The fix is just to invoke that callback. Reported-by: David L Stevens dlstev...@us.ibm.com Signed-off-by: Michael S.

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 9:38 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/10/2010 10:28 AM, Avi Kivity wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +    /* if the position is -1, then it's shared memory region fd */ +    if (incoming_posn == -1) { + +        

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the the handshake completed? I think it would disappear. But, the BAR isn't there until the handshake is completed. Only after receiving the shared memory fd does my device call

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 10:40 AM, Avi Kivity a...@redhat.com wrote: On 05/10/2010 06:41 PM, Cam Macdonell wrote: What would happen to any data written to the BAR before the the handshake completed?  I think it would disappear. But, the BAR isn't there until the handshake is completed.  Only

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 11:20 AM, Cam Macdonell wrote: On Mon, May 10, 2010 at 9:38 AM, Anthony Liguorianth...@codemonkey.ws wrote: On 05/10/2010 10:28 AM, Avi Kivity wrote: On 05/10/2010 06:22 PM, Cam Macdonell wrote: + +/* if the position is -1, then it's

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Avi Kivity
On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory. This is what I did before the qemu_ram_mmap() function was added. What would happen to any data written to the BAR before the the

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread Stefan Weil
Am 10.05.2010 13:21, schrieb chen huacai: --- a/hw/mips.h +++ b/hw/mips.h @@ -5,6 +5,9 @@ /* gt64xxx.c */ PCIBus *pci_gt64120_init(qemu_irq *pic); +/* bonito.c */ +PCIBus *bonito_init_2e(qemu_irq pic); + /* ds1225y.c */ void *ds1225y_init(target_phys_addr_t mem_base, const char *filename);

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory. This is what I did before the qemu_ram_mmap() function was added. What would happen to any

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 05/03/2010 08:06 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: We need to expose errno in QMP, for three reasons: 1. Some error handling functions print errno codes to the user, while it's

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 11:25 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during initialization, I would have to use MAP_FIXED to mmap the memory.  This is what I

Re: [Qemu-devel] [PATCH 1/2] qemu-error: Introduce get_errno_name()

2010-05-10 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Tue, 04 May 2010 16:56:19 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/04/2010 03:30 PM, Luiz Capitulino wrote: StateVmSaveFailed is not like CommandFailed, there are five errors in do_savevm() and StateVmSaveFailed happens

Re: [Qemu-devel] [PATCH 07/22] qemu-error: Introduce get_errno_string()

2010-05-10 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 04/21/2010 03:28 AM, Daniel P. Berrange wrote: On Tue, Apr 20, 2010 at 06:09:37PM -0300, Luiz Capitulino wrote: [...] Wouldn't it be nicer to return strerror_r() output instead of errno names ? Both are equally wrong :-) QMP should

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Anthony Liguori
On 05/10/2010 12:43 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 11:25 AM, Anthony Liguorianth...@codemonkey.ws wrote: On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori wrote: Otherwise, if the BAR is allocated during

[Qemu-devel] Re: [PATCH v5 4/5] Inter-VM shared memory PCI device

2010-05-10 Thread Cam Macdonell
On Mon, May 10, 2010 at 11:52 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 05/10/2010 12:43 PM, Cam Macdonell wrote: On Mon, May 10, 2010 at 11:25 AM, Anthony Liguorianth...@codemonkey.ws  wrote: On 05/10/2010 11:59 AM, Avi Kivity wrote: On 05/10/2010 06:38 PM, Anthony Liguori

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-10 Thread Blue Swirl
On 5/10/10, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/9/10, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote: On the real

Re: [Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-10 Thread Blue Swirl
On 5/10/10, Mark Cave-Ayland mark.cave-ayl...@siriusit.co.uk wrote: Blue Swirl wrote: Thanks a lot, with this patch my tests passed! I applied the combined patch. Yes, I definitely see an improvement with this patch - at least my Debian lenny SPARC boot cd doesn't randomly kernel panic

[Qemu-devel] [RFC] default mac address issue

2010-05-10 Thread Bruce Rogers
I know this behavior has worked this way all along, but I wanted to bring up the following concern and float a few ideas about possible solutions. Please provide your perspective, opinion, etc. qemu (or qemu-kvm) users can easily get into trouble when they don't specifying the mac address for

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of bonito north bridge used by fulong mini pc Signed-off-by: Huacai Chen zltjiang...@gmail.com - diff --git a/Makefile.target b/Makefile.target index c092900..fc4c59f 100644 --- a/Makefile.target

Re: [Qemu-devel] [RFC][MIPS][PATCH 2/6] Initial support of vt82686b south bridge used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of vt82686b south bridge used by fulong mini pc Signed-off-by: Huacai Chen zltjiang...@gmail.com - diff --git a/Makefile.target b/Makefile.target index fc4c59f..08968d6 100644 --- a/Makefile.target

Re: [Qemu-devel] [RFC] default mac address issue

2010-05-10 Thread Anthony Liguori
Hi Bruce, On 05/10/2010 02:07 PM, Bruce Rogers wrote: I know this behavior has worked this way all along, but I wanted to bring up the following concern and float a few ideas about possible solutions. Please provide your perspective, opinion, etc. qemu (or qemu-kvm) users can easily get into

Re: [Qemu-devel] [RFC][MIPS][PATCH 3/6] Initial support of VIA IDE controller used by fulong mini pc

2010-05-10 Thread Blue Swirl
On 5/9/10, chen huacai zltjiang...@gmail.com wrote: This patch add initial support of VIA IDE controller used by fulong mini pc Signed-off-by: Huacai Chen zltjiang...@gmail.com - diff --git a/Makefile.objs b/Makefile.objs index ecdd53e..75be9ce 100644 --- a/Makefile.objs +++

Re: [Qemu-devel] [PATCH] sh: sm501: add 2D engine support

2010-05-10 Thread Blue Swirl
On 5/9/10, Shin-ichiro KAWASAKI kawas...@juno.dti.ne.jp wrote: In linux kernel v2.6.33, sm501 frame buffer driver modified to support 2D graphics engine on sm501 chip. One example is fill rectangle operation. But current qemu's sm501 emulation doesn't support it. This results in graphics

[Qemu-devel] [PATCH] block/vpc: Fix conversion from size to disk geometry

2010-05-10 Thread Stefan Weil
The VHD algorithm calculates a disk geometry which is usually smaller than the requested size. QEMU tried to round up but failed for certain sizes: qemu-img create -f vpc disk.vpc 9437184 would create an image with 9435136 bytes (which is too small for qemu-img convert). Instead of hacking the

[Qemu-devel] [PATCH] Compile virtio-9p-debug and virtio-9p-local once

2010-05-10 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- Makefile.objs |2 ++ Makefile.target |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index ecdd53e..110f8fd 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -226,6 +226,8 @@

[Qemu-devel] Print input opcodes before translation

2010-05-10 Thread John Vele
Greetings, I'm using qemu user mode for i386 and I would like to print the opcodes of an input executable one bye one before any translation. Is the file target-i386/translate.c the one that I shall edit? The function disas_insn() in the same file is the appropriate one? Thanx in advance

Re: [Qemu-devel] Print input opcodes before translation

2010-05-10 Thread Blue Swirl
On 5/10/10, John Vele jve...@gmail.com wrote: Greetings, I'm using qemu user mode for i386 and I would like to print the opcodes of an input executable one bye one before any translation. Is the file target-i386/translate.c the one that I shall edit? The function disas_insn() in the same

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2010-05-10 Thread Anthony Liguori
On 04/18/2010 02:21 PM, Shahar Havivi wrote: Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the structure handled by qemu tail queue. Adding a new keyboard add to the list and select it, removing keyboard select the previous keyboard in list. Signed-off-by: Shahar

Re: [Qemu-devel] [PATCH 1/4] doc: Fix host forwarding monitor command documentation

2010-05-10 Thread Anthony Liguori
On 05/04/2010 06:20 AM, Markus Armbruster wrote: Commit f3546deb replaced host_net_redir by hostfwd_add, hostfwd_remove, but neglected to update documentation. Signed-off-by: Markus Armbrusterarm...@redhat.com Applied all. Thanks. Regards, Anthony Liguori --- qemu-monitor.hx | 13

Re: [Qemu-devel] [PATCH] iov: Move from hw/ to topdir

2010-05-10 Thread Anthony Liguori
On 05/04/2010 06:09 AM, Amit Shah wrote: The iov functions can be useful to other code as well. Signed-off-by: Amit Shahamit.s...@redhat.com CC: Christoph Hellwigh...@lst.de Applied. Thanks. Regards, Anthony Liguori --- hw/iov.c = iov.c |0 hw/iov.h = iov.h |0 2 files

Re: [Qemu-devel] [PATCH 1/5] SCSI: Add disk reset handler

2010-05-10 Thread Anthony Liguori
On 05/04/2010 07:20 AM, Jan Kiszka wrote: Ensure that pending requests of an SCSI disk are purged on system reset and also restore max_lba. The latter is no only present in the reset handler as that one is called after init as well. Signed-off-by: Jan Kiszkajan.kis...@siemens.com Applied

[Qemu-devel] [PATCH 6/6] virtio-9p: Implemented Security model for lstat and fstat

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p-local.c | 67 +++--- 1 files changed, 63 insertions(+), 4 deletions(-) diff --git a/hw/virtio-9p-local.c b/hw/virtio-9p-local.c index 89b17f0..529de73 100644 ---

[Qemu-devel] [PATCH 4/6] virtio-9p: Implement Security model for mknod related files

2010-05-10 Thread Venkateswararao Jujjuri (JV)
In the mapped security model all the special files are created as regular files on the fileserver and appropriate mode bits are added to the extended attributes. These extended attributes are used to present this file as special file to the client. Signed-off-by: Venkateswararao Jujjuri

Re: [Qemu-devel] [PATCH] fix migration with large mem

2010-05-10 Thread Anthony Liguori
On 04/13/2010 04:33 AM, Izik Eidus wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidusiei...@redhat.com Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PATCH] fix migration with large mem In cases of guests with large mem that have pages that all

[Qemu-devel] [PATCH 1/6] virtio-9p: Introduces an option to specify the security model.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
The new option is: -fsdev local,id=jvrao,path=/tmp/,security_model=[mapped|passthrough] -virtfs local,path=/tmp/,security_model=[mapped|passthrough],mnt_tag=v_tmp. In the case of mapped security model, files are created with QEMU user credentials and the client-user's credentials are saved in

[Qemu-devel] [PATCH 2/6] virtio-9p: Rearrange fileop structures

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c | 185 ++-- hw/virtio-9p.h | 92 2 files changed, 138 insertions(+), 139 deletions(-) diff --git a/hw/virtio-9p.c

[Qemu-devel] [PATCH 5/6] virtio-9p: Implemented security model for symlink and link.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/file-op-9p.h |4 +- hw/virtio-9p-local.c | 74 + hw/virtio-9p.c | 24 +++- 3 files changed, 75 insertions(+), 27 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 0/1] [RFC][AHCI] add cdrom support for ahci.

2010-05-10 Thread Alexander Graf
Hi Chong, On 10.05.2010, at 13:55, QiaoChong wrote: When ahci init ,driver will send ATA_SRST command,ahci device report device type through port's sig register. Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not support cdrom media. I just copy ide_atapi_cmd from

[Qemu-devel] [PATCH 0/6] virtio-9p:Introducing security model for VirtFS

2010-05-10 Thread Venkateswararao Jujjuri (JV)
This patch series introduces the security model for VirtFS. Brief description of this patch series. It introduces two type of security models for VirtFS. They are: mapped and passthrough. The following is common to both security models. * Client's VFS determines/enforces the access control.

Re: [Qemu-devel] [PATCH 2/3] dmg: use pread

2010-05-10 Thread Christoph Hellwig
On Mon, May 10, 2010 at 12:07:40PM +0200, Kevin Wolf wrote: -info_begin=read_off(s-fd); -if(info_begin==0) - goto fail; -if(lseek(s-fd,info_begin,SEEK_SET)0) - goto fail; We seek to info_begin. -if(read_uint32(s-fd)!=0x100) - goto fail; Now we are at

[Qemu-devel] [PATCH 3/6] virtio-9p: modify create/open2 and mkdir for new security model.

2010-05-10 Thread Venkateswararao Jujjuri (JV)
Add required infrastructure and modify create/open2 and mkdir per the new security model. Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/file-op-9p.h | 23 +- hw/virtio-9p-local.c | 117 + hw/virtio-9p.c

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-10 Thread François Revol
Le Mon, 10 May 2010 22:12:33 +0200, Stefan Weil a écrit : The fix is based on a patch from Kevin Wolf. Here his comment: The number of blocks needs to be rounded up to cover all of the virtual hard disk. Without this fix, we can't even open our own images if their size is not a multiple of

  1   2   >