On Fri, Jun 4, 2010 at 4:41 PM, Paolo Bonzini pbonz...@redhat.com wrote:
+ vnc_lock_queue(queue);
+ if (QTAILQ_EMPTY(queue-jobs)) {
+ qemu_cond_wait(queue-cond,queue-mutex);
+ }
+
+ /* If the queue is empty, it's an exit order */
+ if (QTAILQ_EMPTY(queue-jobs)) {
+
Paul Brook p...@codesourcery.com writes:
Also require IDs to start with a letter to provide for possible future
extensions.
I'd go further than that, and require that user specified IDs match
[A-Za-z][A-Za-z0-9_-]*
I talked with Dan (cc'ed) to make sure we don't trample on existing
libvirt
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
console.h | 72 +++
hw/xenfb.c |2 +-
vl.c |9 ++-
3 files changed, 42 insertions(+), 41 deletions(-)
diff --git a/console.h b/console.h
index cac959f..3a80dca 100644
Negative four byte displacements need to be sign-extended after
c086b783eb7a578993d6d2ab62c4c2666800b63d. Do so.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
There are quite a few other ldl's to audit after the patch
(about 70 in target-*). Any volunteers? :-)
Aneesh Kumar K. V wrote:
On Thu, 3 Jun 2010 18:29:02 +0530, Sripathi Kodi sripat...@in.ibm.com wrote:
On Wed, 02 Jun 2010 19:49:24 +0530
Aneesh Kumar K. V aneesh.ku...@linux.vnet.ibm.com wrote:
On Fri, 28 May 2010 16:08:43 +0530, Sripathi Kodi sripat...@in.ibm.com
wrote:
From: M. Mohan
On 04.06.2010, at 15:20, Corentin Chary wrote:
Implement a threaded VNC server using the producer-consumer model.
The main thread will push encoding jobs (a list a rectangles to update)
in a queue, and the VNC worker thread will consume that queue and send
framebuffer updates to the output
On Fri, Jun 4, 2010 at 3:25 PM, Alexander Graf ag...@suse.de wrote:
On 04.06.2010, at 15:20, Corentin Chary wrote:
Implement a threaded VNC server using the producer-consumer model.
The main thread will push encoding jobs (a list a rectangles to update)
in a queue, and the VNC worker thread
+vnc_lock_queue(queue);
+if (QTAILQ_EMPTY(queue-jobs)) {
+qemu_cond_wait(queue-cond,queue-mutex);
+}
+
+/* If the queue is empty, it's an exit order */
+if (QTAILQ_EMPTY(queue-jobs)) {
+vnc_unlock_queue(queue);
+return -1;
+}
+
+job =
On 06/04/2010 04:55 PM, Corentin Chary wrote:
Because it's not in a loop ? Like I said in the cover-letter (but this
should probably be in a comment here) you can't use multiple worker
on a single queue because of zlib streams. But if the issue is more a
style issue than the actual
On 06/03/2010 11:47 PM, Jes Sorensen wrote:
On 06/03/10 22:58, Richard Henderson wrote:
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote:
+/*
+ * Duplicate definition from vl.c to avoid messing up the entire build
+ */
+enum {
+#define DEF(option, opt_arg, opt_enum, opt_help,
On 06/04/2010 06:24 AM, jes.soren...@redhat.com wrote:
---
Makefile.objs |2 ++
os-posix.c| 19 +++
os-win32.c| 10 ++
sysemu.h |1 +
vl.c | 19 +++
5 files changed, 35 insertions(+), 16 deletions(-)
Looks like
Paul Brook p...@codesourcery.com writes:
Also require IDs to start with a letter to provide for possible future
extensions.
I'd go further than that, and require that user specified IDs match
[A-Za-z][A-Za-z0-9_-]*
I talked with Dan (cc'ed) to make sure we don't trample on existing
On 06/04/10 16:49, Richard Henderson wrote:
On 06/03/2010 11:47 PM, Jes Sorensen wrote:
The problem is that it requires qemu-options.h to be included, which
isn't included per default for all the files. If I put it into sysemu.h
at least it's going to require making every .c file build with
This patch implements the kernel part of readdir() implementation for 9p2000.L
Change from V3: Instead of inode, server now sends qids for each dirent
SYNOPSIS
size[4] Treaddir tag[2] fid[4] offset[8] count[4]
size[4] Rreaddir tag[2] count[4] data[count]
DESCRIPTION
On 06/04/2010 08:17 AM, Alexander Graf wrote:
On 04.06.2010, at 15:18, Corentin Chary wrote:
The lossless option can be used to force lossless compression
by disabling all lossy encodings like gradient or jpeg.
I think this should be reverse. Be lossless by default, but have a lossy
From: Jes Sorensen jes.soren...@redhat.com
Introduce OS specific cmdline argument handling by calling
os_parse_cmd_args() at the end of switch() statement. Move option
enum to qemu-options.h and have it included from os-posix.c and
os-win32.c in addition to vl.c.
In addition move SMB argument to
Kill nographic timer. Have a global gui_timer instead. Have the gui
timer enabled unconditionally. We need a timer running anyway for mmio
flush, so the whole have-gui-timer-only-when-needed logic is pretty
pointless. It also simplifies displaylisteners coming and going at
runtime, we don't
From: Jes Sorensen jes.soren...@redhat.com
This introduces os-win32.c. It is meant to carry win32 specific
functions thata are not relevant for all of QEMU as well as win32
versions of various pieces like signal handling etc.
Move win32 polling handler helper functions from vl.c to os-win32.c
On 06/04/2010 08:16 AM, Alexander Graf wrote:
On 04.06.2010, at 15:18, Corentin Chary wrote:
Disable JPEG compression by default and only enable it if the
VNC client has sent the requested quality.
Signed-off-by: Corentin Charycorenti...@iksaif.net
---
vnc.c |2 +-
1 files changed, 1
Ryan Harper wrote:
* Kay Sievers kay.siev...@vrfy.org [2010-06-03 15:06]:
On Thu, Jun 3, 2010 at 22:01, Ryan Harper ry...@us.ibm.com wrote:
* Kay Sievers kay.siev...@vrfy.org [2010-06-03 14:53]:
On Thu, Jun 3, 2010 at 21:07, Ryan Harper ry...@us.ibm.com wrote:
Use the 'VBID' virtio-blk ioctl
From: Jes Sorensen jes.soren...@redhat.com
vl.c: netinet/in.h is already included once above for the
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
vl.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index 417554f..7c4298a 100644
--- a/vl.c
+++
On Mon, May 24, 2010 at 09:19:34AM -0700, Nathan Froyd wrote:
This patch series adds support for the microMIPS ASE. microMIPS is a
new ASE similar to MIPS16, but re-encodes the entire instruction set
into 16-bit and 32-bit instructions--in contrast to MIPS16, which
re-encodes only integer
Kevin Wolf kw...@redhat.com writes:
Am 04.06.2010 16:16, schrieb Markus Armbruster:
Discussion with Christoph and Kevin uncovered yet another issue:
protocols. I find it pretty confusing, but let me try to describe it
anyway; Christoph and Kevin, please correct my errors.
A host block
i want to know how dyngen tool is incorporated in QEMU source code?? does mips
folder in TCG directory do same work for MIPS 64??
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Ok third time lucky ... I hope! This fixes the missing git add on
qemu-options.h as building for win32 using mingw (thanks Paolo!).
The patches try to clean up the vl.c code by separating out OS
specific code into OS specific files. Basically it is
From: Jes Sorensen jes.soren...@redhat.com
Rename qemu-options.h to qemu-options.def as it is not a header file
for general use and this leaves space for a proper qemu-options.h
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile.objs |4 ++--
vl.c |6 +++---
2
From: Jes Sorensen jes.soren...@redhat.com
Move code to handle runas, ie. change of user id of QEMU process
to OS specific files and provide dummy stub for Win32.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 28
qemu-os-posix.h |1
From: Jes Sorensen jes.soren...@redhat.com
Rename os_setup_signal_handling() to os_setup_early_signal_handling()
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c |2 +-
os-win32.c |2 +-
sysemu.h |2 +-
vl.c |2 +-
4 files changed, 4 insertions(+), 4
From: Jes Sorensen jes.soren...@redhat.com
Move chroot handling to OS specific files.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 19 +++
qemu-os-posix.h |1 +
qemu-os-win32.h |1 +
vl.c| 18 +-
4 files
From: Jes Sorensen jes.soren...@redhat.com
This moves the win32 and POSIX versions of find_datadir() to OS
specific files, and removes some #ifdef clutter from vl.c
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 64 +++
os-win32.c |
From: Jes Sorensen jes.soren...@redhat.com
This introduces os-win32.c. It is meant to carry win32 specific
functions thata are not relevant for all of QEMU as well as win32
versions of various pieces like signal handling etc.
Move win32 polling handler helper functions from vl.c to os-win32.c
From: Jes Sorensen jes.soren...@redhat.com
Move line-buffering setup to OS specific files.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c |5 +
qemu-os-posix.h |1 +
qemu-os-win32.h |2 ++
vl.c|5 +
4 files changed, 9 insertions(+), 4
From: Jes Sorensen jes.soren...@redhat.com
Move handling to change process name to POSIX specific files
plus add a better error message to cover the case where the
feature isn't supported.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 24
From: Jes Sorensen jes.soren...@redhat.com
Move main signal handler setup to os specific files.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 27 +++
qemu-os-posix.h |2 ++
qemu-os-win32.h |3 +++
vl.c| 33
From: Jes Sorensen jes.soren...@redhat.com
Move daemonize handling from vl.c to OS specific files. Provide dummy
stubs for Win32.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c | 102
os-win32.c |5 +++
From: Jes Sorensen jes.soren...@redhat.com
vl.c: netinet/in.h is already included once above for in the generic
POSIX section.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
vl.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/vl.c b/vl.c
index 417554f..7c4298a
On 06/04/2010 07:27 AM, Paolo Bonzini wrote:
Negative four byte displacements need to be sign-extended after
c086b783eb7a578993d6d2ab62c4c2666800b63d. Do so.
Acked-by: Richard Henderson r...@twiddle.net
There are quite a few other ldl's to audit after the patch
(about 70
Am 04.06.2010 17:53, schrieb Markus Armbruster:
Kevin Wolf kw...@redhat.com writes:
Am 04.06.2010 16:16, schrieb Markus Armbruster:
Our abstraction for formats is struct BlockDriver.
Our abstraction for protocols is also struct BlockDriver. Except for
the special protocol file, but that's
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/ide/core.c | 32 +---
1 files changed, 17 insertions(+), 15 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index
From: Jes Sorensen jes.soren...@redhat.com
Introduce OS specific cmdline argument handling by calling
os_parse_cmd_args() at the end of switch() statement. Move option
enum to qemu-options.h and have it included from os-posix.c and
os-win32.c in addition to vl.c.
In addition move SMB argument to
From: Jes Sorensen jes.soren...@redhat.com
Create qemu-os-win32.h for WIN32 specific declarations. Move polling
handling declaration into this file from sysemu.h
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-os-win32.h | 43 +++
sysemu.h
From: Jes Sorensen jes.soren...@redhat.com
Clean up virtio-blk.c to be more consistent using BDRV_SECTOR_SIZE
instead of hard coded 512 values.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/virtio-blk.c |7 ---
1 files changed, 4
From: Markus Armbruster arm...@redhat.com
parse_string() qemu_strdup()s the property value. It is never freed.
It needs to be freed along with the device. Otherwise, the value of
scsi-disk property ver gets leaked when hot-unplugging the disk, for
instance.
Call new PropertyInfo method free()
From: Jes Sorensen jes.soren...@redhat.com
Move win32 early signal handling setup to os_setup_signal_handling()
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-win32.c | 29 +
qemu-os-posix.h |2 --
sysemu.h|2 ++
vl.c|
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/ide/cmd646.c |4 ++--
hw/ide/core.c | 30 ++
hw/ide/internal.h |5 +++--
hw/ide/isa.c|2 +-
From: Markus Armbruster arm...@redhat.com
Show the actual default value instead of null when the property has
not been set.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/ide/qdev.c |3 +++
1 files changed, 3 insertions(+), 0
From: Jes Sorensen jes.soren...@redhat.com
Clean up block.c and use BDRV_SECTOR_SIZE rather than hard coded
numbers (512) when referring to sector size throughout the code.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 13
From: Jes Sorensen jes.soren...@redhat.com
os_change_process_uid() and os_change_root() are now only called
from os-posix.c, so no need to keep win32 stubs for them.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-posix.c |8
qemu-os-posix.h |2 --
From: Markus Armbruster arm...@redhat.com
Commit 428c149b added IDEState member conf to let commit 0009baf1 find
the BlockConf from there. It exists only for qdev drives, created via
ide_drive_initfn(), not for drives created via ide_init2().
But for a qdev drive, we can just as well reach its
From: Markus Armbruster arm...@redhat.com
Show the actual default value instead of null when the property has
not been set.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c |7 +--
1 files changed, 5 insertions(+), 2
From: Markus Armbruster arm...@redhat.com
IDEState members drive_serial_str and version are now left empty until
an actual drive is connected. Before, they got a default value that
was overwritten when a drive got connected. Doesn't matter, because
they're used only while a drive is connected.
From: Markus Armbruster arm...@redhat.com
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 17
From: Jes Sorensen jes.soren...@redhat.com
Move host_main_loop_wait() to OS specific files. Create
qemu-os-posix.h and provide empty inline for the POSIX case.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
os-win32.c | 43 +++
From: Markus Armbruster arm...@redhat.com
It needs to be a qdev property, because it belongs to the drive's
guest part.
Bonus: info qtree now shows the serial number.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/ide/core.c | 11
From: Markus Armbruster arm...@redhat.com
Unused since commit 751c6a17.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
sysemu.h |1 -
vl.c |2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/sysemu.h b/sysemu.h
From: Markus Armbruster arm...@redhat.com
Unused since commit 9dfd7c7a.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
sysemu.h |1 -
vl.c |1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/sysemu.h b/sysemu.h
From: Jes Sorensen jes.soren...@redhat.com
In bdrv_open() there is no need to shift total_size 9 just to
multiply it by 512 again just a few lines later, since this is the
only place the variable is used.
Mask with BDRV_SECTOR_MASK to protect against case where we are
passed a corrupted image.
On Fri, Jun 04, 2010 at 08:51:12AM -0700, Nathan Froyd wrote:
On Mon, May 24, 2010 at 09:19:34AM -0700, Nathan Froyd wrote:
This patch series adds support for the microMIPS ASE. microMIPS is a
new ASE similar to MIPS16, but re-encodes the entire instruction set
into 16-bit and 32-bit
The truncate and getlength commands passed a negative error number to strerror.
They also happen to be the two functions that are lacking a newline at the end
of their error message.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-io.c |4 ++--
1 files changed, 2 insertions(+), 2
Am 03.06.2010 21:52, schrieb Miguel Di Ciurcio Filho:
Both bdrv_can_snapshot() and bdrv_has_snapshot() does not work as advertized.
First issue: Their names implies different porpouses, but they do the same
thing
and have exactly the same code. Maybe copied and pasted and forgotten?
The following changes since commit 358c360feb346dff8f911e2d1dbcdd6319393f1d:
Anthony Liguori (1):
Merge remote branch 'kwolf/for-anthony' into staging
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Jes Sorensen (4):
Cleanup: bdrv_open() no
From: Markus Armbruster arm...@redhat.com
Unused since commit b3e461d3.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
vl.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 9283469..76a9b25 100644
qemu -cdrom /dev/cdrom with an empty CD-ROM drive doesn't work any more because
we try to guess the format and when this fails (because there is no medium) we
exit with an error message.
This patch should restore the old behaviour by assuming raw format for such
drives.
Signed-off-by: Kevin Wolf
This adds test cases for qcow2 error paths (using blkdebug)
Signed-off-by: Kevin Wolf kw...@redhat.com
---
026 | 192 ++
026.out | 558 +++
group |1 +
3 files changed, 751 insertions(+), 0 deletions(-)
From: Markus Armbruster arm...@redhat.com
To pave the way for moving it out of vl.c.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/device-hotplug.c |2 +-
hw/usb-msd.c|2 +-
sysemu.h|3 ++-
vl.c
From: Jes Sorensen jes.soren...@redhat.com
Clean up raw-posix.c to be more consistent using BDRV_SECTOR_SIZE
instead of hard coded 512 values.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/raw-posix.c | 20 +++-
1
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/ide/internal.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/ide/internal.h b/hw/ide/internal.h
index 2efc784..b4554ce
2010/5/27 Bob Breuer breu...@mc.net:
+ /* DBRI (audio) */
+ cpu_register_physical_memory_offset(0xEE0001000ULL, 0x1, bad_mem,
0xE0001000);
Please add a new DBRI device ;-).
Or maybe just a field in hwdef + empty_slot? :-)
Or actually don't bother at all. What is expected at
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
When snapshot handlers are not defined in the format driver, it is
better to call the ones of the protocol driver. This enables us to
implement snapshot support in the protocol driver.
We need to call bdrv_close() and bdrv_open() handlers of
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
There's a new ASE_MICROMIPS instruction flag, and some extra CP0_Config3
fields. The ISA and ISA_ON_EXC fields are specific to microMIPS. The
DSP2P is for version 2 of the DSP ASE.
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
+enum {
+OPC_ADD_S = FOP(0, FMT_S),
Adding the enumeration is good. Naming the enumeration and using it
in appropriate places is even better.
@@ -5937,8 +6031,8 @@ static void gen_farith (DisasContext *ctx, uint32_t op1,
enum { BINOP,
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
Acked-by: Richard Henderson r...@twiddle.net
r~
On 06/04/2010 09:08 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Ok third time lucky ... I hope! This fixes the missing git add on
qemu-options.h as building for win32 using mingw (thanks Paolo!).
Acked-by: Richard Henderson r...@redhat.com
r~
On Fri, Jun 04, 2010 at 10:45:32AM -0700, Richard Henderson wrote:
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
@@ -5937,8 +6031,8 @@ static void gen_farith (DisasContext *ctx, uint32_t
op1,
enum { BINOP, CMPOP, OTHEROP } optype = OTHEROP;
uint32_t func = ctx-opcode 0x3f;
On Wed, 02 Jun 2010 09:06:03 +0200
Jan Kiszka jan.kis...@web.de wrote:
From: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Looks good.
---
hxtool |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hxtool b/hxtool
index
The real error is the return value of bdrv_open. errno might be overwritten or
not even set to that value in the first place.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
vl.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 76a9b25..2769d1a
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/pl181.c |1 -
hw/qdev.h |2 ++
hw/ssi-sd.c |1 -
sysemu.h|2 --
4 files changed, 2 insertions(+), 4 deletions(-)
diff --git
From: Markus Armbruster arm...@redhat.com
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/qdev-properties.c |5 +
hw/qdev.h|1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c
On Tue, 1 Jun 2010 19:12:19 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
I have no clue why the code had the is_inserted() check, as it doesn't matter
if there is a disk present at the host drive, when the user wants the virtual
device to be disconnected from the host device.
Makes
From: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp
This patch calls the close handler of the block driver before the qemu
process exits.
This is necessary because the sheepdog block driver releases the lock
of VM images in the close handler.
Signed-off-by: MORITA Kazutaka
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
+case FMT_D:
\
+if (abs)
\
+check_cop1x(ctx);
\
+
From: Markus Armbruster arm...@redhat.com
Anything that moves hundreds of lines out of vl.c can't be all bad.
Signed-off-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
Makefile.objs|2 +-
blockdev.c | 600
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate.c | 106
++-
1 files changed, 59 insertions(+), 47 deletions(-)
Acked-by: Richard Henderson r...@twiddle.net
r~
From: Luiz Capitulino lcapitul...@redhat.com
We should use 'dinfo-serial' length, 'serial' is a pointer, so
the serial number length is currently limited to the pointer size.
This fixes https://bugs.launchpad.net/qemu/+bug/584143 and is also
valid for stable.
Signed-off-by: Luiz Capitulino
On Fri, Jun 4, 2010 at 2:28 PM, Kevin Wolf kw...@redhat.com wrote:
@@ -1674,12 +1659,26 @@ void do_savevm(Monitor *mon, const QDict *qdict)
#endif
const char *name = qdict_get_try_str(qdict, name);
+ /* Verify if there is a device that doesn't support snapshots and is
writable */
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
+int (*ldfun)(target_ulong);
+
+switch (mem_idx)
+{
+case 0: ldfun = ldl_kernel; break;
+case 1: ldfun = ldl_super; break;
+default:
+case 2: ldfun = ldl_user; break;
+}
This *should* now be a compile error. The
On 06/04/2010 10:50 AM, Nathan Froyd wrote:
What's the benefit from declaring op1 as 'enum fopcode' or similar?
Debugging and self-documentation.
r~
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
This patch series adds support for the microMIPS ASE. microMIPS is a
new ASE similar to MIPS16, but re-encodes the entire instruction set
into 16-bit and 32-bit instructions--in contrast to MIPS16, which
re-encodes only integer instructions. The
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
return bad_pc;
}
+static void set_hflags_for_handler (CPUState *env)
+{
Missing vertical space between functions.
r~
On Wed, 2 Jun 2010 13:40:06 +0100
Daniel P. Berrange berra...@redhat.com wrote:
A previous discussion brought up the fact that clients should
not have to parse version string from QMP, it should be given
to them pre-split.
Right.
Change query-version output format from:
{ qemu:
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
linux-user/main.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 18b52c0..76d443b 100644
--- a/linux-user/main.c
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate_init.c | 61
++
1 files changed, 61 insertions(+), 0 deletions(-)
Reviewed-by: Richard Henderson r...@twiddle.net
... not
On Fri, Jun 04, 2010 at 11:30:38AM -0700, Richard Henderson wrote:
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
+int (*ldfun)(target_ulong);
+
+switch (mem_idx)
+{
+case 0: ldfun = ldl_kernel; break;
+case 1: ldfun = ldl_super; break;
+default:
+case 2:
On Fri, Jun 04, 2010 at 11:35:45AM -0700, Richard Henderson wrote:
On 05/24/2010 09:19 AM, Nathan Froyd wrote:
Signed-off-by: Nathan Froyd froy...@codesourcery.com
---
target-mips/translate_init.c | 61
++
1 files changed, 61 insertions(+), 0
Public bug reported:
Tested with 0.12.3, 0.12.4, and latest git as of 4 jun 2010.
The new -netdev type seems to ignore manual specifications of tap ifname.
qemu-system-x86_64 -hda disk.img -netdev tap,id=ids_e0 -device
e1000,netdev=ids_e0
**creates tap0 instead of ids_e0. tap0 passes
On Thu, Jun 3, 2010 at 7:06 AM, Gleb Natapov g...@redhat.com wrote:
On Thu, Jun 03, 2010 at 10:03:00AM +0300, Gleb Natapov wrote:
On Thu, Jun 03, 2010 at 08:59:23AM +0200, Jan Kiszka wrote:
Gleb Natapov wrote:
On Thu, Jun 03, 2010 at 08:23:46AM +0200, Jan Kiszka wrote:
Blue Swirl wrote:
On Tue, Jun 1, 2010 at 8:16 PM, Artyom Tarasenko
atar4q...@googlemail.com wrote:
2010/6/1 Blue Swirl blauwir...@gmail.com:
On Tue, Jun 1, 2010 at 7:56 PM, Artyom Tarasenko
atar4q...@googlemail.com wrote:
2010/6/1 Blue Swirl blauwir...@gmail.com:
On Sun, May 30, 2010 at 10:35 PM, Artyom
Force -m31/-m64 based on s390/s390x target.
Force -march=z990. The TCG backend will always require the
long-displacement facility, so the compiler may as well make
use of that as well.
Signed-off-by: Richard Henderson r...@twiddle.net
---
configure |7 ++-
1 files changed, 6
The default placement of the application at 0x8000 is fine,
and will avoid the default placement for most other guests.
Signed-off-by: Richard Henderson r...@twiddle.net
---
configure |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index
Signed-off-by: Richard Henderson r...@twiddle.net
---
s390-dis.c | 81 +---
1 files changed, 50 insertions(+), 31 deletions(-)
diff --git a/s390-dis.c b/s390-dis.c
index 86dd84f..3d96be0 100644
--- a/s390-dis.c
+++ b/s390-dis.c
@@ -1,3
101 - 200 of 261 matches
Mail list logo
